Fix memory leak in InstanceSaveMgr added in 1f170c99ef .
Make InstanceSave::SetToDelete() private since it's not supposed to be used by anything other than InstanceSave or its friend class InstanceSaveMgr .
Closes#82
* Removed a chunk of duplicate code
* Generalized Message notification
* Generalized checking of resources modification with a min-max
* Generalized checking of single value modification
* Closes#16858
(cherry picked from commit 775b03bf6f)
Conflicts:
src/server/scripts/Commands/cs_modify.cpp
- Clean up of Unit::SetSpeed (mostly cherry picks from the 6.x branch):
- the opcode sent depends on the unit. until now, MSG_MOVE_SET_* were sent for every units which isn't like retail behavior.
- Removed the unused method parameter "forced" from Unit::SetSpeed
- Renamed Unit::SetSpeed to SetSpeedRate
- Removed the unused method parameter "forced" from Unit::UpdateSpeed
- Added utility method Unit::SetSpeed which take the new flat value.
Conflicts:
src/server/game/Entities/Unit/Unit.cpp
src/server/scripts/Commands/cs_modify.cpp
src/server/scripts/EasternKingdoms/ZulAman/boss_zuljin.cpp
src/server/scripts/Kalimdor/zone_azshara.cpp
src/server/scripts/Kalimdor/zone_durotar.cpp
src/server/scripts/Northrend/Nexus/EyeOfEternity/boss_malygos.cpp
- Remove redundant OnGameObjectCreate/Remove, base implementation already takes care of adding and removing doors
- Added missing overrides, fixup bracing and whitespace
- Revamped a little achievement script and get ride of ugly CAST_AI
* Core/UnitAI: SelectTarget correction
Set CurrentVictim as first element on targetList if necessary, which is then filled with the threatlist elements that satisfy the predicate.
…r or not a daily quest has been completed by a player in that day.
Also use it to fix two quest chains broken in commit 7905651. Should be the only ones of their kind.
Add all 6 spells available from item 20557,
Hallow's End Pumpkin Treat:
- Hallow's End Candy, Orange Giant (24924)
- Hallow's End Candy, Skeleton (24925)
- Hallow's End Candy, Pirate (24926)
- Hallow's End Candy, Ghost (24927)
- Hallow's End Candy, Female Defias Pirate (44742)
- Hallow's End Candy, Male Defias Pirate (44743)
Thanks @Keader for creating the new spell scripts & SQL,
saved me a lot of time! :-)
