Commit Graph

18894 Commits

Author SHA1 Message Date
zartech22
c57c26d7fb Add realm ID for actions based ip logging (#24453)
* Update SQL queries to insert realm id

* Insert the realm id when logging actions based on IP

* Adding the SQL update file

* Update 9999_99_99_99_auth.sql

* Update auth structure

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
(cherry picked from commit 56f20d69a6)
2022-01-01 19:38:40 +01:00
Gildor
e67e0ff9fb Scripts/Naxxramas: Fix Heigan Eruption spell (#24470)
(cherry picked from commit 6c7c2c6cd2)
2022-01-01 19:17:54 +01:00
Ovah
a3d28efcfa Core/Movement: various improvements for creature knockbacks
* creature knockbacks will no longer generate a full path but instead only use a destination point to reflect sniff data
* calculate the destination by using a mmap raycast instead of using a mmap path which had the chance of creating weird movements when GetNearPosition failed to get a proper collision point (knocking arround a tree for example or just somewhere it should not go at all)

(cherry picked from commit cfd63c350f)
2022-01-01 19:17:05 +01:00
Alan Deutscher
68e1dc8adb Core/Players: Improve trade exchange calculations (#24435)
* Add some comments to Player::CanStoreItems to help me wrap my head around how the method works.

* Experimental fix for incoming trade-stack problem.

* Only add to stacks that aren't already full.

* Use remaining_count instead of static 1.

* Remove debug logging from exploration.

* More uses of remaining_count for consistency.

* Correct space count check

* Correct overflow problem.

* Remove redundant check, handled in existing for statement.

* Store Item pointers in order to be able to merge in multiple incoming stacks.

* Build fix - was continually working locally, but failing in CI.

* Break build in order to keep PR focused on Player.cpp changes.

* Adjust phrasing of how arrays are initialized.

* Fix phrasing of comments to avoid sounding like a ToDo item

* In the spirit of b649273d5f, rephrase an old comment to be a statement rather than a question.

(cherry picked from commit e11a13c755)
2022-01-01 16:29:06 +01:00
Keader
6957dd9bd6 Scripts/Ulduar: Little improvements in Auriaya
* Removed DespawnAtEvade
* Fix Feral Defender Damage

(cherry picked from commit 77dd751499)
2022-01-01 15:54:52 +01:00
Keader
0484c0a337 Scripts/Trial of Crusader: Fixed issue with Snobold Vassal and some achiev criteria resets
* Fixed snobold behavior when gormok dies
* Fixed UPPER_BACK_PAIN Archiev reset
* Fixed THREE_SIXTY_PAIN_SPIKE Archiev reset

(cherry picked from commit 78dff46bf2)
2022-01-01 15:51:21 +01:00
Gildor
a477e85ae3 Scripts/Quest: The Exorcism of Colonel Jules (#24459)
* Remove Anchorite Barada gossip when event start

(cherry picked from commit 8a5b02be0a)
2022-01-01 15:51:07 +01:00
ForesterDev
e73735fa61 Core/PacketIO: updated SMSG_DURABILITY_DAMAGE_DEATH (#24442)
- use RATE_DURABILITY_LOSS_ON_DEATH for death from falling
- add note, that RATE_DURABILITY_LOSS_ON_DEATH doesn't change log message

(cherry picked from commit a1831e0c1e)

Co-authored-by: MitchesD <majklprofik@seznam.cz>
(cherry picked from commit e1a8ebc064)
2022-01-01 15:25:11 +01:00
Gildor
60e66621da Core/Gameobjects: Improve stealth detection (#24417)
* Core/Gameobjects: Improve stealth detection

* fix warning: private field 'i_funit' is not used

* Code cleanup

* add comment

Co-authored-by: jackpoz <giacomopoz@gmail.com>
(cherry picked from commit 862097a633)
2022-01-01 15:05:01 +01:00
Sven
2aa5f4e1b2 Improvements to Pyroguard Emberseer (UBRS) script (#24405)
* UBRS: Improve Pyroguard Emberseer script

* Remove whitespaces

* More whitespaces removed

* Addressing change requests
Removed cast from constructor
Removing unused member field

* That should be the last white spaces

* Forgot to remove the declaration

* Update boss_pyroguard_emberseer.cpp

* Add break to For loop

* War on white spaces

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
(cherry picked from commit c3037c3563)
2022-01-01 14:52:43 +01:00
ForesterDev
931ca1e546 Core/PacketIO: updated SMSG_FEATURE_SYSTEM_STATUS (#24403)
* Core/Packets: updated SMSG_FEATURE_SYSTEM_STATUS

(cherry picked from commit 231207970b)

* Define complaint status values and replace magic numbers

* Add missing header

Co-authored-by: joschiwald <joschiwald.trinity@gmail.com>
(cherry picked from commit bfd73e7f47)
2022-01-01 14:43:20 +01:00
Sorikoff
26ae6df032 Scripts/Pets: Mojo (#24431)
* Mojo

* Update

* Rename 9999_99_99_99_world.sql to 2020_04_11_01_world.sql

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
(cherry picked from commit 194691f7c3)
2022-01-01 14:38:52 +01:00
jackpoz
7eff81f9db Core/Pools: Fix crash on startup
(cherry picked from commit 9cde3ffd14)
2022-01-01 14:34:20 +01:00
Giacomo Pozzoni
97c1d01cbb Core/Pooling: Remove respawn times from the database when despawning a pool (#24422)
* Core/Pooling: Remove respawn times from the database when despawning a pool

Remove respawn times from the database when despawning a pool. This is needed when a Game Event ends but there are still some respawn times saved in the database.

* Remove respawn time of active pool objects even if they are not spawned

(cherry picked from commit 4f33fd3932)
2022-01-01 14:02:00 +01:00
Killyana
281e695c56 Creature: Gorkun Ironskull & Martin Victus in The Pit of Saron
Still some events are missing in this instance

(cherry picked from commit d0f9ace679)
2022-01-01 13:48:05 +01:00
Shauren
2f17038373 Scripts/Eye of Eternity: Fixed The Focusing Iris not respawning on wipe
Closes #22948

(cherry picked from commit f57b1e27d0)
2022-01-01 13:28:41 +01:00
Shauren
ba69c91f4b Core/Spells: Fixed checking free inventory space for some spells that have bad dbc data
Closes #24423

(cherry picked from commit 18b36734f6)
2022-01-01 13:28:04 +01:00
Giacomo Pozzoni
a947ee1912 Core/SAI: Allow SMART_TARGET_ACTION_INVOKER to target GameObjects (#24416)
* Core/SAI: Allow SMART_TARGET_ACTION_INVOKER to target GameObjects

* Include new Coalesce(..) template by @Shauren

(cherry picked from commit 90b00288c2)
2022-01-01 13:06:27 +01:00
jackpoz
68d947d42f Core/Log: Log all character kicks to "network.kick" category
(cherry picked from commit 31018c3652)
2022-01-01 12:56:24 +01:00
jackpoz
dbb0f399fa Core/NetworkIO: Adjust more packet throttling values
Thanks @Nefertumm at f5e38a7f57 for the heads-up

(cherry picked from commit 68fcd592f8)
2022-01-01 12:44:07 +01:00
jackpoz
33e495983b Core/Movement: Add safety check to avoid C++ undefined behaviour
(cherry picked from commit 67f28adaf7)
2022-01-01 12:42:31 +01:00
Ovah
d18d2b84f2 Core/Objects: cache current liquid status of objects when updating position data and use it to replace unnecessary vmap lookups (#24399)
* dropped unneeded IsUnderwater override for players since the default position data update considers collision height already so we don't have to rely on that tempfix anymore. This actually fixes breathing bars showing up depending on your characters size (gnomes get their breathing bar earlier, taurens later etc)

(cherry picked from commit bea850fb73)
2022-01-01 12:42:17 +01:00
Shauren
9f76071108 Core/Misc: Remove whitespace at the end of lines 2022-01-01 01:25:04 +01:00
kvolk2git
285e3a1ed2 Core/DBUpdater: Fixed db auto updater for mysql 8 when ssl connections are enabled (#27298)
(cherry picked from commit 57617e215b)
2022-01-01 01:11:58 +01:00
Shauren
3b4a2a0a94 Core/DBLayer: Fix compilation with mysql 8
(cherry picked from commit 579d41acc5)
2022-01-01 01:10:25 +01:00
myuzhobcplidtkieno
de5f7edede Added the ability to use TLS when connecting to a database. (#24348)
* Added the ability to use TLS when connecting to a database.

* Trying to kickstart CI checks

* Revert the kickstart change

Co-authored-by: myuzhobcplidtkieno <myuzhobcplidtkieno@github.com>
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
(cherry picked from commit ae553f8966)
2022-01-01 01:07:52 +01:00
jackpoz
95de1db5fc Scripts/Guards: Fix spell cast spam after killing npc_air_force_bots guards
(cherry picked from commit 0844ad2ff0)
2022-01-01 01:02:17 +01:00
jackpoz
f1f8af9c5f Core/Misc: Replace tabs with spaces
(cherry picked from commit cb41c8828f)
2022-01-01 01:01:42 +01:00
jackpoz
ecdc387df2 Core/Misc: Remove whitespace at the end of lines
(cherry picked from commit caae3886d2)
2022-01-01 01:00:26 +01:00
Giacomo Pozzoni
a9e325f6b7 Core/Logs: Log full guid instead of just low guid, part 2
(cherry picked from commit 3def52c1c4)
2022-01-01 00:51:54 +01:00
Giacomo Pozzoni
6ec933f281 Core/Logs: Log full guid instead of just low guid
(cherry picked from commit 468ecb7252)
2021-12-31 21:56:40 +01:00
NoName
25e68fc5c2 Core/PacketIO: Handle CMSG_REQUEST_PET_INFO for more cases (#24364)
+ vehicle
+ charm
+ possession

from 87c6cc19e5

(cherry picked from commit fbcd244b2f)
2021-12-31 21:56:33 +01:00
jackpoz
89cb6bc683 Core/Battleground: Attempt to fix a crash
Please report this error if you get it

(cherry picked from commit d1f9cf84a5)
2021-12-31 20:33:52 +01:00
Rushor
96324ad908 Scripts/BlackfathomDeeps: Kelris will now channel his spell (#24300)
* Scripts/BlackfathomDeeps: Kelris will now channel his spell

* Scripts/BlackfathomDeeps: Kelris will now channel his spell

(cherry picked from commit 3da8f37ddb)
2021-12-31 20:16:45 +01:00
Jozef Dúc
8b0cb21c49 Scripts/Pet: Baby Blizzard Bear & Egbert (#24349)
* Baby Blizzard Bear & Egbert

* SQL

* Update 9999_99_99_99_world.sql

SQL fix

* Rename 9999_99_99_99_world.sql to 2020_04_04_00_world.sql

Co-authored-by: Eridium <6587064+Killyana@users.noreply.github.com>
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
(cherry picked from commit 264a583903)
2021-12-31 20:16:30 +01:00
Sorikoff
44c8b5241a Scripts/Pet: Baby Blizzard Bear & Egbert (#24349)
* Baby Blizzard Bear & Egbert

* SQL

* Update 9999_99_99_99_world.sql

SQL fix

* Rename 9999_99_99_99_world.sql to 2020_04_04_00_world.sql

Co-authored-by: Eridium <6587064+Killyana@users.noreply.github.com>
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
(cherry picked from commit 264a583903)
2021-12-31 20:15:58 +01:00
Sorikoff
99d7201112 Core/DB: Add DB error for missing gossip npcflag (#24375)
* Add DB error for missing npcflag

* Improvements

* Update ObjectMgr.cpp

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
(cherry picked from commit a513922fc1)
2021-12-31 20:00:41 +01:00
Eridium
924116f046 Core/Movement: Formation Rewrite (#24379)
* Core/Movement: Formation Rewrite

* Add a missing include

* fixed another warning

* meh

Co-authored-by: Ovahlord <Ovahlord@users.noreply.github.com>
Co-authored-by: Ovah <dreadkiller@gmx.de>
(cherry picked from commit 0e2342c169)
2021-12-31 19:28:14 +01:00
Lewis Brumby
756ec4e43c Update action_ip_logger.cpp (#24371)
(cherry picked from commit b48c50ba23)
2021-12-31 19:05:27 +01:00
Shauren
2565af5fd3 Scripts/Spells: Fixed startup errors in spell_gen_war_mode_enlisted 2021-12-31 14:16:59 +01:00
Shauren
9d060d23c1 DB: Convert databases to utf8mb4 2021-12-31 13:59:55 +01:00
Ovah
fb7a60d49d Core/Spells: fixed a possible client crash when casting pull towards dest spells with misc value 0 (#24365)
* This case is not happening in 335 yet as it barely has any spell with pull towardst dest effects. However, this is very well present in 4.x and beyond so let's add it for future cherrypicks

(cherry picked from commit 61aec37b4f)
2021-12-31 00:55:12 +01:00
Killyana
5cde08e6e8 Boss/Script: Disable Call assistance for Mr Smite
Closes #19164

(cherry picked from commit c026b3bad3)
2021-12-31 00:54:21 +01:00
Killyana
5e1f46f3c0 Boss/Script: Mr Smith will use the proc aura for Nimble Reflexes instead a script
(cherry picked from commit 5b2b221177)
2021-12-31 00:54:06 +01:00
jackpoz
37543109f6 Core/Movement: Don't start a spline with just 1 point in FlightPathMovementGenerator
Don't start a spline with just 1 point in FlightPathMovementGenerator. This happens when teleporting to a BG while on a taxi after second last node but closer to last node.
In this case the Player will be teleported to the last node.

(cherry picked from commit ec49576491)
2021-12-30 20:59:20 +01:00
jackpoz
040af829ca Core/Movement: Improve log when starting a spline with invalid arguments
Improve log when starting a spline with invalid arguments, for example when starting a spline with just 1 point.

(cherry picked from commit 296f6aab40)
2021-12-30 20:58:53 +01:00
Meji
9354b4ac8e Core/Spells: Implemented battle pet experience related spell effects and auras (#27488)
* Spell effect 286 (SPELL_EFFECT_GRANT_BATTLEPET_EXPERIENCE)
* Aura type 420 (SPELL_AURA_MOD_BATTLE_PET_XP_PCT)
2021-12-30 20:38:29 +01:00
aquadeus
9cc3cd128c Core/Auras: Implement SPELL_AURA_MOD_MELEE_DAMAGE_FROM_CASTER (343) (#27491) 2021-12-30 12:08:02 +01:00
Shauren
6391cf8a35 Core/Networking: Format string fix for previous commit 2021-12-30 11:56:35 +01:00
Shauren
74088e15c1 Core/Networking: Catch ByteBuffer exceptions in WorldSocket::InitializeHandler 2021-12-30 11:53:31 +01:00