Treeston
c69584a967
Game/AI: Remove some unused old logic.
2018-01-29 01:57:31 +01:00
Treeston
0ee14845ae
typo
2018-01-28 02:41:33 +01:00
Treeston
320306554c
Core/Creature: add an assertion to guard against infinite loops
2018-01-28 01:51:50 +01:00
Aokromes
4130647bf6
Core/Misc: Sort string
2018-01-27 16:20:41 +01:00
Shauren
21ad8761e9
Core/Spells: Exclude spells with no MaxLevel from coefficient downranking penalty
2018-01-27 13:06:48 +01:00
Shauren
2ab4e6c7aa
Core/Spells: Fixed downranking coefficient penalty formula
...
Closes #21318
2018-01-27 12:19:18 +01:00
ccrs
275c17b4c2
Revert "Core/SmartAI: Remove duplicate OnReset() call"
...
This reverts commit 42c9289be3 .
2018-01-26 23:56:39 +01:00
sirikfoll
42c9289be3
Core/SmartAI: Remove duplicate OnReset() call
...
It is already called for every creature in SmartAI::InitializeAI(), removing the one from SmartAI::JustAppeared to keep as much as possible of the old behavior, because JustAppeared is called on the next tick after InitializeAI
Closes #20881
Closes #20771
2018-01-26 19:18:10 -02:00
Treeston
51e28ae76a
DB/SpawnGroup: Instance spawn group data for Tempest Keep: The Eye and Hellfire Citadel: Ramparts.
...
(also some minor adjustments to command output for convenience)
2018-01-25 13:45:11 +01:00
Treeston
6c3c200cc5
Misc: assert -> ASSERT
2018-01-25 12:39:19 +01:00
Treeston
6ce078d8e8
Scripts/Commands: new command '.debug instancespawn'
2018-01-24 22:52:42 +01:00
ariel-
b1072faa50
Core/Spell: killed deprecated code which randomly changed powercost for missed spells
...
Added in 80d3cd43f6
Closes #5954
2018-01-24 13:07:01 -03:00
ariel-
8e0af1b93b
Core/Player: only call _ApplyWeaponDamage for actual weapons
...
Closes #21308
2018-01-24 00:05:25 -03:00
ariel-
c099174ff7
Core/Misc: fix some /W4 warnings and some reported by GCC 6.3
2018-01-22 23:55:33 -03:00
ariel-
7c9722a4ae
Core/Entities: killed Creature::SetInCombatWithZone and replaced with AI version
...
Closes #12108 (again)
2018-01-22 15:00:55 -03:00
ariel-
e315e41d36
Core/Entities: don't allow client control if player is still affected by any lose of control state
2018-01-22 14:13:46 -03:00
ariel-
590d251882
Core/PlayerAI: perform cast checks on auto ranged attack
...
Closes #19928
2018-01-22 14:02:01 -03:00
ariel-
514c847881
Core/Unit: fixed Global cooldown cancelation on spell interrupt
...
Thanks to Nyeriah for the heads up
2018-01-22 03:55:14 -03:00
ariel-
73cc613dc8
Core/Formations: update codestyle and fix crash
...
Closes #21288
2018-01-22 02:43:34 -03:00
ariel-
4402f71eb7
Core/Spells: fix Spirit of Redemption
...
- Who would have suspected GetAuraEffect (iconId override) did a check against null spellfamilyflags?
- Remove mirror timers hack (triggered spell already allows underwater breathing)
2018-01-21 21:18:02 -03:00
tkrokli
3feb8a6955
Core/Misc: 2 comment corrections in Language.h
...
- comments adjusted to match the unordered enum LANG_DO_NOT_USE_6X_DEBUG_AREATRIGGER_LEFT
2018-01-21 23:31:40 +01:00
Shauren
ef014d0832
Core/Misc: Revert LANG_DO_NOT_USE_6X_DEBUG_AREATRIGGER_LEFT change from ba5f6a8616
...
* It may be out of place but at least matches db value and matches master branch
2018-01-21 23:21:43 +01:00
tkrokli
ba5f6a8616
Core/Misc: corrections and indentations in Language.h
...
- corrected the comment "1205-2002 - free" to "1205-1999 - free"
- increased the main indent by 2 spaces to get more lines aligned
- corrected the enum LANG_DO_NOT_USE_6X_DEBUG_AREATRIGGER_LEFT from 1999 to 1199
Ref. commit 5f54149107
2018-01-21 23:11:05 +01:00
Treeston
2c86c78f04
Core/Unit: Remove a superfluous threat state update in SetPhaseMask.
2018-01-21 15:34:39 +01:00
joschiwald
5f54149107
Core/Battleground: Dropped battleground texts from trinity_string and replaced them with proper BroadcastText
...
(cherry picked from commit ed318fdc46 )
Fixed nopch build
(cherry picked from commit 6eff69818b )
Fixed nopch build again
(cherry picked from commit 3039f4bf86 )
2018-01-21 13:41:02 +01:00
Treeston
013d4560c7
Core/Threat: Assistance threat (healing, buffs, etc.) is now properly split (instead of copied) between all creatures threatened by the action. Thanks to Foereaper for help with testing, and my apologies to healers everywhere.
...
(No apologies for charm AI though. You deserve that one.)
2018-01-21 02:14:17 +01:00
Treeston
a373275612
Core/Threat: Passive creatures now properly become engaged when adding an offline threat entry. Fixes RoS and Thaddius, maybe more. Closes #21269 .
2018-01-21 01:16:35 +01:00
ariel-
9f5d1e2b10
Core/Scripts: fix wrong uses of SetHitDamage hook.
...
This hook modifies damage AFTER it has been reduced by target auras/armor/resistances etc, it's useful if you want to scale damage by a factor, but not to add flat bonuses.
We're fixing those by moving calculation to Launch phase, where target taken bonuses haven't been used yet.
- Bronjahm: Magic's Bane
- BPC: Shadow Prison
- Oculus: Shock Lance
- Ymiron: Dark Slash (extra fix, it was wrongly damaging half of total health, it's supposed to be half of CURRENT health!)
- DK: Raise Ally Thrash spell (also extra fix: corrected formula)
- Warrior: Bloodthirst (shouldn't matter much as it's damage class none and those don't get bonuses by default)
- Warrior: Concussion Blow
- Warlock: extra fix for Haunt, healing part shouldn't scale with spell power
Closes #9560
2018-01-20 21:09:22 -03:00
ariel-
fa3eb754cb
Core/Unit: fixed Lava Burst crit when Flame Shock is present on target
...
Closes #21268
2018-01-20 00:15:48 -03:00
ariel-
f1896144c0
Core/Auras: fixed EquippedItemClass check
...
follow-up to 29c3b7d8f6
2018-01-18 19:14:38 -03:00
ariel-
b8c281f497
Core/Auras: Don't remove shield only dependant auras on disarm
...
Closes #19782
2018-01-18 16:29:21 -03:00
ariel-
29c3b7d8f6
Core/Auras: define and implement attribute SPELL_ATTR3_IGNORE_PROC_SUBCLASS_MASK
...
Closes #20148
2018-01-18 16:08:24 -03:00
ariel-
b75ff7d4bf
Core/Globals: revert back to unordered_map for templates
...
Partial revert of commit b64c504314
See discussion on b64c504314
2018-01-18 01:07:29 -03:00
sirikfoll
e12e0ad582
Core/CombatAI: Npcs with TurretAI will be able to attack again
...
Needed after the new Threat system
2018-01-17 19:01:09 -02:00
sirikfoll
ed9e220991
Core/Player: Pass correct Zone ID to HandlePlayerLeaveZone
...
This will fix some issues with Wintergrasp, like phasing auras getting stuck and missing group invites for the battle, among others
2018-01-17 18:59:20 -02:00
ariel-
b64c504314
Core/Globals: throw some RAII into ObjectMgr, and load templates into vectors
...
Ref #14274
2018-01-17 02:17:49 -03:00
ariel-
ccf0807be0
Core/Unit: check remaining instead of full duration for Bounced by DR auras
2018-01-16 20:51:07 -03:00
Moein
891bca934e
Core/SAI: Extended SMART_TARGET_VEHICLE_PASSENGER to allow specifying seat mask instead of single seat index (can now target all passengers) ( #21245 )
2018-01-16 21:28:41 +01:00
ariel-
3d7166c1c7
Core/Creatures: creatures only have one damage
...
Closes #21236
2018-01-16 14:44:04 -03:00
Treeston
1847555c8c
Core/Threat: Fix a potential crash that would occur in specific edge cases of AI being a bit naughty.
2018-01-15 15:42:41 +01:00
ariel-
5153f464d8
Core/Auras: fix static analysis issues
...
CID 1384433
CID 1384436
2018-01-14 17:23:48 -03:00
ariel-
01537e1dfb
Core/Unit: fix mess-up with CalcArmorReducedDamage parameter order
2018-01-14 17:19:26 -03:00
ariel-
46fcbb42d2
Core/Unit: fix typo
2018-01-14 09:30:42 -03:00
ariel-
f1986c6aaf
Core/Entities: implement secondary damage for some weapons and removal of old voodoo
...
- Fixed correct Retaliation damage spell according to sniffs is 20240
- CalcArmorReducedDamage insisted on dealing a minimum of 1 damage even if damage was 0
- CalculateDamage was zero-phobic too: it defaulted to arbitrary max 5 damage
Closes #19081
2018-01-14 09:23:34 -03:00
ariel-
688e96fb4f
Core/Unit: allow miss chance to exceed 60% cap with certain auras
2018-01-13 23:33:40 -03:00
ariel-
0e9b1635e0
Core/Unit: fix Sanctified Wrath (again)
...
- Actually only rank 1 was affected because of 50% reduction on rank 2
2018-01-13 21:59:20 -03:00
ariel-
22b24d8dae
Core/Unit: fixed crash
...
Closes #21231
2018-01-13 21:36:06 -03:00
ariel-
d570e2af3e
Core/Unit: simplified and arranged spell bonus calculation
...
- Remove duplicated SPELLMOD_BONUS_MULTIPLIER handling (both on done and taken)
- Handle properly bonus data, don't apply bonus by default, only player spells should take into account spell power
- Moved Earthliving Weapon coefficient to DB
- Refactored Avenging Wrath handling
Closes #13287
Closes #21230
2018-01-13 20:49:44 -03:00
ariel-
3b01cccd7e
Core/Spell: SpellValueOverrides encapsulation
...
- No sense to let scripts use SpellValueOverrides, we already have modifiers in CastSpellExtraArgs struct
2018-01-13 20:49:43 -03:00
ariel-
31a3a6f0c5
Core: fix non pch build, redux
2018-01-13 17:07:25 -03:00