Remove script for Khadgar all of the gossip menus and options are already in db and this is only a gossip script, will deal with db stuff in next commit
Some additions to 137c8a7de9
* Add a missing npc_text where gossip menu had already existed in db with this text and core script sent this text as gossip but text was not in db
* Correct option id for a option.
Move CPP script npc_mount_vendor to db
* Sniffed gossip menu for Veron Amberstill as we did not have this
* There is more than one text per gossip for these, readded all gossip menus we have to include the ones that where not in db already
* Conditions for vendor option and texts to only sell to elegible to players and show correct texts
We do not have text for Dreanei or dwarf have not checked gnome one since that one had already been moved to db since npc had sai
closes#13088
* Add strange aura to spell_area for Cenarion Thicket (someone had tried getting the druids to cast this on themselves in sai whoever did obviously did not read this AttributesEx3: 0x00000100 (SPELL_ATTR3_ONLY_TARGET_PLAYERS)
* However even when aura is active it still would not hit druids only the Broken Corpses, found that the druids should not even have this aura (proper auras are permament feign death + blue radiation), also in sniff unit_flags2 is 2049 (we had 2048) and dynamic flags 0 (we had 40)
* Also removing stun from unit flags, this makes no difference in game as npc gets those flags from feign death
Ok so found I needed to rescript this to as had not noticed there was already a script on Fezzix Geartwist for this quest, this sai has got same flaws as cpp version had, when npc gets attacked and evades looses crates aura (another example of the thing with auras getting removed at evade causing problems),
* Quest turn in scripts for Souls of the Decursed, The Power of the Elements and Patching Up
* Proper script for Gearmaster Mechazod
* Rescripted Bury those Cockroaches to SAI, now includes the texts from the mines, also credit npc will no longer be knocked out of sink hole by first person to do quest after a restart rendering the quest non working to all other players who try after due to the npc present not been where its meant to be
* A couple of other one line fixes
- Allow to set a default duration for the Freeze Aura in worldserver.conf
- Handle the .freeze and .unfreeze command custom effects through the Freeze AuraScript
- Make players able to eventually unfreeze by themselves since the aura will expire without someone having to use .unfreeze
- Make .freeze command usable with the following syntax:
* .freeze (with a targeted player)
* .freeze duration_in_seconds (with a targeted player)
* .freeze playername duration (if duration is an invalid value it will be defaulted to the config one)
* .freeze playername (in this case, duration will be defaulted to the config value)
- Make .listfreeze command able to show the remaining freeze duration on all affected players
Closes#12972
Proper conditions for champions quests
Battle Before The Citadel, Taking Battle to the Enemy, Among the Champions and Threat from Above require that player is a champion ie has done quest a champion rises
Quests Eadric the Pure / The Scourgebane require that player is a champion
Threat from above has two requirements - That player is a champion and player has completed the black knights orders
The black knights Fall requires that player is a champion, quest chain breaks at the black knights orders if you are not champion
cppcheck performance warning:
[src/server/shared/Configuration/Config.cpp:62]: (performance) Passing the
result of c_str() to a function that takes std::string as argument no. 1 is
slow and redundant.
