Commit Graph

30709 Commits

Author SHA1 Message Date
Dr-J
64f3c5c4ef DB/Quest: Bury Those Cockroaches
event flags again.
(cherry picked from commit 2730576823)

Remove space
(cherry picked from commit c07bd6d467)
2017-03-02 21:12:27 +01:00
treeston
b12f19f066 Movement/SplineChain: Streamline the script workflow for resume info a bit, provide static method that does all the ugly pointer casts for you. Also prevent a nullptr dereference crash if scripts mishandle motionmaster, and canonize Chain == nullptr to signify "no resume info".
(cherry picked from commit d3214a0012)

d3214a0 follow-up for code style.
(cherry picked from commit 4deeee66bd)
2017-03-02 21:10:00 +01:00
treeston
ec9c5b19ac Map/InstanceMap: Ease up on a somewhat overzealous error message regarding instance saves.
(cherry picked from commit 820e843391)

# Conflicts:
#	src/server/game/Maps/Map.cpp
2017-03-02 21:09:24 +01:00
Dr-J
02cfa86f8e DB/Quest: The Sum is Greater than the Parts
(cherry picked from commit 9804bb252a)
2017-03-02 20:54:07 +01:00
Dr-J
f204e758d5 DB/Quest: Escape from Silverbrook
Even though this was meant to have been fixed once the last commit did not actually fix this
also condition for the periodic spell so that it only targets silverbrook worgen rather than agroing neutral deers and stags, hostile npcs like bears and conquest hold guards will still attack the horse but the condition prevents the periodic threat spell from hitting anything other than silverbrook worgen.
(cherry picked from commit f7f00d2f08)
2017-03-02 20:53:21 +01:00
Dr-J
86ecdaf44a DB/SAI: Krolmir, Hammer of storms
Fix targeting for credit spell and invoker texts during event.
(cherry picked from commit 1cc75eb924)
2017-03-02 20:52:34 +01:00
treeston
019fc08feb Core/Movement: Fix a DB spline chain overload I missed in 2170541
(cherry picked from commit 3ec1b2f27e)
2017-03-02 20:51:25 +01:00
Dr-J
23fb555391 DB/SAI: More event flags
* Dark Horizon/Reunited
* Kickin' Nass and Takin' Manes
* Load'er Up
* Magic Carpet Ride
(cherry picked from commit fc494f1f47)
2017-03-02 20:51:15 +01:00
treeston
0920ffb7e8 DB/Creature: Re-sniffed Blighted Elk and Rabid Grizzly spawns. Closes #17958. (Thanks, Malcrom!)
(cherry picked from commit 17dfcc0b27)
2017-03-02 20:50:17 +01:00
treeston
205ec4c3bf Core/Unit: Standardize SetFacingTo and SetFacingToObject behavior while moving. Both now fail while moving unless arg2 bool is true.
Movement/SplineChain: Bump value range for DB chainId up to uint16 (0 to 65535) from uint8 (0 to 255). Turns out sniffs generate far more chains than I expected.

(cherry picked from commit 2170541a51)

Code style follow-up, I blame Notepad++.
(cherry picked from commit 7860da0de6)
2017-03-02 20:47:29 +01:00
treeston
b94642fb49 Instance/Naxxramas: Loatheb no longer instantly murders you. Five spam casts of Doom tend to do that to raids.
(cherry picked from commit 59527521e6)

5952752 follow-up: Member declaration now matches order of usage.
(cherry picked from commit 3298a5f65d)
2017-03-02 20:44:41 +01:00
Dr-J
c07ee298dc DB/SAI: A Rough Ride
Fix event flags
(cherry picked from commit ab2acb2c0c)
2017-03-02 20:44:18 +01:00
Shauren
2c27c5b5b9 Core/DataStores: Fixed crash in hotfix packet building
Closes #19218
2017-03-02 19:48:58 +01:00
treeston
59d48ce7e4 Core/Movement: Add new SplineChainMovementGenerator that allows accurate replication of sniffed waypoints in static sequences, along with DB facilities that allow loading of waypoints from DB.
(cherry picked from commit 6d00d3f283)

Merge remote-tracking branch 'Treeston/3.3.5-splinechains' into 3.3.5 (PR #17946)
(cherry picked from commit 20f483967f)

Core/Movement: Add a convenience default ctor to SplineChainResumeInfo, and fix PCH build in some configurations (zzz why do we even keep Appveyor and Travis around).
(cherry picked from commit 4fa646c0b2)

PCH build fix. Again.

(( Alright, you made me waste 20 minutes of my life on a full nonPCH rebuild of the core now. ))
(( I hope you're happy. ))
(cherry picked from commit 4a1a460241)
2017-03-01 22:03:35 +01:00
SnapperRy
9aa4b6d10f DB/Loot: Burning Legion Missive (Alliance version) should always drop.
(cherry picked from commit 7bce4d12a6)
2017-03-01 21:27:33 +01:00
SnapperRy
1bed93ca7c DB/Loot: item Bog Lord Tendril is not a quest item.
(cherry picked from commit 1812a57b4e)
2017-03-01 21:26:38 +01:00
SnapperRy
30105cd522 DB/Quest: Arzeth's Demise:
- Fix yell on quest item use.
- Restore original entry on reset.
- Quest item can only be used on specific NPC.
(cherry picked from commit e2981e1060)
2017-03-01 21:25:29 +01:00
Killyana
05776111e3 DB/Creature: Fix unit flag for Tatjana (Unconscious)
Closes  #15618

(cherry picked from commit 56d20584c7)
2017-03-01 21:24:32 +01:00
Dr-J
59d22ade76 DB/Quest: Anatoly will talk
Fix event flags
(cherry picked from commit f27efa5957)
2017-03-01 21:21:25 +01:00
Dr-J
59590b5395 DB/Misc: Misc Fixes
* Appeasing the Great Rainstone/Gods like Shiny Things update so sai actually works on sholazar guardians so sai runs on charmed creature, also rescript glinting dirt as previous had stopped working
* Teleport This! Charmed flags are needed here so that credit spell is cast when payer uses controlled npc to blow up teleporter.
* Updates to blueleaf tubers as previous fix stopped working due to negative respawn time on spell focus objects
(cherry picked from commit ebc0190d3b)
2017-03-01 21:19:22 +01:00
treeston
c2a7857c8a DB/SmartAI: Fix charm SAI for Quest 12308 "Escape from Silverbrook"
(cherry picked from commit 8d2f17b2a8)
2017-03-01 21:17:07 +01:00
treeston
8ad043ba69 DB/Creature: Add missing IMMUNE_TO_NPC to Dahlia Suntouch.
(cherry picked from commit 8389991275)
2017-02-28 20:41:40 +01:00
tkrokli
e4e1f4152f Core/Scripts: simplified npc_pet_trainer gossip script
This is what the script changes should have been in PR #17746
(also updates issue #14719 with a correct solution).

- remove OnGossipHello() to use DB conditions
- replace OnGossipSelect() with sGossipSelect()
- focus script on the confirming gossip option
- let the other gossip menus be handled in DB

(cherry picked from commit a475033c76)
2017-02-28 20:40:49 +01:00
SnapperRy
953eef9761 DB/Quest: fix prevquests required for Gretta the Arbiter's daily quests.
(cherry picked from commit 0b658f789c)
2017-02-28 20:40:30 +01:00
SnapperRy
d119872589 DB/Quest: Dragonblight/Borean Tundra:
- Fix next quest for The Taunka and the Tauren.
- Fix requirements for Patience is a Virtue that We Don't Need, Taken by the Scourge and the three versions of The Defense of Warsong Hold.
(cherry picked from commit fd6cf2bca6)
2017-02-28 20:39:37 +01:00
SnapperRy
4ea38046b1 DB/Quest: Dragonblight part 2:
- To Dragon's Fall requires completion of Wanted: Magister Keldonus, Wanted: Gigantaur and Wanted: Dreadtalon.
- Black Blood of Yogg-Saron, Marked for Death: High Cultist Zangus and Containing the Rot require completion of Agmar's Hammer.
- Strengthen the Ancients requires completion of The Focus on the Beach.
- Message from the West requires completion of Hellscream's Champion.
- Only one between A Tauren Among Taunka and The Taunka and the Tauren can be completed.
(cherry picked from commit b90afa8857)
2017-02-28 20:38:41 +01:00
SnapperRy
a893855e07 DB/Quest: Dragonblight:
- Victory Nears... requires Agmar's Hammer.
- Strength of Icemist requires From the Depths of Azjol-Nerub.
- Only one between To Venomspite! and Imbeciles Abound! can be completed.
(cherry picked from commit e07f68a032)
2017-02-28 20:37:47 +01:00
SnapperRy
03c2c1429e DB/Conditions: allow item Goramosh's Strange Device to also drop if the quest Prevent the Accord is rewarded.
Prevents players from possibly getting permanently locked out of a whole quest chain in Dragonblight.
(cherry picked from commit 48203e2e25)
2017-02-28 20:36:18 +01:00
SnapperRy
e9b6321e34 DB/Quest: fix previous quests required before being able to accept The Kor'kron Vanguard!
No more easy shortcut for Horde players!
(cherry picked from commit 72cfafc0b3)
2017-02-28 20:35:00 +01:00
SnapperRy
19c38e86a0 DB/Quest: add missing prevquests for Hellfire Fortifications (for both Alliance and Horde).
(cherry picked from commit 96026dbe55)
2017-02-28 20:33:51 +01:00
SnapperRy
d7299f9bde DB/Quest: fix chaining for quests Spawn of the Twisted Glade and Seeds of the Blacksouled Keepers.
Both quests require both pre-quests to be rewarded.
(cherry picked from commit a8142b3678)
2017-02-28 20:32:54 +01:00
SnapperRy
9884e762a0 DB/Quest: improvements to Report to Anselm:
- Add missing texts and re-number the group ids.
- Do not allow players to attack the creatures spawned in the end event.
- A Score to Settle requires completion of this quest.
(cherry picked from commit c1129af75b)
2017-02-28 20:31:39 +01:00
Treeston
9b4ad0022b Map/Instances: Greatly simplify PermBindAllPlayers logic. (#17940)
(cherry picked from commit cf628880d5)
2017-02-28 20:25:20 +01:00
SnapperRy
5c28f11c75 DB/Loot: fix drop chance for three quest items.
Felhound Brain, Nether Wing and Doomwarder Blood should always drop.
(cherry picked from commit cd6866c155)
2017-02-28 19:45:50 +01:00
SnapperRy
3e6f3aeaea DB/SAI: add script for creature Megalith.
(cherry picked from commit 32bc901a25)
2017-02-28 19:44:42 +01:00
SnapperRy
eeea58197c DB/SAI: fix event for quest Street "Cred".
(cherry picked from commit d7e97dc0a3)
2017-02-28 19:41:53 +01:00
Shauren
d4d8366131 Proper typo fix, it was too early in the morning 2017-02-28 10:58:35 +01:00
Shauren
5b4820cc0f Typo/build fix 2017-02-28 08:46:11 +01:00
Duarte Duarte
92420ba5ba Update issue_template.md
Attempt to make the issue template clearer. Let's see if it helps...
2017-02-27 23:52:28 +00:00
SnapperRy
46363942c1 DB/Loot: fix drop chance for two quest items.
Fenclaw Hide and Mature Bone Sifter Carcass should always drop.
(cherry picked from commit 79d51e7dd6)
2017-02-27 22:01:14 +01:00
SnapperRy
d70e852731 DB/Quest: remove wrong spell cast for quest The Dead Rise!
(cherry picked from commit 22133804a1)
2017-02-27 22:00:02 +01:00
SnapperRy
9da35aa3bd Core/Achievement: do not consider overkill damage for ACHIEVEMENT_CRITERIA_TYPE_DAMAGE_DONE.
(cherry picked from commit 4eb799560c)

Fix wrong copy-paste from last commit.

Sorry.
(cherry picked from commit c41b4000f9)
2017-02-27 21:59:02 +01:00
tkrokli
766433f504 DB/Quest: fix quest credit target type for Krolmir, Hammer of Storms
By Pitcrawler/Treeston, closes #17930

(cherry picked from commit 96a74aa8d7)
2017-02-27 21:55:15 +01:00
Shauren
c7cd51e8f5 Core/Movement: New names for a few spline flags 2017-02-27 19:30:44 +01:00
SnapperRy
87b6b9c27f Core/Creature: enable pet bar for TempSummons with category SUMMON_CATEGORY_PET.
Thanks @ariel- for helping with the research (although I'm two months late).
(cherry picked from commit 025002b907)
2017-02-26 21:34:05 +01:00
Dr-J
792e414b61 DB/SAI: Teron Gorefiend I am ....
The timed action lists for this script now need event flags so they run while charmed and so that Karsius actually gets summoned.
(cherry picked from commit 79578eab40)

Rename  2016_09_14_03_world.sql to 2016_09_14_03_world.sql
(cherry picked from commit 6913286cb9)
2017-02-26 21:33:52 +01:00
SnapperRy
1b288ebbdd Core/SmartAI: do not target player's group for SMART_ACTION_CALL_AREAEXPLOREDOREVENTHAPPENS.
SMART_TARGET_INVOKER_PARTY or SMART_ACTION_CALL_GROUPEVENTHAPPENS should instead be used to achieve this functionality.

(cherry picked from commit 6586885bca)
2017-02-26 21:31:16 +01:00
SnapperRy
cedd5dcfe5 DB/Quest: improve end event for A Daughter's Love.
(cherry picked from commit 08d88238a6)
2017-02-26 21:30:53 +01:00
SnapperRy
5360874c08 DB/Quest: end event for For Love Eternal.
Texts are already in DB.
(cherry picked from commit e166bb787b)
2017-02-26 21:29:53 +01:00
joschiwald
fa836c3160 Fixed characters_database.sql 2017-02-26 21:19:30 +01:00