Commit Graph

22621 Commits

Author SHA1 Message Date
Shauren
d9418ae00a Core/Misc: Fix a few coverity issues
CID 1360566
CID 1360567
CID 1361723
2017-01-25 17:40:08 +01:00
Shauren
c36f831ab7 Core/Packets: Changed ByteBuffer write exceptions into asserts (reading is unaffected as data comes from untrusted source - client) 2017-01-24 00:08:12 +01:00
Shauren
7b43adc436 Tools/Extractors: Use boost::filesystem for path manipulations
Fixes coverity issue CID 1324654
2017-01-23 18:42:29 +01:00
Shauren
adbe8daf8a Core/Misc: Updated ResponseCodes enum
Closes #18897
2017-01-22 14:47:14 +01:00
zamalaev
24211725aa Core/Misc: Updated BattlegroundTypeId enum again
Closes #18775
2017-01-22 14:17:14 +01:00
joschiwald
23b9e3d624 Core/Misc: Updated BattlegroundTypeId enum 2017-01-22 13:54:55 +01:00
Krudor
08eaaad8b9 Core/Criteria: Implement new criteria tree operator for Legion (#18912) 2017-01-22 11:35:46 +01:00
joschiwald
d3ee5a2d32 Core/Players: Fixed accidentally deleting Talents
Note: If you want to delete deprecated Talents from DB, enable the CharacterDatabaseCleaner
2017-01-22 02:20:12 +01:00
Shauren
784b70d5f4 Core/Proto: Generate new protobuf files
CID 1354572 to 1354592, 1354597
2017-01-19 18:17:25 +01:00
joschiwald
eccbbe304c Core/Spells: SPELL_AURA_218 does no longer haste range attacks 2017-01-19 00:46:56 +01:00
Shauren
3fd51db845 Tools/Extractors: Intruduce safe casc handles and fix all casc related memory leaks
CID 1254545
CID 1254555
CID 1254588
CID 1343649
2017-01-18 17:20:16 +01:00
joschiwald
9eda3d8542 Core/Spells: Fixed SetSpellModifier packet 2017-01-18 00:07:10 +01:00
Shauren
2add03ab99 Build fix 2017-01-17 23:54:40 +01:00
Shauren
6767bbc95f Fix static analysis issues
CID 1291964
CID 1292775
2017-01-17 20:14:44 +01:00
joschiwald
bc0d82a81e Core/DBLayer: Fixed copy paste mistake in 8e2634b2b4 2017-01-16 15:09:14 +01:00
Shauren
e8273b7b37 Removed debug leftovers 2017-01-15 15:11:49 +01:00
Shauren
0314abc26a Build fix 2017-01-15 12:07:11 +01:00
Shauren
f11e6c8247 Core: Updated to 7.1.5.23360 2017-01-14 22:37:13 +01:00
Aokromes
820c69ed8c Core/Scripts: update npc_eagle_spirit
By Malcrom
2017-01-14 15:09:09 +01:00
Aokromes
b53513ec11 Core/Scripts: update to sharpbeak
By Malcrom
2017-01-14 15:06:14 +01:00
Aokromes
433162875d Core/Movement: Update MoveSmoothPath for flying creatures
By Malcrom
2017-01-14 15:03:47 +01:00
Shauren
8e2634b2b4 Core/DBLayer: Convert async queries to new query callbacks and remove old callback handling 2017-01-13 21:38:03 +01:00
joschiwald
0f432edc4b Fixed build
Closes #18816
2017-01-13 18:54:15 +01:00
Aokromes
e3986d4a8a Script/Quest: Update Sharpbeak
By Malcrom
2017-01-13 04:51:37 +01:00
Shauren
bf00ae90b6 Core/Spells: Fixed all cases of spells that crash the client when pressing ESC after being cast
(cherry picked from commit f765e8eb73)
2017-01-13 01:01:09 +01:00
treeston
6c6f86d34c Instances/DrakTharonKeep: Fix Novos the Summoner. Fixes #17331.
(cherry picked from commit 813e33b927)
2017-01-13 00:56:41 +01:00
ariel-
9371c5c7d1 Core/Script: moved SAI to cpp for The Etymidian, closes #17053 (#17330)
(cherry picked from commit f03dc79959)

Rename 9999_99_99_99_world.sql to 2016_06_13_04_world.sql
(cherry picked from commit 90ba7fe938)
2017-01-13 00:56:29 +01:00
Aokromes
b52c1b35a5 Scripts/UtgardePinacle: Adjust King Ymiron boundaries
(cherry picked from commit cc521d49dc)
2017-01-13 00:44:14 +01:00
SnapperRy
2e5550758c Core/Movement: interrupt a creature's current cast when fleeing for assistance, and (if spell is not castable while moving) when running random/fleeing movement generators. (#17271)
Also make sure the creature is alive before updating.

Fixes #12823.
(cherry picked from commit 2db9269ec1)

DB/Creature: World Trigger (Not Immune NPC) InhabitType update

Closes #17332 by Malcrom
(cherry picked from commit 78d08834c0)

DB/Item: Fix text in Rune-Inscribed Parchment

Closes #17329 by tkrokli
(cherry picked from commit 8879545f21)

DB/Quest: improve chaining for "The Ashenvale Hunt" quests

Closes #17323 by SnapperRy
(cherry picked from commit d034eedb81)

DB/trinity_string: wrong string about character customization + minor fix

Closes #17306 by lyn1337
(cherry picked from commit 0951e559eb)

DB/Quest: fix some completion/offer reward quest texts

Closes #17336 by SnapperRy
(cherry picked from commit e9025036b9)

DB/Quest: add queststarters for "Regthar Deathgate"

Closes #17337 by SnapperRy
(cherry picked from commit 0b8921a0ef)

DB/Quest: fix chaining for "The Real Threat"

Closes #17338 by SnapperRy
(cherry picked from commit c9cb86d6c5)

DB/Quest: fix repeatableness (or lack of) for some quests

Closes #17339 by SnapperRy
(cherry picked from commit b9f2e2a81b)

DB/Quest: improvements for "Fool's Stout"

Closes #17340 by SnapperRy
(cherry picked from commit 4ec753dc50)
2017-01-13 00:07:43 +01:00
Snapper
f8ca5fd40e Core/Quest: send SMSG_QUESTGIVER_STATUS_MULTIPLE after a quest is rewarded.
This updates the status of nearby questgivers and prevents them from being stuck in a state that's no longer valid (for example, stuck with yellow question mark until area update).

(cherry picked from commit 114f4c9715)
2017-01-12 23:52:56 +01:00
Keader
b8757aa8e4 Core/Scripts Fixed Anubarak issues related with Leeching Swarm spell
(cherry picked from commit 3c35ce06af)
2017-01-12 23:40:24 +01:00
tkrokli
34d310aff8 Core/Scripts: remove hardcoded text from npc_sayge
- remove hardcoded (and wrong) text from the script
- copy valid text from broadcast_text to gossip_menu_option
- gossip_menu / npc_text is already correct in TDB 335.61
- sort + clean up core script enum list and add new entries
- keep gossip handling unchanged in the script (low prio)

(cherry picked from commit 582af02509)

Core/Scripts/DB: move npc_gregan_brewspewer to DB

- Remove npc_gregan_brewspewer, thereby removing hardcoded text
`#define GOSSIP_HELLO "Buy somethin', will ya?"`
- Move all gossip handling to DB (gossip texts already exist in TDB)
(cherry picked from commit 3acf6f36d1)

Core/Scripts: npc_grandmother gossip text moved to DB

Removing one more hardcoded text line from core scripts.
Also adding correct gossip to the npc_grandmother script.

Gossip changes in this script:
- remove hardcoded text from core script
- use existing npc_text IDs in gossip enum
- add missing text rows to gossip_menu_option
- use values from gossip_menu_option in enum
- replace spawn coordinates 0.0f with GetPosition()
(cherry picked from commit c214f987d7)

Core/Scripts: remove hardcoded text from npc_locksmith

- remove hardcoded text from script
- move the gossip handling to DB SQL
- move the script conditions to DB SQL
- use correct gossip from broadcast_text
- remove options not existing in broadcast_text
- add Key to Searing Gorge option (related spell)
- add The Eye of Haramad option (related spell)
(cherry picked from commit e6ee6e2ae8)
2017-01-12 23:37:37 +01:00
Snapper
36a896e28a Core/SmartAI: delay SMART_ACTION_FLEE_FOR_ASSIST if creature is rooted/stunned.
Prevents creatures from teleporting around when fleeing while stunned/rooted.

(cherry picked from commit aaf10dccb0)
2017-01-12 23:17:37 +01:00
tkrokli
4e00321970 Core/Scripts: boss_majordomo hardcoded text
2 more text lines removed in the ongoing series:
"Remove hardcoded text from core scripts".

Core script for boss Majordomo Executus:
- add missing gossip_menu_option entries
- link the options via the table gossip_menu
- remove hardcoded text from the script
- minor enum line order sorting cleanup
- replace OnGossipSelect() with sGossipSelect()

The scripted events are unchanged.
If the script is inaccurate, make a new PR.
(cherry picked from commit b6d43623a2)
2017-01-12 23:16:41 +01:00
joschiwald
2b5d7eef3a Core/SpellScripts: Added helper method to validate spells 2017-01-12 23:03:08 +01:00
Shauren
f8fe750b5e build fix 2017-01-12 20:00:02 +01:00
Shauren
73e61fa652 Core/DBLayer: Refine new query callback for chaining 2017-01-12 19:40:33 +01:00
tkrokli
52d0ec3ccb Core/Scripts: move npc_mountaineer_pebblebitty to DB
- move gossip text to DB and add quest condition
- remove core script npc_mountaineer_pebblebitty,
- thereby removing the file zone_loch_modan.cpp
- because the original core script dialog is incorrect

This version of the dialog can be verified from the following web pages:
- http://wow.gamepedia.com/Key_to_Searing_Gorge_quest_chain
- http://www.wowhead.com/npc=3836/mountaineer-pebblebitty#comments:id=332234

(cherry picked from commit 25881de7d3)
2017-01-12 03:40:16 +01:00
joschiwald
71ffdccb5a Core/Movement: enable item use and spell cast when dismounting
Remove error message and allow spell cast or item use from
mounted state on ground, especially when sitting on
a landed flying mount. Current behavior is that the player
will get the error message "You can't do that while moving"
when trying to cast a spell or pick up an item
while sitting on a flying mount after having landed.

By joschiwald, closes #6236

(cherry picked from commit 19aac66bc2)
2017-01-12 03:36:32 +01:00
treeston
e2710bc232 Scripts/Instances: Fix a bug that would cause the Hodir encounter to never properly begin. Tagging issue #17302.
(cherry picked from commit e5382ee215)
2017-01-12 03:19:38 +01:00
treeston
95902126a3 Scripts/Outland: Fix a potential crash. Closes #17308.
(cherry picked from commit 96c05dbec0)
2017-01-12 03:18:07 +01:00
jackpoz
98d16d82be Core/Player: Fix duel edge case crash
Fix a crash that could be triggered if an aura removed after duel finished would have caused damage to one of the players.

(cherry picked from commit 7ff0f3c65f)
2017-01-12 03:13:55 +01:00
Aokromes
85b72b7b2b someone lives on the past :P 2017-01-12 03:08:48 +01:00
Aokromes
a28768a9ad Missing part of c76226c 2017-01-12 03:07:19 +01:00
Aokromes
c76226cc41 Script/Quest: Script Quest 24125 Rite of the Winds
By Malcrom, closes #18262
2017-01-12 03:06:14 +01:00
Aokromes
2c1394df84 warning fix 2017-01-12 02:53:09 +01:00
Aokromes
5317a81395 Core/Scripts: Sharpbeak update
By Malcrom
2017-01-12 02:50:07 +01:00
treeston
5e99388981 Scripts/Instances: More #16346 follow-ups. Fixed this time: Halls of Reflection, Ignis the Furnace Master, Mimiron and Rend Blackhand.
(cherry picked from commit 27a3eaab33)

Scripts/MoltenCore: Fix Ragnaros (#16346 follow-up).
(cherry picked from commit 83e5df5638)

Scripts/BlackrockMountain: Nefarian. (#16346 f-u)
(cherry picked from commit 650d7ab596)
2017-01-12 00:28:10 +01:00
jackpoz
954b3c9617 Core/VMaps: Fix some vmap height edge cases
Fix Map::GetWaterOrGroundLevel() checking dynamic object only in phase 1 instead of current Unit phase.
Improve DynamicMapTree::getHeight() dynamic object check by casting the ray at +0.5f from the passed Z coordinate, this value will be tuned to improve even more the results.

(cherry picked from commit 1347d7cf7a)
2017-01-12 00:13:55 +01:00
treeston
1a7b4fbe4d AI/SmartScripts: Add action_param3 "disablePathfinding" to SMART_ACTION_MOVE_TO_POS (69).
(cherry picked from commit 123e45c119)
2017-01-12 00:07:29 +01:00