Commit Graph

26880 Commits

Author SHA1 Message Date
Shauren
d56d92fbe7 Core/Units: Allow mind controlling non-controllable vehicles (for example players that become vehicle during boss encounters or creatures that only are vehicles to show non standard power type)
Closes #24562

(cherry picked from commit 1fecbc6892)
2022-01-02 16:17:18 +01:00
NoName
0aa98a5bc9 Core/Maps: fix respawn times for manual respawns (#24571)
by joshwhedon

(cherry picked from commit 5bbab32793)
2022-01-02 13:56:18 +01:00
ccrs
b9bb07de03 Core/Movement: modify MovementInform trigger condition & checks in ChaseMovementGenerator
(cherry picked from commit ac12bd1391)
2022-01-02 00:41:22 +01:00
ccrs
06334ab734 Core/Movement: de832b6 followup
lets keep that failsafe there, doesnt hurt

(cherry picked from commit 71ed2e5d5e)
2022-01-02 00:30:33 +01:00
ccrs
e6c0022a4d Core/Movement: modify MovementInform trigger condition & checks in FollowMovementGenerator
ref #24552

(cherry picked from commit de832b6980)
2022-01-02 00:30:33 +01:00
Shauren
6413466693 Core/Spells: Relaxed aura exclusivity check to allow casting spells that have other, non-aura effects even if aura will not be applied
Closes #24553

(cherry picked from commit 829cf38c67)
2022-01-02 00:30:31 +01:00
ccrs
875da43780 Core/Movement: 0e2342c followup
(cherry picked from commit b8422e667b)
2022-01-02 00:22:57 +01:00
Ovahlord
b8e1de0f92 Core/Objects: use the static vmap check in MovePositionToFirstCollision for all path results to avoid falling below wmo surfaces when the mmap path returns unreliable data
(cherry picked from commit a548d9f9b0)
2022-01-01 23:49:31 +01:00
Shauren
6d94bc2f4b Core/Spells: Fixed refreshing stat buff auras that have been improved by talents
Closes #24527

(cherry picked from commit 978745220a)
2022-01-01 23:45:39 +01:00
Ovah
26e7da1622 Core/Objects: further improvements for MovePositionToFirstCollision (#24523)
* Core/Objects: further improvements for MovePositionToFirstCollision

* the PathGenerator will now normalize incomplete destinations as well
* normalize destination positions before launching detour raycasts to get better direction data
* exclude unwanted pathfinding results from further use to avoid unintended behaivior

* Core/PathFinding: Split PATHFIND_FARFROMPOLY into PATHFIND_FARFROMPOLY_START and PATHFIND_FARFROMPOLY_END for start and end position

Handle PATHFIND_FARFROMPOLY_END as valid in MovePositionToFirstCollision

Co-authored-by: jackpoz <giacomopoz@gmail.com>
(cherry picked from commit 6485422c61)
2022-01-01 23:30:48 +01:00
offl
f32f812e29 DB/Quest: Becoming a Spellfire Tailor
Closes #24522

(cherry picked from commit 9638f0ad0b)
2022-01-01 23:22:09 +01:00
Ovahlord
b8805f4389 Core/Objects: optimize and improve MovePositionToFirstCollision results
* removed redundant static LOS checks as they are covered by the mmap raycast prior to the check
* removed unnecessary VMap height lookups to determine rapid falloffs as they are covered by the mmap raycast as well

(cherry picked from commit cf849df50a)
2022-01-01 23:19:31 +01:00
ForesterDev
9d38eeec7e Core/Player: add helper methods for PLAYER_FLAGS_DEVELOPER (#24511)
* Core/Player: add helper methods for PLAYER_FLAGS_DEVELOPER. Update .dev command to new command model

* Rename _player -> player

(cherry picked from commit 8128bb97db)
2022-01-01 23:18:04 +01:00
jackpoz
7d632d5711 Core/PathFinding: Fix buffer overflow
(cherry picked from commit dc7856644f)
2022-01-01 22:59:49 +01:00
NoName
6c6b8cb1c6 Scripts/IcecrownCitadel: Adding IsAlive check to avoid possible crash in Event (#24514)
(cherry picked from commit 22aaf32a79)
2022-01-01 22:59:24 +01:00
Shauren
679e9910e0 Core/Auras: Prevent getting negative scale with auras
Closes #24040

(cherry picked from commit 50576fa1f5)
2022-01-01 22:49:58 +01:00
Shauren
c9443f190a Core/Spells Fixed scroll stacking check when not targeting self
* Reuse code that removes non-stackable auras at apply to check before casting the spell to keep reagents/cast item

(cherry picked from commit 43d9ffd1bc)
2022-01-01 22:27:05 +01:00
FAQ
88afe180b4 Core/Spells: Scrolls should not be consumed, when they fail to apply.
(cherry picked from commit 8d87c834e7)
2022-01-01 21:55:29 +01:00
Killyana
6300b096ac DB/Pet: Lil' K.T
Ref #1364

(cherry picked from commit ee5eace3c6)
2022-01-01 21:49:09 +01:00
Ovahlord
f4f56c105f Core/Vehicles: update the power display of vehicles before being added to world to avoid building unnecessary update_object packets right after spawning them
(cherry picked from commit 1610337e67)
2022-01-01 21:47:30 +01:00
HelloKitty
a20526077d Core/DataStores: Use ResSicknessSpellID from ChrRaces instead of hardcoding it (#24504)
(cherry picked from commit f1ad04b31b)
2022-01-01 21:45:52 +01:00
Killyana
567b26e0c7 DB/Pet: Toxic Wasteling
Closes #12773

(cherry picked from commit 3f5e0927c3)
2022-01-01 21:42:51 +01:00
NoName
5417438731 Core/Spells: Crystallize should not use DIMINISHING (#24502)
and also correcting spelling in script

by Rushor and wotlk-enthusiast

(cherry picked from commit 45993428f5)
2022-01-01 21:38:13 +01:00
Rushor
db825c3221 Game/AI: Implement new targettype SMART_TARGET_CLOSEST_UNSPAWNED_GAMEOBJECT (#24494)
* Game/AI: Implement new targettype SMART_TARGET_CLOSEST_UNSPAWNED_GAMEOBJECT which allows to search for closest unspawned gameobjects

* updates: https://github.com/TrinityCore/TrinityCore/issues/24067

* Game/AI: Implement new targettype SMART_TARGET_CLOSEST_UNSPAWNED_GAMEOBJECT which allows to search for closest unspawned gameobjects

(cherry picked from commit 2d948d3366)
2022-01-01 21:33:34 +01:00
Rushor
ecd6bce5d2 Game/AI: Enable check for SMART_TARGET_GAMEOBJECT_RANGE (#24493)
* Thanks to joshwhedon
* Updates: https://github.com/TrinityCore/TrinityCore/issues/24439

(cherry picked from commit a41bb4f77b)
2022-01-01 21:33:27 +01:00
Eridium
88b898b92c Core/GameObject: Remove linked traps when the main GameObject is remo… (#24480)
* Core/GameObject: Remove linked traps when the main GameObject is removed from from the world

* Indentation

(cherry picked from commit 7e9bc9599b)
2022-01-01 20:30:54 +01:00
Gildor
5ce8c26914 Scripts/OnyxiasLair: Fix Onyxia Eruption spell (#24472)
(cherry picked from commit e4476fab6e)
2022-01-01 20:30:06 +01:00
Ovah
a6a6a15973 Core/AI: Implemented OnSpellCastInterrupt and OnSuccessfulSpellCast hooks
Ported from: 020825902c and 1aa42e97a8

(cherry picked from commit f1e4ee21f8)
2022-01-01 20:17:45 +01:00
Keader
c11288af78 Making travis happy
(cherry picked from commit ee218a5642)
2022-01-01 20:16:05 +01:00
Keader
a21ad2079a Scripts/Black Temple: Fixed Reliquary of Souls after combat rewrite changes.
Closes #23879
* Fixed combat start/evade issue
* Fixed visual issue in Soul Release spell
* Fixed some timers issue
* Fixed some codestyle issues

PS: Please, stop break my black temple babys.
(cherry picked from commit d8e726de58)
2022-01-01 20:15:51 +01:00
ForesterDev
6bddc8ff5e Core/Database: fix wrong password logging (#24487)
(cherry picked from commit 48c700347c)
2022-01-01 20:13:25 +01:00
jackpoz
d690648bce Scripts/BWL: Fix crash in Razorgore encounter
(cherry picked from commit 7b8b02c32e)
2022-01-01 20:13:04 +01:00
Rushor
864ce5a11c Game/SmartScripts: Reset counter in SAI only on Initialize. (#24489)
* Game/SmartScripts: Reset counter in SAI only on Initialize.

* Game/SmartScripts: Reset counter in SAI only on Initialize.

(cherry picked from commit 4f52f7d7c9)
2022-01-01 20:12:55 +01:00
jackpoz
e71352db6f Core/Spells: Fix assertion triggered
(cherry picked from commit 740afc7135)
2022-01-01 20:11:02 +01:00
Shauren
3f2f715f35 Core/Misc: Improve assert message with more detail
(cherry picked from commit 9407f9bdfa)
2022-01-01 20:10:45 +01:00
Killyana
ad2e5aabc4 Spell: Move "Dark Conclave Ritualist Channel" outside Ulduar spells
(cherry picked from commit 9e58573272)
2022-01-01 20:04:42 +01:00
Killyana
b4dd7c642b Spell: Fix "Dark Conclave Ritualist Channel" range and cast
(cherry picked from commit 64878e19fb)
2022-01-01 20:02:50 +01:00
skipperheartbeat
00f6631cd2 Boss/Script: Vazruden_Fix (#24197)
* Add files via upload

* Update boss_vazruden_the_herald.cpp

* Update boss_vazruden_the_herald.cpp

* Update boss_vazruden_the_herald.cpp

* Update boss_vazruden_the_herald.cpp

* Update boss_vazruden_the_herald.cpp

* Update boss_vazruden_the_herald.cpp

* Update boss_vazruden_the_herald.cpp

* Update boss_vazruden_the_herald.cpp

* Update boss_vazruden_the_herald.cpp

* Update src/server/scripts/Outland/HellfireCitadel/HellfireRamparts/boss_vazruden_the_herald.cpp

Co-Authored-By: Trond B. Krokli <38162891+illfated@users.noreply.github.com>

* Update src/server/scripts/Outland/HellfireCitadel/HellfireRamparts/boss_vazruden_the_herald.cpp

Co-Authored-By: Trond B. Krokli <38162891+illfated@users.noreply.github.com>

* Update src/server/scripts/Outland/HellfireCitadel/HellfireRamparts/boss_vazruden_the_herald.cpp

Co-Authored-By: Trond B. Krokli <38162891+illfated@users.noreply.github.com>

* Update src/server/scripts/Outland/HellfireCitadel/HellfireRamparts/boss_vazruden_the_herald.cpp

Co-Authored-By: Trond B. Krokli <38162891+illfated@users.noreply.github.com>

* Update src/server/scripts/Outland/HellfireCitadel/HellfireRamparts/boss_vazruden_the_herald.cpp

Co-Authored-By: Trond B. Krokli <38162891+illfated@users.noreply.github.com>

* Update src/server/scripts/Outland/HellfireCitadel/HellfireRamparts/boss_vazruden_the_herald.cpp

Co-Authored-By: Trond B. Krokli <38162891+illfated@users.noreply.github.com>

* Update src/server/scripts/Outland/HellfireCitadel/HellfireRamparts/boss_vazruden_the_herald.cpp

Co-Authored-By: Trond B. Krokli <38162891+illfated@users.noreply.github.com>

* Update src/server/scripts/Outland/HellfireCitadel/HellfireRamparts/boss_vazruden_the_herald.cpp

Co-Authored-By: offl <suffle.o@gmail.com>

* Update src/server/scripts/Outland/HellfireCitadel/HellfireRamparts/boss_vazruden_the_herald.cpp

Co-Authored-By: Trond B. Krokli <38162891+illfated@users.noreply.github.com>

* Update boss_vazruden_the_herald.cpp

* Update boss_vazruden_the_herald.cpp

* Update boss_vazruden_the_herald.cpp

Co-authored-by: Aokromes <Aokromes@users.noreply.github.com>
Co-authored-by: Trond B. Krokli <38162891+illfated@users.noreply.github.com>
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
Co-authored-by: offl <suffle.o@gmail.com>
(cherry picked from commit 8ac8374429)
2022-01-01 20:01:46 +01:00
Gildor
aa38443cf3 Core/Spells: Improve check for non damage/heal spells in Spell::TargetInfo::DoDamageAndTriggers (#24467)
* this prevent cases like full absorb damage that override proper hitMask

(cherry picked from commit 247151b470)
2022-01-01 20:01:16 +01:00
Keader
97ed31fe76 Core/Spells: Fixed Ice Block / Divine Shield cast in Cyclone (#24465)
(cherry picked from commit c41ae89069)
2022-01-01 20:00:53 +01:00
zartech22
c57c26d7fb Add realm ID for actions based ip logging (#24453)
* Update SQL queries to insert realm id

* Insert the realm id when logging actions based on IP

* Adding the SQL update file

* Update 9999_99_99_99_auth.sql

* Update auth structure

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
(cherry picked from commit 56f20d69a6)
2022-01-01 19:38:40 +01:00
Gildor
e67e0ff9fb Scripts/Naxxramas: Fix Heigan Eruption spell (#24470)
(cherry picked from commit 6c7c2c6cd2)
2022-01-01 19:17:54 +01:00
Ovah
a3d28efcfa Core/Movement: various improvements for creature knockbacks
* creature knockbacks will no longer generate a full path but instead only use a destination point to reflect sniff data
* calculate the destination by using a mmap raycast instead of using a mmap path which had the chance of creating weird movements when GetNearPosition failed to get a proper collision point (knocking arround a tree for example or just somewhere it should not go at all)

(cherry picked from commit cfd63c350f)
2022-01-01 19:17:05 +01:00
Alan Deutscher
68e1dc8adb Core/Players: Improve trade exchange calculations (#24435)
* Add some comments to Player::CanStoreItems to help me wrap my head around how the method works.

* Experimental fix for incoming trade-stack problem.

* Only add to stacks that aren't already full.

* Use remaining_count instead of static 1.

* Remove debug logging from exploration.

* More uses of remaining_count for consistency.

* Correct space count check

* Correct overflow problem.

* Remove redundant check, handled in existing for statement.

* Store Item pointers in order to be able to merge in multiple incoming stacks.

* Build fix - was continually working locally, but failing in CI.

* Break build in order to keep PR focused on Player.cpp changes.

* Adjust phrasing of how arrays are initialized.

* Fix phrasing of comments to avoid sounding like a ToDo item

* In the spirit of b649273d5f, rephrase an old comment to be a statement rather than a question.

(cherry picked from commit e11a13c755)
2022-01-01 16:29:06 +01:00
Keader
6957dd9bd6 Scripts/Ulduar: Little improvements in Auriaya
* Removed DespawnAtEvade
* Fix Feral Defender Damage

(cherry picked from commit 77dd751499)
2022-01-01 15:54:52 +01:00
Keader
0484c0a337 Scripts/Trial of Crusader: Fixed issue with Snobold Vassal and some achiev criteria resets
* Fixed snobold behavior when gormok dies
* Fixed UPPER_BACK_PAIN Archiev reset
* Fixed THREE_SIXTY_PAIN_SPIKE Archiev reset

(cherry picked from commit 78dff46bf2)
2022-01-01 15:51:21 +01:00
Gildor
a477e85ae3 Scripts/Quest: The Exorcism of Colonel Jules (#24459)
* Remove Anchorite Barada gossip when event start

(cherry picked from commit 8a5b02be0a)
2022-01-01 15:51:07 +01:00
ForesterDev
e73735fa61 Core/PacketIO: updated SMSG_DURABILITY_DAMAGE_DEATH (#24442)
- use RATE_DURABILITY_LOSS_ON_DEATH for death from falling
- add note, that RATE_DURABILITY_LOSS_ON_DEATH doesn't change log message

(cherry picked from commit a1831e0c1e)

Co-authored-by: MitchesD <majklprofik@seznam.cz>
(cherry picked from commit e1a8ebc064)
2022-01-01 15:25:11 +01:00
Gildor
60e66621da Core/Gameobjects: Improve stealth detection (#24417)
* Core/Gameobjects: Improve stealth detection

* fix warning: private field 'i_funit' is not used

* Code cleanup

* add comment

Co-authored-by: jackpoz <giacomopoz@gmail.com>
(cherry picked from commit 862097a633)
2022-01-01 15:05:01 +01:00
Sven
2aa5f4e1b2 Improvements to Pyroguard Emberseer (UBRS) script (#24405)
* UBRS: Improve Pyroguard Emberseer script

* Remove whitespaces

* More whitespaces removed

* Addressing change requests
Removed cast from constructor
Removing unused member field

* That should be the last white spaces

* Forgot to remove the declaration

* Update boss_pyroguard_emberseer.cpp

* Add break to For loop

* War on white spaces

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
(cherry picked from commit c3037c3563)
2022-01-01 14:52:43 +01:00