Mirror/TrinityCore
1
0
Fork 0
mirror of https://github.com/TrinityCore/TrinityCore.git synced 2026-01-16 15:40:45 +01:00
Code Issues Packages Projects Releases Wiki Activity
36,167 Commits 4 Branches 146 Tags
dc2fed13c8a98123ff20316428e41eada36c81e9
Commit Graph

36167 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
jackpoz
dc2fed13c8 Shared/Metric: Fix a rare memory leak 
Fix a memory leak in Metric happening only when enabling/disabling Metric from configs at runtime, leaking the metric added between last SendBatch() call and the ScheduleSend() call in the same function. The only way to reproduce this is to actually freeze the thread calling SendBatch(), disable metric, reload config, unfreeze the thread.

(cherry picked from commit 0d1ff7446d)
 2021-12-02 00:39:20 +01:00
jackpoz
98863659bb Scripts/Guards: Fix infinite loop in npc_air_force_bots 
Fix infinite loop in npc_air_force_bots happening when aura 38067 was removed, triggering MoveInLineOfSight() that would add back the aura. Only 1 aura add/remove for guard for player is allowed now.

(cherry picked from commit 844e7ee926)
 2021-12-02 00:39:20 +01:00
jackpoz
519e3c9ab7 Core/Commands: Fix .cheat god command letting you die 
Fix .cheat god command still letting you die with Area Aura like Slime near Thaddius, broken since 777b287dff

(cherry picked from commit f26f716714)
 2021-12-02 00:39:20 +01:00
jackpoz
dd825c5614 Core/Maps: Fix crash caused by setActive(false) called after DespawnOrUnsummon() 
Fix crash caused by WorldObject::setActive(false) called after WorldObject::DespawnOrUnsummon() happening because the WorldObject would be set as not active but then Map::RemoveFromActiveHelper() would not be called because of not being in world anymore.
Whenever setActive() gets desync'd with what Map actually contains a rare crash would happen since Map only reads a few values of the active WorldObject, making it hard to reproduce. If this happens again some ASSERT calls should be added (or a check in Map::RemoveFromMap() could be added about if the WorldObject is in Map::m_activeNonPlayers container).

(cherry picked from commit 1c833f28e4)
 2021-12-02 00:39:20 +01:00
Killyana
36e009baf2 Core: Restore reset in EscortAI::InitializeAI (#23197) 
Closes  #23008

(cherry picked from commit 56b65329e5)
 2021-12-02 00:39:20 +01:00
Jozef Dúc
b717603a9b Core/Object: Range check (#23179) 
* Should solve #23062. All credits to @xvwyh

* Remove unused variables

* Remove unused variable

* Cast int32 to uint32

* Remove G3D headers from core header file

* Change door distance

* Update GameObject.cpp

Add newline

* Update GameObject.h

Indentation

(cherry picked from commit 32e1de39a2)
 2021-12-02 00:39:20 +01:00
jackpoz
73c6c13ace Core/GameObject: Code cleanup 
(cherry picked from commit 16a154c4e8)
 2021-12-02 00:39:20 +01:00
Killyana
a18808212e Core/GameObject: Remove summoned gobs properly from the map without effecting other cases 
Ref 0e8e3828f4
Ref #23115

(cherry picked from commit 9db64666dc)
 2021-12-02 00:39:20 +01:00
ForesterDev
a2c0f6d321 Scripts/Commands: add some missing checks for .guild create command (#23201) 
* Core/Conditions: implement CONDITION_GAMEMASTER

* Scripts/Commands: add some missing checks for .guild create command

(cherry picked from commit ae8750716f)
 2021-12-02 00:39:20 +01:00
Keader
93a9ee9c12 Scripts/Trial of the Crusader: Fixed Resilience will Fix achievement 
Broken by 2362e9c794

(cherry picked from commit f163c2f96a)
 2021-12-02 00:39:20 +01:00
Killyana
62d3010e56 Core/GameObject: Delete summoned gobs and DestroyForNearbyPlayers gobs spawned with negative spawn time once the gob is deactivated 
(cherry picked from commit 0e8e3828f4)
(cherry picked from commit 65afe47580)
(cherry picked from commit 21667f97cb)
 2021-12-02 00:39:19 +01:00
Killyana
a290fe1c14 DB/Quest: Fix text and orientation target for the quest Cleansing Drak'Tharon 
(cherry picked from commit 1df7dacd9d)
 2021-12-02 00:39:16 +01:00
ZenoX92
e6424020a1 DB/Misc: The Edunes Event 
Closes #23194

(cherry picked from commit 8b85433f3c)
 2021-12-02 00:39:01 +01:00
Sorikoff
8f0afc81da Scripts/Scarlet Enclave: Unworthy Initiate (#23195) 
(cherry picked from commit 4468a538ff)
 2021-12-02 00:38:42 +01:00
Killyana
ae595df7ea DB/GameObject: Harbinger of the Second Trial 
Restore original data3:  Time in ms before the initial state is restored, and remove the manual despawn as it's called once the gob change state

(cherry picked from commit 90e0131676)
 2021-12-02 00:38:40 +01:00
Sorikoff
575bcc8c82 Scripts: Minor improvements to recently migrated scripts (#23189) 
Ref: 2cfaeb1400
(cherry picked from commit 90d4254a87)
 2021-12-02 00:37:00 +01:00
Keader
4b3e6b9998 Scripts/Spells: Fixed a console error inspell_dru_lifebloom 
Closes #23192

(cherry picked from commit 961bc9d829)
 2021-12-02 00:37:00 +01:00
Trond B. Krokli
001b9fb05c Core/conf: conf.dist typo & grammar corrections (#23190) 
- Typo and spelling corrections
- Grammar corrections, English grammar
- Minor adjustments in example code readability
- Capitalization adjustments to keep consistency
  with existing idioms, phrases and concepts

(cherry picked from commit f9b1e4a032)
 2021-12-02 00:37:00 +01:00
Naddley
67cac13e04 DB/Spawns: Added remaining spawns on Exiles Reach/NPE Alliance ship 
Closes #27340
Closes #27341
Closes #27342
Closes #27345
 2021-12-01 01:36:39 +01:00
jackpoz
5600316c9f Core/Calendar: Improve calendar timezone handling 
Improve calendar timezone handling by at least creating events with the correct time if both client and server are in the same timezone. There is currently no information received from the client about in which timezone it is.

(cherry picked from commit b33934f6ce)
 2021-12-01 00:46:05 +01:00
jackpoz
aeaca00d76 Buildsystem: Fix finding VS 2019 compiled boost libs 
(cherry picked from commit 3d3b7f438c)
 2021-12-01 00:28:13 +01:00
Killyana
bade67e74b DB: Respawn The Underbog 
(cherry picked from commit 5262d760ff)
 2021-11-30 23:28:41 +01:00
Aokromes
dad95d16b2 Core/SmartScripts: Implement SMART_ACTION_PLAY_CINEMATIC 
By Malcrom

(cherry picked from commit 63aa5d1e35)
 2021-11-30 23:10:57 +01:00
jackpoz
b02143118f Core/Database: Delete gameobject_addon data when deleting a GameObject from the database 
Close #23076

(cherry picked from commit f88a5b12bd)
 2021-11-30 23:05:27 +01:00
Killyana
5e845a48dd DB/Quest: Set the correct event for the quest The Grateful Dead (Human) 
(cherry picked from commit 616056b925)
 2021-11-30 23:02:13 +01:00
Killyana
3f25fe8a8a DB/Creature: Hand of Argus Swordsman <Hand of Argus> 
(cherry picked from commit 142d13b39e)
 2021-11-30 22:48:23 +01:00
Killyana
f98e82103f Spell/Script: Kill logs spam for spell_ioc_parachute_ic 
Closes #23163

(cherry picked from commit c318b3e16d)
 2021-11-30 22:41:16 +01:00
ccrs
171947fa62 Core/Movement: replace multiset::find with std::find in MotionMaster 
same reasoning as 11de6b5
Container's find uses the defined custom comparator

(cherry picked from commit 6e011c974d)
 2021-11-30 22:33:16 +01:00
ccrs
72301bf02f Core/Movement: implement and use new remove method in MotionMaster 
All erases within MotionMaster are now done by itr.
Previous impl used value erase which uses the custom comparator which does not identify elements uniquely --> wrong values were deleted

ref #23187#discussion_r275791179

(cherry picked from commit 11de6b5f86)
 2021-11-30 22:32:53 +01:00
Sorikoff
d72e809ecf Scripts/Spells: Migrate Some Scripted Spells to Scripts (#23185) 
* Migrate spells to scripts

* Simplify code

* I need to sleep

* Update chapter1.cpp

* Use actual damage

* No need in null check here

(cherry picked from commit 2cfaeb1400)
 2021-11-30 22:30:53 +01:00
Chaouki Dhib
c19a4db1c1 Core/Movement: Add time synchronisation (#18189) 
(cherry picked from commit 975f1e364a)
 2021-11-30 22:11:36 +01:00
Killyana
2f6f1c7089 DB/Creature: Flame Arrow 
(cherry picked from commit 9f32aaf454)
 2021-11-30 21:05:18 +01:00
Killyana
f12dbcdb8d DB/Creature: Add and fix some spawns in The Shattered Halls 
(cherry picked from commit 4d2e0c0bdb)
 2021-11-30 21:04:08 +01:00
Killyana
acf8270d16 DB/Creature: Nascent Fel Orc & Fel Orc Neophyte 
(cherry picked from commit bb3052f9b5)
 2021-11-30 21:02:44 +01:00
Killyana
3336f8ab38 DB/Creature: Orc Captive 
(cherry picked from commit e23de2c0b3)
 2021-11-30 21:01:30 +01:00
Killyana
b3c2a2f301 DB/Creature: Shattered Hand Savage 
(cherry picked from commit 2c429bca06)
 2021-11-30 21:00:16 +01:00
ForesterDev
edd911b14d Core/Social: Separated checks for friend and ignored limits (#23181) 
(cherry picked from commit 2a6eef76e2)
 2021-11-30 20:58:49 +01:00
Killyana
9b9452af75 DB/Creature: Drisella & Randy Whizzlesprocket 
(cherry picked from commit 504b71a1f9)
 2021-11-30 20:39:45 +01:00
Killyana
5d57128f82 DB/Creature: Felguard Annihilator 
(cherry picked from commit 12285b9780)
 2021-11-30 20:38:49 +01:00
Killyana
27e4db5fa2 DB/Creature: Creeping Ooze & Creeping Oozeling 
(cherry picked from commit d8f28960b1)
 2021-11-30 20:37:58 +01:00
Killyana
68bea6f784 DB/Creature: Garden Gas 
(cherry picked from commit 858dfa1233)
 2021-11-30 20:36:47 +01:00
Killyana
a3b2b2b011 DB/Creature: Blackwing Spell Marker 
(cherry picked from commit deea9f653a)
 2021-11-30 20:33:39 +01:00
Killyana
d73bfb496d DB/Creature: Garel Redrock & Gurky 
(cherry picked from commit 5fb5ca94f7)
 2021-11-30 20:32:10 +01:00
Killyana
b1e26fbefd DB/Creature: Add Naxxramas 25 difficulty spawns 
(cherry picked from commit 688c46ebc8)
 2021-11-30 20:10:17 +01:00
Shauren
21fefb3189 Core/GameObjects: Defined more GameObjectFlags and GameObjectDynamicLowFlags 2021-11-30 19:31:16 +01:00
Naddley
c4fedd10ab DB/Spawns: Added Private Coles initial ship spawn in Exiles Reach/NPE (Alliance) 
Closes #27339
 2021-11-29 18:43:51 +01:00
ModoX
1342d81943 DB/Misc: fix typo 2021-11-29 18:21:46 +01:00
Naddley
53429375c7 DB/Spawns: Add Captain Garricks ship spawns in Exiles Reach/NPE (Alliance) 
Closes #27338
 2021-11-29 18:15:54 +01:00
ModoX
f6cb13bb84 DB/Spawns: Spawned Al'dalil in Oribos 
Closes #27329
 2021-11-29 16:48:45 +01:00
Shauren
66225c27e4 COre/Misc: GCC warning fix 2021-11-29 12:11:24 +01:00