Commit Graph

33337 Commits

Author SHA1 Message Date
Treeston
e5836dcc1a Core/Unit: No code change, just updating a comment with insights gleaned from sniffs.
(cherry picked from commit f2f45765e4)
2020-08-20 00:19:23 +02:00
Treeston
e6be53d141 Core/WorldObject: Properly initialize position data for all types when initially creating them. Fixes some issues with PvP objectives not having the correct area ID set on initialization. Closes #20028.
(cherry picked from commit 28b3469e89)
2020-08-20 00:18:48 +02:00
Shauren
b630e9a485 Warning fix 2020-08-20 00:12:20 +02:00
Treeston
e51960ea45 Core/PlayerAI: Some adjustments:
- Add a 2 second delay before the AI begins using spells. This should provide opportunity for counterplay before that rogue activates cloak and goes on an unstoppable rampage among your healers. (Sorry, guys.)
- Stopped the AI from attacking invalid targets under some conditions. It should now properly leash back and follow the charmer if we try to select an invalid target.
- Stopped the AI from constantly re-creating the follow movement generator (and thus spamming movesplines).

(cherry picked from commit 331e463de8)
2020-08-20 00:11:18 +02:00
Treeston
2c92e09230 Scripts/Auchindoun: Last one, hopefully. Remove reliance on large grid searchers by integrating with instance script.
(cherry picked from commit d80d7c6685)
2020-08-20 00:08:04 +02:00
Treeston
6599dab1e1 Scripts/Auchindoun: Blackheart the Inciter fully fixed now. I had way too much fun with this one.
Two points of note:
1) Spawning 5 invisible triggers with 5 distinct factions which then MC one target each? Biggest. Hack. Ever. Best part? It's blizzlike.
2) For over ten years, I thought it was spelled "Auchinodoun". It's not. It's spelled "Auchindoun". TIL.

(cherry picked from commit 04dc47e7e2)
2020-08-19 23:50:31 +02:00
Treeston
8a1739d15e Scripts/Auchindoun: Replace the Blackheart the Inciter hack-filled script with a slightly less hack-filled script that actually mostly works. This should at least make the boss encounter possible to complete. No claims to correctness, of course.
(cherry picked from commit a38141fd6c)
2020-08-19 23:47:25 +02:00
Treeston
b1d2e4e906 Scripts/Spell: Port spell_generic.cpp to new script registration syntax wherever possible. No actual changes in functionality. (fb87ac8 follow-up)
(cherry picked from commit 49aa8a2e59)
2020-08-19 23:42:29 +02:00
Treeston
4f676221b8 Scripts/Item: Port spell_item.cpp scripts to new script registration syntax wherever possible. No actual changes in functionality. (fb87ac8 follow-up)
(cherry picked from commit 37f59f8850)
2020-08-19 21:38:47 +02:00
treeston
89006f621e Scripts/Item: Change Nitro -> Boosts <- to use the correct knockup effect for their backfire. Also, script that knockup effect to work properly ("usually" deploy a rescue parachute).
(cherry picked from commit 02b1d8bb48)
2020-08-19 20:51:03 +02:00
treeston
cc9889a3d4 Core/Taxi: Properly send taxi node status on login, as well as if the taxi master is out of range. Closes #20035.
(cherry picked from commit 24ec3ad340)
2020-08-19 20:45:58 +02:00
treeston
0f741c4a7f Scripits/Item: Nitro. BOOSTS.
(cherry picked from commit 125127ea73)
2020-08-19 20:18:44 +02:00
treeston
ba7d8e9ace Scripts/Item: Fix Nitro Boosts to only fail in flyable areas. Also, it's called nitro _boosts_. Not _boots_. Nitro _boosts_.
(cherry picked from commit f953d85960)
2020-08-19 20:18:24 +02:00
jackpoz
32832fa9cb Core/Misc: Fix static analysis issues
(cherry picked from commit 832a114196)
2020-08-19 00:21:48 +02:00
Gustavo
111b65e10f Core/Vehicles: Do not call InstallAllAccessories for dead Vehicles (#20033)
(cherry picked from commit 551d0559aa)
2020-08-19 00:18:55 +02:00
jackpoz
77e6355fba Core/Misc: Fix static analysis issues
(cherry picked from commit 9cf4dd7345)
2020-08-19 00:14:06 +02:00
Killyana
1019fc5801 DB/Creature: Add some missing spawns in Deathforge
(cherry picked from commit abf38f9b8f)
2020-08-18 22:39:55 +02:00
jackpoz
76bd0adaa4 Core/Misc: Fix static analysis issues
(cherry picked from commit 41f4a80f30)
2020-08-18 19:46:12 +02:00
jackpoz
31654a2295 Core/Misc: Fix static analysis issues
(cherry picked from commit b2a341df6e)
2020-08-18 19:42:54 +02:00
Regigicas
e43d81cd68 Scripts/Commands: Fix a crash on summon when no group is avaible (#20029)
Closes #20027

(cherry picked from commit d9c83a6c01)
2020-08-18 19:16:04 +02:00
Killyana
af5c195e7f DB: Use the correct ID for Hagash The blind
Updates #18930

(cherry picked from commit 1f834d3cd1)
2020-08-18 19:04:19 +02:00
Killyana
65c594d86e DB/SAI: Fix Thrallmar Grunt event text
Closes #18930
By dr-j

(cherry picked from commit f9f15250a5)
2020-08-18 19:03:22 +02:00
Golrag
c46aa9d5b5 Core/VMaps: Fix no collision triangles
(cherry picked from commit 89d641f1e6)
2020-08-18 18:53:13 +02:00
Weyrath
35bf146969 Core/Quests: Fixed order of RewardChoiceItems and reputation reward. (#19904)
(cherry picked from commit 8b2bd9a5f2)
2020-08-18 18:53:13 +02:00
Treeston
5f59be31b0 Core/AI: UnitAI::SelectTarget now applies offset BEFORE filtering by predicate (to match expected behavior). (#19975)
* Also some major code deduplication (SelectTarget now calls SelectTargetList).

(cherry picked from commit 8d0633c842)
2020-08-18 18:53:13 +02:00
Killyana
6e0be8b469 DB/Quest: Celestial Planetarium access heroic requirements
Updates #19981

(cherry picked from commit 432dd7c25d)
2020-08-18 18:53:13 +02:00
Killyana
4b6b59931a DB/Quest: Celestial Planetarium access quests
Closes #19981

(cherry picked from commit 1008536ce4)
2020-08-18 18:53:13 +02:00
Killyana
1a1fe1847d DB/Creature: Overseer Faedris
Remove Dup spawn
Closes #20020

(cherry picked from commit 13edbd9e31)
2020-08-18 18:53:13 +02:00
Killyana
842c120fda DB/Quest: Finish Me!
Fix Quest requirements
Closes #20019
by meji46

(cherry picked from commit d50794a33e)
2020-08-18 18:53:13 +02:00
treeston
814f7e45fb Some more script adjustments ported from #19930.
(cherry picked from commit 3f8c0cb446)
2020-08-18 18:53:13 +02:00
Treeston
2c3a107bee Prevent an issue that stopped Aura AfterEffect handlers being called on default handler prevention. (#20001)
Fixes #19996.

(cherry picked from commit ed241a2fd6)
2020-08-18 18:53:13 +02:00
treeston
1e6480ee35 Woopsie. Fix an oversight causing the main tank flag in SelectTarget to be inverted.
(cherry picked from commit 9bacaf15b6)
2020-08-18 18:53:13 +02:00
treeston
2dfafa69eb Hi, I'm Treeston, and welcome to Combat PR Prep Refactors.
Today, we're moving UNIT_FLAG_IMMUNE_TO_PC and UNIT_FLAG_IMMUNE_TO_NPC to higher-level abstraction so combat manager can react to it.
New methods on Unit:
- void SetImmuneTo<All/PC/NPC>(apply, keepCombat = false);
- bool IsImmuneTo<All/PC/NPC>() const;

(cherry picked from commit 74af880217)
2020-08-18 18:53:13 +02:00
Killyana
befbfbb655 DB/Creature: Tivax the Breaker
(cherry picked from commit c6d7994445)
2020-08-18 18:53:13 +02:00
Keader
db80892a41 Build fix
(cherry picked from commit 3aadb72eaa)
2020-08-18 18:53:13 +02:00
Keader
251c1811ae Core/Custom: Fixed SPELLMOD_COOLDOWN exploit on Duel Reset system
Followup 0048d4b618
Closes #17419

(cherry picked from commit e254ebebbe)
2020-08-18 18:53:13 +02:00
Nyeriah
5b8d3ede7d Scripts/Karazhan: Fix Attumen and Midnight not moving towards each other on phase transition after latest changes
(cherry picked from commit 746fce30d9)
2020-08-18 18:53:13 +02:00
Killyana
7e41ddd2f3 DB: Fix the previous commit
(cherry picked from commit fe15464feb)
2020-08-18 18:53:13 +02:00
Killyana
6223dd6437 DB/Gameobject: Add missing spawn of The Alliance of Lordaeron
(cherry picked from commit fb194588e1)
2020-08-18 18:53:13 +02:00
Killyana
c22c02bdc6 DB/Creature: Crystalforge Bunny
(cherry picked from commit ce8996fa23)
2020-08-18 18:53:13 +02:00
Gustavo
d50611c108 Core/Auras: Implement SPELL_AURA_DETECT_AMORE (#19955)
Based on b58b29c958

(cherry picked from commit a27a3e0457)
2020-08-18 18:53:13 +02:00
Treeston
94e164f9c9 Utilities/Containers: New RandomResize implementation with guaranteed asymptotic linear time for all container types (#19974)
(cherry picked from commit ac50034df7)
2020-08-18 18:53:13 +02:00
treeston
67ffe7bcf0 Core/Combat: Fixed issues with creatures sometimes entering combat with friendly targets
Close #19980

(cherry picked from commit 07593f6c34)
2020-08-18 18:53:13 +02:00
treeston
daf9c703c4 Two more refactors I missed for #19930. Last ones for now, I promise.
(cherry picked from commit 62d5113252)
2020-08-18 18:53:13 +02:00
treeston
2c88d9f162 Some more refactoring prep for combat/threat (#19930).
(cherry picked from commit 2739a5c5f5)
2020-08-18 18:53:13 +02:00
treeston
bacc5ef94e Creatures now release spell focus on projectile launch (for spells that have a projectile portion) as opposed to projectile impact.
This should make some very slow projectiles (f.ex. Professor Putricide's Malleable Goo) a lot smoother.

(cherry picked from commit 5d3c69bf44)
2020-08-18 18:53:13 +02:00
Ovah
71db17220a Core/Spells: enable and implement SMSG_MISSILE_CANCEL (#25215) 2020-08-16 12:07:51 +02:00
TDB Release
f4b4425862 TDB 837.20081 - 2020/08/14 TDB837.20081 2020-08-14 21:46:30 +00:00
funjoker
2aed7f18c0 DB: Update quest data for locale zhTW to 35435 2020-08-14 22:47:54 +02:00
funjoker
1fbf66628b DB: Update creature data for locale zhTW to 35435 2020-08-14 22:47:45 +02:00