Commit Graph

995 Commits

Author SHA1 Message Date
Peter Keresztes Schmidt
6c7837f947 Core/Unit: Make HandleEmoteCommand typesafe (#25249)
* Scripts/ScarletMonastery: Fix wrong emote during Headless Horseman encounter

* Scripts/HoR: Fix wrong emote during escape event

* Core/Unit: Make improve type safety of HandleEmoteCommand

Change argument type to the expected enum type Emote

* Scripts/CoS: Use SetUInt32Value to set UNIT_NPC_EMOTESTATE

UNIT_NPC_EMOTESTATE is no flag field
2020-08-15 15:29:43 +02:00
Aokromes
681c738c61 Script/Quest: The Light of Dawn (#25243)
remove incorrect check, source:
https://www.wowhead.com/spell=53606/the-light-of-dawn
Flags	
Can be used while dead

https://www.wowhead.com/quest=12801/the-light-of-dawn#comments:id=1495830
https://www.wowhead.com/quest=12801/the-light-of-dawn#comments:id=374127
2020-08-15 11:10:47 +02:00
Jinnaix
de56ed8736 Scripts/BlackwingLair: Suppression Device Room (PR #25199)
Co-authored-by: offl <11556157+offl@users.noreply.github.com>
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
Co-authored-by: Treeston <treeston.mmoc@gmail.com>
2020-08-08 00:27:16 +02:00
Giacomo Pozzoni
07fd84b679 Core/Misc: Fix static analysis issues (#25194) 2020-08-04 11:36:47 +02:00
Peter Keresztes Schmidt
c88234727b Scripts/MoltenCore: Update Golemagg encounter to current coding standards (#25183)
* Scripts/MoltenCore: Update Golemagg to current coding standards

* no functional changes

* Scripts/MoltenCore: Update Core Ranger to current coding standards

* no functional changes
2020-08-01 23:12:54 +02:00
Carbenium
799d5376d8 Scripts/AV: Update Vanndar's script to use TaskScheduler
* No functional changes
2020-08-01 21:13:30 +02:00
Carbenium
228696bf80 Core/Common: Merge TimeTrackerSmall with TimeTracker 2020-08-01 12:43:55 +02:00
Carbenium
e55516348d Core/Common: Add a std::chrono interface to TimeTrackerSmall
New methods:
TimeTrackerSmall(Milliseconds expiry);
void Update(Milliseconds diff);
void Reset(Milliseconds expiry)
Milliseconds GetExpiry() const

Removed methods:
int32 GetExpiry() const

Also add basic unit tests.

Core/Scripts: Use std::chrono interface of TimeTrackerSmall
2020-08-01 12:43:55 +02:00
Giacomo Pozzoni
7cf122fc2a Core/Misc: Fix static analysis issues (#25178) 2020-07-31 22:53:13 +02:00
Jinnaix
e3aa87641f Scripts/BlackrockSpire: Fix encage event of Pyroguard encounter (#25177) 2020-07-31 13:58:26 +02:00
Somebody
81f3ed1d0c Scripts/Deadmines: Doors after Rhahk'Zor, Sneed and Gilnid (#25107)
* Fix doors opening after killing Sneed and Gilnid in the Deadmines dungeon

* Add SQL file

* Update 2020_99_99_00_world.sql

SQL conventions

* Change SAI door opening into C++ door opening and make it use SetBossState.

* Delete 2020_99_99_00_world.sql

Replaced by different sql file

* Make CircleCI happy

* Change const to constexpr for EncounterCount variable

* Update src/server/scripts/EasternKingdoms/Deadmines/deadmines.h

Co-authored-by: Peter Keresztes Schmidt <carbenium@outlook.com>

* Update src/server/scripts/EasternKingdoms/Deadmines/deadmines.h

Co-authored-by: Peter Keresztes Schmidt <carbenium@outlook.com>

* Rename 9999_99_99_00_world.sql to 2020_07_30_00_world.sql

Co-authored-by: Peter Keresztes Schmidt <carbenium@outlook.com>
Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
2020-07-30 14:14:08 +02:00
Carbenium
1245833cdd Core/CreatureAI: std::chrono-ify DoSummon* methods 2020-07-28 17:25:51 +02:00
Carbenium
8642aaaf92 Core/WorldObject: Replace non-std::chrono SummonGameObject overloads
Also fix intended despawn time of GOs used by the "Engineering a Disaster" quest
2020-07-27 23:00:51 +02:00
Carbenium
3620b47c41 Core/WorldObject: Replace non-std::chrono SummonTrigger overloads 2020-07-27 14:58:18 +02:00
Carbenium
a41f599be7 Core/WorldObject: Remove non-std::chrono SummonCreature overload
Remove
TempSummon* SummonCreature(uint32 entry, Position const& pos, TempSummonType despawnType = TEMPSUMMON_MANUAL_DESPAWN, uint32 despawnTime = 0, uint32 vehId = 0, uint32 spellId = 0);
2020-07-27 14:53:25 +02:00
Carbenium
92a02a5c87 Core/EventProcessor: std::chrono-ify CalculateTime
uint64 CalculateTime(uint64 t_offset) has been replaced with Milliseconds CalculateTime(Milliseconds t_offset).
Also add the std::chrono-ified overload void AddEvent(BasicEvent*, Milliseconds, bool)
2020-07-27 13:36:25 +02:00
Carbenium
1131229ee9 Core/WorldObject: Partially std::chrono-ify SummonCreature overloads
TempSummon* SummonCreature(uint32 entry, float x, float y, float z, float o = 0, TempSummonType despawnType = TEMPSUMMON_MANUAL_DESPAWN, uint32 despawnTime = 0);
to
TempSummon* SummonCreature(uint32 entry, float x, float y, float z, float o = 0, TempSummonType despawnType = TEMPSUMMON_MANUAL_DESPAWN, Milliseconds despawnTime = 0s);
2020-07-26 23:30:32 +02:00
Carbenium
d1a39a2ebf Scripts/EasternKingdoms: Use std::chrono overload of Creature::DespawnOrUnsummon 2020-07-26 22:12:24 +02:00
Carbenium
f5076112cb Core/ScriptedAI: std::chrono-ify DoSpawnCreature 2020-07-25 23:16:04 +02:00
Carbenium
d7ff8c272a Core/InstanceScript: std::chrono-ify DoRespawnGameObject 2020-07-25 23:10:14 +02:00
Peter Keresztes Schmidt
e6e5775be8 Build: Enable -Wimplicit-fallthrough on clang (#25056)
* Misc: Use [[fallthrough]] attribute instead of comment to mark intentional fallthroughs

Related: #25006

* Misc: Add some missing breaks (no-ops) to satisfy clang

Related: #25006
Closes #25055

* Build: Enable -Wimplicit-fallthrough on clang

Closes #25006
2020-07-18 20:43:16 +02:00
Peter Keresztes Schmidt
88314660b6 Scripts/Magisters Terrace: Use std::chrono::duration overloads of EventMap (#25038)
Contributes to #25012
2020-07-14 20:47:10 +02:00
Peter Keresztes Schmidt
5ef576d223 Scripts/EasternKingdoms: Use std::chrono::duration overloads of EventMap (#25019)
Contributes to #25012
2020-07-14 19:10:30 +02:00
Peter Keresztes Schmidt
ac27c922d1 Scripts/Blackrock Mountain: Use std::chrono::duration overloads of EventMap (#25018)
Contributes to #25012
2020-07-14 19:05:24 +02:00
Giacomo Pozzoni
203573db83 Core/Spells: Implement SPELL_EFFECT_ACTIVATE_OBJECT. (#23) (#24997)
* Core/Spells: Implement SPELL_EFFECT_ACTIVATE_OBJECT. (#23)

Original research by @xvwyh.

# Conflicts:
#	src/server/game/DataStores/DBCStores.cpp
#	src/server/game/DataStores/DBCStructure.h
#	src/server/game/DataStores/DBCfmt.h
#	src/server/game/Entities/GameObject/GameObject.h
#	src/server/game/Entities/GameObject/GameObjectData.h
#	src/server/scripts/EasternKingdoms/ZulAman/zulaman.cpp
#	src/server/scripts/Kalimdor/HallsOfOrigination/boss_temple_guardian_anhuur.cpp

* Add missing sql update

* Fix some build errors

* Remove unused enum values

* Change artkits from 0-4 to 0-3

* Remove unused code

* Code review feedback

* Fix sql

* Remove artkit4 special case handling

* Default initialize artKits

* Code review feedback

* Split sql into structure and data files

Co-authored-by: Warpten <vertozor@gmail.com>
2020-07-14 09:34:03 +02:00
Peter Keresztes Schmidt
c92950b3e1 Core/DataStores: Update DBC field names to generated ones (#24999) 2020-07-12 15:36:55 +02:00
genion18
32aebc14ab DB/Quest: Rumors for Kravel outro event
Closes #24835
2020-06-29 01:32:49 +02:00
offl
eea3cf1401 DB/Quest: Convert & update support for 'Escorting Erland' to SAI
Closes #24834
2020-06-29 01:24:45 +02:00
offl
fb58ca0bf5 DB/Quest: Convert & update support for 'Pyrewood Ambush' to SAI
Closes #24833
2020-06-29 01:11:10 +02:00
offl
f621173748 DB/Quest: Convert Galen's Escape to SAI
Closes #23684
2020-06-26 16:05:08 +02:00
NoName
51b221c8f8 Script/ScarletEnclave: Eye of acherus now rooted at spawn (#24725) 2020-06-21 12:56:41 +02:00
Peter Keresztes Schmidt
418c3b1fd5 game/AI: Convert SelectAggroTarget to enum class (#24818)
* game/AI: Convert SelectAggroTarget to enum class

* game/AI: Rename SelectAggroTarget to SelectTargetMethod
2020-06-16 23:08:56 +02:00
offl
a117450ce9 DB/Instance: Convert some Uldaman scripts to DB
Closes #24744
2020-06-14 19:16:55 +02:00
offl
8bccb258ba DB/Quest: Convert & update support for 'All Along the Watchtowers' to SAI
Closes #24732
2020-06-14 18:26:35 +02:00
offl
d70eb96c85 DB/Quest: Convert & update support for WP Scourge cauldrons quests to SAI
Closes #24730
2020-06-14 18:12:17 +02:00
offl
e47f302fc9 DB/Quest: Convert & update support for 'Escape from the Catacombs' to SAI
Closes #24728
2020-06-14 17:52:12 +02:00
Keader
f2f4fc921e kill white space in last commit 2020-06-09 09:57:47 -03:00
Keader
be48fbc32a Scripts/ShadowfangKeep: Fixed a crash in spellscript 2020-06-09 09:52:44 -03:00
ForesterDev
e3b232fe0e Core/AI: refactor SpellHit and SpellHitTarget. (#24691)
* Core/AI: refactor SpellHit and SpellHitTarget.

- now caster/target is WorldObject instead of Unit
- remove SpellHitByGameObject / SpellHitTargetGameObject (handled by SpellHit / SpellHitTarget)
- rename parameters in scripts according parent methods

* Restore logic in Algalon script

* Changed check for REMORSELESS_WINTER hit to avoid dublicate call, because it has TARGET_UNIT_CASTER for effects 0/1 and TARGET_GAMEOBJECT_SRC_AREA for effect 2

* Fix build after merge
2020-06-07 10:22:13 +02:00
jackpoz
adc7cd3cee Core/Misc: Fix static analysis issues reported by Coverity Scan 2020-06-03 20:49:31 +02:00
offl
9ebf7b1272 DB/SAI: Convert & update support for Forest Frog to SAI
Closes #24714
2020-05-30 16:37:59 +02:00
Killyana
5856f520bb Boss/Script: Remove Hex Lord Malacrass wrong equipment from the script and use the one from the DB 2020-05-25 15:52:23 +02:00
jackpoz
7b8b02c32e Scripts/BWL: Fix crash in Razorgore encounter 2020-04-22 22:09:10 +02:00
Sven
c3037c3563 Improvements to Pyroguard Emberseer (UBRS) script (#24405)
* UBRS: Improve Pyroguard Emberseer script

* Remove whitespaces

* More whitespaces removed

* Addressing change requests
Removed cast from constructor
Removing unused member field

* That should be the last white spaces

* Forgot to remove the declaration

* Update boss_pyroguard_emberseer.cpp

* Add break to For loop

* War on white spaces

Co-authored-by: Giacomo Pozzoni <giacomopoz@gmail.com>
2020-04-12 10:00:15 +02:00
jackpoz
caae3886d2 Core/Misc: Remove whitespace at the end of lines 2020-04-05 19:11:00 +02:00
Killyana
c026b3bad3 Boss/Script: Disable Call assistance for Mr Smite
Closes #19164
2020-03-29 18:44:43 +01:00
Killyana
5b2b221177 Boss/Script: Mr Smith will use the proc aura for Nimble Reflexes instead a script 2020-03-29 17:46:08 +01:00
Keader
85d1fd3038 Fixing some white spaces and unneeded header, added in previous commit 2020-03-20 10:57:49 -03:00
Jinnaix
a8a0f6b261 Scripts/Blackwing Lair - Doors correction (#24327)
Fix all doors
corrected the Chromaggus fight start
correctly close final bossfight door at fight and open it on reset or bosskill
2020-03-20 10:51:43 -03:00
jackpoz
db07bc9553 Script/ZulGurub: Fix crash 2020-03-17 20:40:48 +01:00