Commit Graph

18031 Commits

Author SHA1 Message Date
Ghaster
f4d029b952 Core/Creature: Profession trainer fixes (PR #22904)
Closes #22903

(cherry picked from commit 19791a35df)
2021-11-18 22:41:57 +01:00
Keader
c4eed6561c Scripts/The Steamvault: Fixed Chambers Access Panel and Main Chambers Door
Closes #21067
Ty Kittnz, killerwife, Aokromes (sniffs)

(cherry picked from commit b283565d8a)
2021-11-18 22:41:55 +01:00
jackpoz
0b556d8a91 Core/Handlers: fix ".whisper on" with opposite faction/low level
Closes #22283

(cherry picked from commit f11117584d)
2021-11-18 15:59:31 +01:00
Giacomo Pozzoni
ff2cd4a032 Scripts/Commands: Fix crash caused by .set npc model (#22877)
* Scripts/Commands: Fix crash caused by .set npc model

Fix crash caused by .set npc model with invalid model id

(cherry picked from commit 20ea24bf5c)
2021-11-18 15:57:20 +01:00
Shauren
ce794f3978 Core/Spells: Fixed ErrorCube spell missiles
(cherry picked from commit 3b5014fdae)
2021-11-18 01:10:19 +01:00
PolarCookie
fa07f74db2 Spell/Script: Scourge Disguise and Haunting Phantoms (#22727)
(cherry picked from commit 66720e5fd9)
2021-11-16 22:00:58 +01:00
Shauren
3ba2547ec0 Core/Trainers: Remove unused define 2021-11-16 21:37:53 +01:00
Shauren
f8dc4da282 Core/Players: Partial port of baebb2d602 (just packet sending function)
(cherry picked from commit baebb2d602)
2021-11-16 21:35:11 +01:00
Giacomo Pozzoni
4177030dcf Scripts/Nagrand: Fix crash added in PR #22806 (#22878)
Fix crash added in PR #22806 happening in quest "Ruthless Cunning and Returning the Favor"

(cherry picked from commit cb13638721)
2021-11-16 21:04:05 +01:00
Shauren
9be92e218c Core/PacketIO: Fixed SMSG_BATTLE_PET_ERROR structure 2021-11-16 20:54:15 +01:00
Shauren
f3c1b27c26 Core/Units: Fixed crash happening when charm was removed by its own charmed AI during update
(cherry picked from commit c7445669e8)
2021-11-16 20:40:05 +01:00
Giacomo Pozzoni
d5c41d23e6 Core/Misc: Log more information in asserts (#22783)
* Core/Misc: Log more information in asserts

Add a new function GetDebugInfos() to types that could trigger an ASSERT() to easily include more useful information in crashlogs.
This is an initial commit that requires many more commits to implement the new GetDebugInfos() function in all required types.
If the type doesn't have the function, the global default one is picked which doesn't log anything.

* Core/Misc: Fix dynamic build

Add missing attribute for dynamic build

* Core/Misc: Fix gcc/clang build

* Core/Misc: Rename GetDebugInfos() to GetDebugInfo()

* Core/Misc: Fix FormatAssertionMessage() adding an extra '\0'

* Core/Misc: Add GetDebugInfo support to Unit

* Core/Misc: Add GetDebugInfo support to Creature

* Core/Misc: Add more info to GetDebugInfo for Creature

* Core/Misc: Add GetDebugInfo support to GameObject

* Core/Misc: Add GetDebugInfo support to Player

* Core/Misc: Add more GetDebugInfo info

* Core/Misc: Add GetDebugInfo support to Item

* Core/Misc: Add GetDebugInfo support to Bag

* Core/Misc: Add GetDebugInfo support to Transport

* Core/Misc: Add GetDebugInfo support to TempSummon, Minion, Guardian, Pet

* Core/Misc: Add GetDebugInfo support to Map, InstanceMap

* Core/Misc: Add GetDebugInfo support to Spell

* Core/Misc: Fix build warning

* Core/Misc: Add GetDebugInfo support to Aura

* Core/Misc: Add GetDebugInfo support to UnitAI

(cherry picked from commit 9a924fb9d5)
2021-11-16 20:36:58 +01:00
Treeston
5b45253f57 Core/Misc: Explicit typing for SpellAttrN enums, add nicer text to UNKs, and restore some relevant info from old comments. Final one of these.
(cherry picked from commit 3acba6dded)
2021-11-16 19:52:57 +01:00
Shauren
b981606575 Core/PacketIO: Fixed SMSG_LEVEL_UP_INFO structure 2021-11-16 15:53:40 +01:00
Meji
a832435b97 Core/Spells: Implemented SummonPropertiesFlags: UseSummonerFaction & IgnoreSummonerPhase (#27273) 2021-11-16 11:51:05 +01:00
Aokromes
8967f9ccf2 Update zone_borean_tundra.cpp
(cherry picked from commit 6851ba638d)
2021-11-16 00:52:24 +01:00
PolarCookie
f377dc23f3 Quest: Ruthless Cunning and Returning the Favor (#22806)
* Ruthless Cunning and Returning the Favor

* no more magic numbers

* now with scripted ai and condition

* travis

* more travis

* jackpoz

* now with no banner spellscripts

* typo

* Rename 9999_99_99_99_world.sql to 2018_12_03_00_word.sql

(cherry picked from commit 9d93504f34)
2021-11-16 00:51:51 +01:00
Aokromes
c44650502c Core/GameEvent: weekend xp rate (#17782)
* Core/GameEvent: weekend xp rate
by kline

* Update to recent code

* compile fix try
things of copy and paste 4 years old code xd

* more code update

* forgot to change this

* Update worldserver.conf.dist

* Added function to calculate weekend event xp rates

By greenbagels

* Cleaning using scripts

* Implement daymask and rename variables etc.

* Rename script file weekend -> boosted

* Update src/server/game/World/World.cpp

Co-Authored-By: Aokromes <Aokromes@users.noreply.github.com>

* Fix xp multiplier not applying to quest rewards

* Disable xp boost script when no boosted days selected

(cherry picked from commit 538c5b8687)
2021-11-16 00:50:23 +01:00
Shauren
a0de41af69 Core/Misc: Update description text for SpellAttr8-14 2021-11-16 00:38:33 +01:00
Treeston
65dc3d18e0 Core/Misc: Update description text for SpellAttr6 and SpellAttr7
(cherry picked from commit cd7b036485)
2021-11-16 00:22:08 +01:00
Treeston
b76daf0bc7 Core/Misc: Update description text for SpellAttr5 (I'm back, baby!)
(cherry picked from commit 9309988a05)
2021-11-16 00:13:07 +01:00
Gildor
4a775c01e9 Core/Scripts - The Eye: Fix Kael'thas Sunstrider Mind Control, limit MaxAffectedTargets to 3 (#22828)
Closes: #22826
(cherry picked from commit 0ee8a77dce)
2021-11-16 00:07:15 +01:00
Ovah
234a680d3a Core/Objects: properly use UPDATETYPE_CREATE_OBJECT2 when creating brand new objects in all cases. Closes #22419 (#22816)
(cherry picked from commit fb1d568fba)
2021-11-15 23:42:22 +01:00
Treeston
058f0edd86 Core/Misc: Update description text for SpellAttr4
(cherry picked from commit 8836fc3903)
2021-11-15 23:39:29 +01:00
Treeston
8464079ab8 Core/Misc: Update description text for SpellAttr3
(cherry picked from commit 50f78e686c)
2021-11-15 23:33:18 +01:00
Treeston
da68d7a191 Core/Misc: Update description text for SpellAttr2
(cherry picked from commit 9b4feaacfa)
2021-11-15 23:24:02 +01:00
Treeston
43d3d5bbb3 Core/Misc: Update description text for SpellAttr1
(cherry picked from commit 8cac5feb58)
2021-11-15 23:20:38 +01:00
Treeston
fe9ca742a3 Core/Misc: Update description text for SpellAttr0 to match actual behavior
(cherry picked from commit b69ee07d50)
2021-11-15 23:08:46 +01:00
Treeston
d43f14ab0c DB/Strings: remove some now-unused language entries
(cherry picked from commit 0068813ef9)
2021-11-15 22:57:55 +01:00
Keader
b37023891e Scripts/Utgarde Keep: Fixed Ingvar evade in phase 2 (one more time)
Closes #21264
ScheduleEvents need happens after remove ImmuneToPc, or it will cause evade.

(cherry picked from commit f1a1acdc89)
2021-11-15 22:37:04 +01:00
Keader
77ed0f2399 Scripts/ToC: Fixed Twin Valkyr stucking in progress and added hover
Closes: #22755
Update: #20961
(cherry picked from commit 4c6f0eaa8d)
2021-11-15 22:36:16 +01:00
Treeston
1015f30704 Core/AI: Add some checks to catch if the AI changes mid-update for players. Tag #22731 #22629.
(cherry picked from commit d8fee3c46b)
2021-11-15 22:20:17 +01:00
PolarCookie
1232f1d06e Core/Creatures: Changed creatures to become tagged by player doing any action that causes creature aggro (apart from distance) (#22759)
* This was introduced in patch 3.0.8

(cherry picked from commit f2df802c50)
2021-11-15 22:16:04 +01:00
PolarCookie
87486cecff Core/Spells: fix issues with delayed spells and auras (#22382)
* Core/Spells: fix issues with delayed spells and auras

* Make Travis Happy

(cherry picked from commit a0999744ef)
2021-11-15 22:13:17 +01:00
DanVS
0585032c90 Core/Entities: Handle partial state change for pets (#22014)
* handle partial state change

* range-based for loop

* fixes

* readability

* break

(cherry picked from commit ae22fd6d74)
2021-11-15 22:10:18 +01:00
Rochet2
afac2b1742 Add rotation to .gob info (#22723)
* Add rotation to .gob info

- Add rotation (yaw, pitch, roll) to .gob info command
- Replace LANG_SPAWNINFO_DISTANCEFROMPLAYER with LANG_SPAWNINFO_ROTATION
- Fix description of .distance to describe the command arguments (the more you know..)
- Fix .gob info guid targetting nearest gameobject instead of finding with given guid
- Reorder the info data slightly
- Print location and rotation data regardless of object found in world
- Add error messages for when object is not found by guid or entry

(cherry picked from commit 257ae44a20)
2021-11-15 21:49:37 +01:00
Treeston
c977087d58 Core/Misc: Partial merge of 3.3.5-dbedit:
- Added SmartEnum.h for enum iteration, stringification, and more, courtesy of krabicezpapundeklu/smart_enum
- Moved a bunch of enums in SharedDefines.h to the new system
- Miscellaneous utility methods ported

Core/Util: Redesign SmartEnum to properly work for large
 enums (>64 entries) and play nice with IDEs (PR #22768)

(cherry picked from commit 338e8ba0fe)
(cherry picked from commit f7ca0877a3)
(cherry picked from commit 207093475a)
(cherry picked from commit ee68cf3392)
(cherry picked from commit c16d461e16)
(cherry picked from commit f6b0d99e2c)
(cherry picked from commit bc1f456125)
2021-11-15 21:34:03 +01:00
ccrs
df2f6ad219 Core/Shared: add BattlefieldBattleId definitions
Also rename BG_TEAMS_COUNT and BattlegroundTeamId

(cherry picked from commit 7417cbc655)
2021-11-15 18:52:02 +01:00
Keader
fea450d9de Scripts/Ulduar: Fixed Sanctum Sentry accumulating events after wipes
(cherry picked from commit 266a9c3d41)
2021-11-15 18:29:20 +01:00
Aokromes
a560800f9d Script/Misc: Change some placeholders to proper texts
(cherry picked from commit 3ea3ed348a)
2021-11-15 17:51:05 +01:00
Aokromes
c84d9f5aa9 Core/Spells: Hallowed Wand - Bat custome must be positive
closes #22684

(cherry picked from commit d6d2c4efb9)
2021-11-15 14:41:50 +01:00
Killyana
a0bac8c53a DB/GameObject: Sacred Fire of Life
(cherry picked from commit 2dc28bc3a7)
2021-11-15 14:17:57 +01:00
ccrs
248101b458 Core/Movement: remove undefined method
(cherry picked from commit c8836b6eb4)
2021-11-15 14:15:14 +01:00
Trond B. Krokli
b63fe46e0e Scripts/Blackrock Depths: npc_grimstone Event_Timer improvements (#22663)
High Justice Grimstone's movement script timers improvement in Ring of the Law.

case 6 & case 7 modifications:
- Event_Timer = 5000; // originally 0

Closes #20499 (High Justice Grimstone issue)

(cherry picked from commit 48eba61e90)
2021-11-15 14:01:49 +01:00
Killyana
07bba72fe7 DB/Gossip: Update Vaelastrasz gossip menu with the correct ID
(cherry picked from commit d10e42c049)
2021-11-15 01:41:29 +01:00
Keader
fe4da71f1d Scripts/Illidari Council: Changed urand to SelectRandomContainerElement
(cherry picked from commit 6cb754ca4e)
2021-11-15 00:15:39 +01:00
Keader
f69c8c2e60 Scripts/Black Temple: Fixed a crash on Illidari Council (#22652)
Ty Sirikfoll :)

(cherry picked from commit 9a443306fb)
2021-11-15 00:15:16 +01:00
ForesterDev
e58d737a93 Core/Commands: fix .appear command provide wrong undermap position (#22624)
(cherry picked from commit 1e99f98327)
2021-11-14 20:52:50 +01:00
ForesterDev
4e66353854 Core/Commands: Fix quest remove error message (#22623)
(cherry picked from commit 82a1448705)
2021-11-14 20:52:18 +01:00
Shauren
85a23f2ad1 Core/Creatures: Defined new npc flags 2021-11-14 20:31:43 +01:00