Commit Graph

24581 Commits

Author SHA1 Message Date
Killyana
f6e709cde3 DB/Creature: Gubber Blump
Add gossip option to learn fishing if the quest 1141 is taken an fishing is not learned
Closes #15954
2015-12-08 00:16:53 +01:00
jackpoz
2cb54d5606 Core/Player: Fix crash related to vehicles
Fix assertion triggered when entering a vehicle while channelling a shared vision spell.
Fix #15953
2015-12-07 23:34:00 +01:00
jackpoz
5b8b32dac7 Core/Quest: Fix issues reported by static analysis 2015-12-07 20:55:33 +01:00
jackpoz
3267c90102 Core/Unit: Add Unit::KillSelf() overload
Add Unit::KillSelf() function as overload of Unit::Kill(this) . Use KillSelf() whenever the killer and the victim are the same to clearly state the Unit is going to kill itself.
2015-12-07 20:06:02 +01:00
jackpoz
ee12982008 Merge pull request #15933 from Asterc/3.3.5
Core/Spells: Fix Misdirection exploit
2015-12-07 19:11:48 +01:00
jackpoz
1ddf44caf3 Core/Quest: Fix issues reported by static analysis 2015-12-07 18:31:53 +01:00
jackpoz
bffaa92633 Core/Quest: Fix issues reported by static analysis 2015-12-06 22:43:15 +01:00
jackpoz
f1f4005ad8 Core/Quest: Fix issues reported by static analysis 2015-12-06 21:37:58 +01:00
Killyana
e60bbaa7d3 DB/Quest: Great Bear Spirit
Closes #15950
2015-12-06 20:04:13 +01:00
jackpoz
39a77effd7 Merge pull request #15947 from ShinDarth/duel-exploit
Core/Spell: Fix exploit in duel cooldown reset handling
2015-12-06 19:47:13 +01:00
ShinDarth
03215a2eb7 Core/Spell: fixed possible exploit in Duel Reset script
- thanks @Runico for reporting it
2015-12-06 03:44:12 +01:00
Killyana
984bf32fa8 DB/Quest: Restore deleted sql for Anatoly Will Talk 2015-12-05 03:53:51 +01:00
Killyana
bcc2b00072 DB: Fix a Typo 2015-12-04 17:17:33 +01:00
Killyana
6695c98b59 DB/Quest: Gorgrom the Dragon-Eater
Closes #6326
2015-12-04 16:50:47 +01:00
MitchesD
ab831507c6 Core/Conditions: extended CONDITION_NEAR_CREATURE, condition value 3 is now used to check for dead creature entries (0 - alive, 1 - dead)
* I used 0 for alive to avoid touching all conditions with this type

(cherry picked from commit cdb5bd3eb7)
2015-12-03 21:41:03 +01:00
Asterc
f8f815dbc3 Correctly reset the redirected threat of the hunter's spell Misdirection in cases when it has RemoveMode AURA_REMOVE_BY_DEFAULT
Closes #15930
2015-12-02 19:30:12 -02:00
Shauren
94e4bddb90 Scripts/Icecrown Citadel: Professor Putricide - fixed Expunged Gas damage formula
Closes #6396
2015-12-01 19:27:17 +01:00
MitchesD
332d08a859 Rename 2015_11_15_3574_world.sql to 2015_12_01_00_world.sql 2015-12-01 15:05:48 +01:00
MitchesD
3b1f5f29c9 Merge pull request #15864 from tkrokli/hallowed_wands
Scripts/Spells: Hallow's End item Hallowed Wand
2015-12-01 15:05:15 +01:00
jackpoz
c703e01471 Merge pull request #15920 from Treeston/3.3.5-MCHotkeyPos
Unit/PossessBar: Fix spell ordering on possess bar
2015-11-30 20:24:15 +01:00
Killyana
01beba21b5 DB/Quest: Fel Reavers, No Thanks!
By @Gargarensis
Closes #3965
2015-11-30 00:31:55 +01:00
Killyana
43129b33ca DB/Quest: Creatures of the Eco-Domes
Closes #3025
2015-11-29 19:57:03 +01:00
treeston
1be635a025 Unit/PossessBar: Fix spell ordering on possess bar to reflect spell position in DB. Fixes Razuvious adds et al. 2015-11-29 18:41:36 +01:00
Shauren
3ab108c8ea Core/Spells: Fixed passibe talent auras targeting pets instead of player
Closes #1543
Closes #15918
2015-11-29 14:13:30 +01:00
jackpoz
c1b4cd21f3 Merge pull request #15912 from Treeston/3.3.5-urandms
Core/Util: Add urandms(minMS, maxMS) helper
2015-11-29 00:07:35 +01:00
treeston
c0faee0795 Core/Util: Add a urandms(min,max) helper to make urand(min*IN_MILLISECONDS, max*IN_MILLISECONDS) shorter to write for random time intervals (boss scripts). 2015-11-28 23:53:04 +01:00
jackpoz
f8a3fa28bb Merge pull request #15907 from ShinDarth/fix
Core/Spells: Fix Arcane Missiles
2015-11-28 21:55:45 +01:00
jackpoz
a67f378f10 Merge pull request #15904 from 'ForesterDev/instance_login_cleanup' 2015-11-28 21:45:41 +01:00
Killyana
787b7ae850 DB/Quest: Prisoner of the Bladespire
Closes #15913
2015-11-28 21:14:04 +01:00
ShinDarth
5fae63804c Core/Spells fix Arcane Missiles
- close #15902
2015-11-28 00:23:34 +01:00
Vincent-Michael
e266278f7d Core/Players: Fixed warning 2015-11-27 22:10:21 +01:00
Shauren
ba1e00399d Core/Players: Use constant gender from PLAYER_BYTES_3 where appropriate.
Closes #15895
2015-11-27 18:30:01 +01:00
Dr-J
3c4f435629 DB/SAI: Underbog Colossus
http://www.wowhead.com/npc=21251/underbog-colossus#comments

Add missing on death events, previously when killed these always cast toxic pool 

When killed now one of the following will happen

* Nothing
* Spawn Toxic Pool
* Spawn 2 Colossus Lurker http://www.wowhead.com/npc=22347/colossus-lurker#comments
* Spawn around 10 of Colossus Rager http://www.wowhead.com/npc=22352/colossus-rager#comments
2015-11-27 17:12:35 +00:00
jackpoz
9020790db2 Merge pull request #15903 from tkrokli/remove_script_npc_anchorite_truuen
Core/Scripts: Remove deprecated script npc_anchorite_truuen

Remove deprecated script npc_anchorite_truuen replaced by SAI in 2cecc7b1f7
2015-11-27 15:25:03 +01:00
ForesterDev
9573ec52f0 Core/Player: cleanup function CheckInstanceLoginValid 2015-11-27 12:53:48 +04:00
tkrokli
66073e4403 Core/Scripts: remove redundant script npc_anchorite_truuen
The cpp script npc_anchorite_truuen has become redundant
because it has been replaced by a SAI script in commit 2cecc7b.

This script currently causes an error line in DBErrors.log:
```
Script named 'npc_anchorite_truuen' does not have a script name assigned in database.
```
2015-11-27 04:02:30 +01:00
jackpoz
5f917e2286 Core/Player: Always allow accounts with RBAC_PERM_COMMAND_GM to enter instances on login
Always allow accounts with RBAC_PERM_COMMAND_GM to enter instances on login even if player had .gm off .
Send an ingame message to notify the user about the avoided kick.
2015-11-26 21:54:22 +01:00
jackpoz
6e296ddaa2 Scripts/EyeOfEternity: Fix crash
Fix crash happening when a player would kill a Melee npc on the disks during Malygos fight and mount it before it ended the waypoint path.
Close #15900
2015-11-26 21:47:50 +01:00
MitchesD
3b90b0368a Core/Misc: fix warning and misc codestyle fixes 2015-11-26 19:28:53 +01:00
MitchesD
28fb22b108 Merge pull request #15899 from Treeston/3.3.5-thaddius
Scripts/Naxxramas: Thaddius follow-up
2015-11-26 19:13:30 +01:00
treeston
bf99630399 Scripts/Naxxramas: Thaddius follow-up:
- Reduce initial spawn timer on the encounter from 30 seconds to 5 seconds
- Rearrange respawn logic to fix the "petrified" visual from not showing properly
- Fix a potential infinite respawn loop that could prevent the encounter from initializing properly (fixes and closes #15898)
2015-11-26 18:57:15 +01:00
jackpoz
981b871d2f Tools/MMapGenerator: Fix an edge case of infinite loop
Fix a (pseudo) infinite loop happening when generating mmaps for single tile maps (like 249) but with vmaps not present in the correct folder. This would trigger a 18446744065119600000 (uint32 max ^ 2) iterations loop.
2015-11-25 21:49:27 +01:00
Shauren
e9bd786351 Merge pull request #15763 from ShinDarth/channeled
[3.3.5] Fix conflicts between duration and cast time of channeled spells
2015-11-25 18:31:33 +01:00
ShinDarth
246e568bbd Core/Spells: fix conflicts between duration and cast time of channeled spells 2015-11-25 18:21:52 +01:00
Carbenium
d4608c8168 Dep/SFMT: Add diff fordd55e41c8158fe1f60e120b0b89469d4112158d2 2015-11-25 14:18:49 +01:00
Carbenium
dd55e41c81 Dep/SFMT: Fix a strict-aliasing warning reported by GCC 4.9 2015-11-25 13:56:33 +01:00
Carbenium
49a16c9fd0 Tools/MMapGenerator: Fix some warnings reported by GCC 4.9 and MSVC 14 with W4
* /var/lib/jenkins/jobs/tc_335_release_gcc49/workspace/src/tools/mmaps_generator/MapBuilder.cpp: In member function ‘void MMAP::MapBuilder::WorkerThread()’:
  /var/lib/jenkins/jobs/tc_335_release_gcc49/workspace/src/tools/mmaps_generator/MapBuilder.cpp:174:28: error: ‘mapId’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
               buildMap(mapId);

* variable redefinition warning
* remove 2 "using namespace std"

*NO reextraction of mmaps needed*
2015-11-25 12:50:28 +01:00
Killyana
5df0bcdd4e DB: Fix an incorrect Text range in creature_text 2015-11-24 17:52:38 +01:00
Carbenium
f0c7061f0b Tools/MapExtractor: Fix a warning reported by gcc 4.9
/var/lib/jenkins/jobs/tc_335_release_gcc49/workspace/src/tools/map_extractor/System.cpp:113:25: error: ignoring return value of ‘int chdir(const char*)’, declared with attribute warn_unused_result [-Werror=unused-result]
             chdir("../");

*NO reextraction of dbcs/maps needed*
Binary compatibility is ensured
2015-11-24 11:37:45 +01:00
Killyana
4298ade165 DB/Quest: Hot and Cold 2015-11-23 20:17:04 +01:00