Richard 6c54fbbb03 [3.3.5] Core/Loot: Fix conditional Master Loot (#17943)
* Core/Loot: Fix master looting of conditional items

follow_loot_rules was a flag intended to force certain quest items to be
master looted. It should not be used for the
NonQuestNonFFAConditionalLoot.

The flag was originally introduced in 869ea349
"Core/Loot: fix the way quest items are handled. so far ive only found 3
quest items that should be able to be masterlooted. added a new flag to
item_template.flagsCustom to allow for making a quest item always follow
loot rules. a bonus may be the fix of the handlelootmasteropcode crash!"

* Core/Loot: Rename QuestItem to NotNormalItem

QuestItem struct was being used for quest items, ffa items, and
conditional items. Renaming it to avoid confusion when working with ffa
and conditional items

* Core/Loot: Use existing AddAllowedLooter rather than reaching into allowedGUIDs directly

* Core/Loot: Rename NotNormalItem to NotNormalLootItem

(cherry picked from commit f5d3343f27)

# Conflicts:
#	src/server/game/Entities/Item/Item.cpp
#	src/server/game/Loot/LootMgr.cpp
#	src/server/game/Loot/LootMgr.h
2017-12-10 17:59:58 +01:00
2017-01-01 16:23:13 +01:00
2017-10-16 22:54:23 +02:00
2017-10-16 22:54:23 +02:00
2013-01-21 02:47:51 +00:00
2014-12-05 23:49:46 +01:00
2017-01-01 16:23:13 +01:00
2017-03-04 14:51:35 +01:00
2017-04-24 13:27:14 +01:00

logo TrinityCore (master)

Average time to resolve an issue Percentage of issues still open

Build Status

master 3.3.5
master Build Status 3.3.5 Build Status
master Build status Build status
Coverity Scan Build Status Coverity Scan Build Status

Introduction

TrinityCore is a MMORPG Framework based mostly in C++.

It is derived from MaNGOS, the Massive Network Game Object Server, and is based on the code of that project with extensive changes over time to optimize, improve and cleanup the codebase at the same time as improving the in-game mechanics and functionality.

It is completely open source; community involvement is highly encouraged.

If you wish to contribute ideas or code please visit our site linked below or make pull requests to our Github repository.

For further information on the TrinityCore project, please visit our project website at TrinityCore.org.

Requirements

Software requirements are available in the wiki for Windows, Linux and macOS.

Install

Detailed installation guides are available in the wiki for Windows, Linux and macOS.

Reporting issues

Issues can be reported via the Github issue tracker.

Please take the time to review existing issues before submitting your own to prevent duplicates.

In addition, thoroughly read through the issue tracker guide to ensure your report contains the required information. Incorrect or poorly formed reports are wasteful and are subject to deletion.

Submitting fixes

C++ fixes are submitted as pull requests via Github. For more information on how to properly submit a pull request, read the how-to: maintain a remote fork. For SQL only fixes open a ticket or if a bug report exists for the bug post on existing ticket.

License: GPL 2.0

Read file COPYING.

Authors & Contributors

Read file THANKS.

Description
Server emulator for World of Warcraft 3.3.5.12340 and other versions
Readme 10 GiB
Languages
C++ 89%
C 10.4%
CMake 0.4%