This PR solves the following say text issues: In quest ID 12733, Death's Challenge, the creature script npc_death_knight_initiate is supposed to target the player and refer to the player character's name in the following 2 lines from `creature_text`.`entry` 28406: - "You don't stand a chance, $n." (`BroadcastTextId` 29267) - "Remember this day, $n, for it is the day that you will be thoroughly owned." (`BroadcastTextId` 29270) In quest ID 12848, The Endless Hunger, the creature script npc_unworthy_initiate is supposed to target the player and refer to the player character's race in the following 2 lines from `creature_text`.`entry` 29519, 29520, 29565, 29566 and 29567: - "You are hopelessly outmatched, $r." (`BroadcastTextId` 30212) - "Sate your hunger on cold steel, $r!" (`BroadcastTextId` 30214) The untargeted variables $r and $n appear in the say lines because the existing script assigns the text to the player character instead of the creatures. This does not produce any race or name information in /say or chat. This Pull Request closes issue #14700 and replaces PR #15678.
TrinityCore
Build Status
| 6.x | 3.3.5 |
|---|---|
Introduction
TrinityCore is a MMORPG Framework based mostly in C++.
It is derived from MaNGOS, the Massive Network Game Object Server, and is based on the code of that project with extensive changes over time to optimize, improve and cleanup the codebase at the same time as improving the in-game mechanics and functionality.
It is completely open source; community involvement is highly encouraged.
If you wish to contribute ideas or code please visit our site linked below or make pull requests to our Github repository.
For further information on the TrinityCore project, please visit our project website at TrinityCore.org.
Requirements
- Platform: Linux, Windows or Mac
- Processor with SSE2 support
- Boost ≥ 1.49
- MySQL ≥ 5.1.0
- CMake ≥ 2.8.11.2 / 2.8.9 (Windows / Linux)
- OpenSSL ≥ 1.0.0
- GCC ≥ 4.7.2 (Linux only)
- MS Visual Studio ≥ 12 (2013) (Windows only)
Install
Detailed installation guides are available in the wiki for Windows, Linux and Mac OSX.
Reporting issues
Issues can be reported via the Github issue tracker.
Please take the time to review existing issues before submitting your own to prevent duplicates.
In addition, thoroughly read through the issue tracker guide to ensure your report contains the required information. Incorrect or poorly formed reports are wasteful and are subject to deletion.
Submitting fixes
Fixes are submitted as pull requests via Github. For more information on how to properly submit a pull request, read the how-to: maintain a remote fork.
Copyright
License: GPL 2.0
Read file COPYING
Authors & Contributors
Read file THANKS
Links
Documentation (powered by Doxygen)