aboutsummaryrefslogtreecommitdiff
path: root/.github
diff options
context:
space:
mode:
authorGiacomo Pozzoni <giacomopoz@gmail.com>2021-07-03 22:13:14 +0200
committerGitHub <noreply@github.com>2021-07-03 22:13:14 +0200
commit142306e883e7005d1d88379ab9c88f5fab46296b (patch)
tree721e004b243d935263a15cc8abdf2953d8c9c518 /.github
parent24636e5627e7d27ae71c11f6c03f78b6b6d61602 (diff)
CI/GitHub: Add issue form for SQL fixes (#26651)
Diffstat (limited to '.github')
-rw-r--r--.github/ISSUE_TEMPLATE/issue.yml2
-rw-r--r--.github/ISSUE_TEMPLATE/sql_fix.yml57
2 files changed, 58 insertions, 1 deletions
diff --git a/.github/ISSUE_TEMPLATE/issue.yml b/.github/ISSUE_TEMPLATE/issue.yml
index 2601348e990..468fddabe40 100644
--- a/.github/ISSUE_TEMPLATE/issue.yml
+++ b/.github/ISSUE_TEMPLATE/issue.yml
@@ -1,5 +1,5 @@
name: Generic issue
-description: Report an issue, a suggestion, SQL only fix.
+description: Report an issue or a suggestion.
body:
- type: markdown
attributes:
diff --git a/.github/ISSUE_TEMPLATE/sql_fix.yml b/.github/ISSUE_TEMPLATE/sql_fix.yml
new file mode 100644
index 00000000000..7112cec98bc
--- /dev/null
+++ b/.github/ISSUE_TEMPLATE/sql_fix.yml
@@ -0,0 +1,57 @@
+name: SQL fix
+description: Suggest a SQL only fix.
+labels: [Comp-Database, Feedback-PatchFix]
+body:
+ - type: markdown
+ attributes:
+ value: |
+ Thanks for taking the time to fill out this form! Please make sure to fill all fields, including the Title above.
+ For SQL fixes:
+ - search for existing issues, if a bug report exist for the issue you are trying to fix and it's opened post there.
+ - don't modify WDB fields without supply one sniff of those fields (censure guids, character names, anything blizzard can use to identify source)
+ - don't use pull requests for sql only fixes, unless it's to fix one existing unable to apply file.
+ - don't hardcode guids.
+ - don't DELETE + INSERT to update only few fields of one row.
+ - don't use database names.
+ - don't put ' around numbers.
+ - don't put ( ) if they aren't needed.
+ - use only 1 DELETE + INSERT when we add multiple items to one table, unless you are scripting multiple creatures.
+ - start fix by -- in case some previous sql misses proper ending.
+ - DELETE by guid AND entry to be sure we don't delete existing spawns.
+
+ The wiki page https://github.com/TrinityCore/TrinityCore/wiki/SQL-Fix includes additional details about how to fill this form and an example of a SQL fix.
+ - type: textarea
+ id: description
+ attributes:
+ label: Description
+ description: |
+ Description of what is getting fixed, including how to reproduce the issue if any.
+ validations:
+ required: true
+ - type: textarea
+ id: fix
+ attributes:
+ label: SQL fix
+ description: This field will be formatted automatically as SQL code block, no need to include \`\`\`sql
+ placeholder: |
+ --
+ render: sql
+ validations:
+ required: true
+ - type: dropdown
+ id: branch
+ attributes:
+ label: Branch
+ options:
+ - 3.3.5
+ - master
+ validations:
+ required: true
+ - type: textarea
+ id: commit
+ attributes:
+ label: TC rev. hash/commit
+ description: |
+ Copy the result of server debug command (if you need to run it from client get prat addon)
+ validations:
+ required: true