diff options
author | Shauren <shauren.trinity@gmail.com> | 2025-05-15 16:38:31 +0200 |
---|---|---|
committer | Shauren <shauren.trinity@gmail.com> | 2025-05-15 16:38:31 +0200 |
commit | 150c9cce5d62030c1adb4640469f6bd5831b2103 (patch) | |
tree | d86d18774c9593b6b4a1bbd07d4ca5545f7f41fa | |
parent | d723d0b9b27fcab0738202b253e4d6fe1602ccb1 (diff) |
Core/PacketIO: Fixed WorldPackets::SizedCString read function (it should not attempt to read null terminator if empty)
-rw-r--r-- | src/server/game/Server/Packets/PacketUtilities.h | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/src/server/game/Server/Packets/PacketUtilities.h b/src/server/game/Server/Packets/PacketUtilities.h index 678d6aba977..e865ec40061 100644 --- a/src/server/game/Server/Packets/PacketUtilities.h +++ b/src/server/game/Server/Packets/PacketUtilities.h @@ -561,8 +561,11 @@ namespace WorldPackets { friend inline ByteBuffer& operator>>(ByteBuffer& data, DataReaderWriter const& string) { - const_cast<Container&>(string.Value) = data.ReadString(string.Value.length()); - data.read_skip<char>(); // null terminator + if (!string.Value.empty()) + { + const_cast<Container&>(string.Value) = data.ReadString(string.Value.length()); + (void)data.read<char>(); // null terminator + } return data; } }; |