diff options
| author | Peter Keresztes Schmidt <carbenium@outlook.com> | 2021-07-03 12:08:30 +0200 |
|---|---|---|
| committer | Shauren <shauren.trinity@gmail.com> | 2022-03-11 14:33:57 +0100 |
| commit | 28a7ca9183e01dad57f311649eb1fcadc84a3561 (patch) | |
| tree | 49fa4b23cfb764e878a90ab70c75bffc1f138db5 | |
| parent | 161bba72f092682b15f9adaff47a8a751796e66b (diff) | |
Scripts/SholazarBasin: Fix a possible nullptr dereference issue found by coverity (#26648)
(cherry picked from commit 3bcda5acf4564b662db4dfde0af7279f99a93b79)
| -rw-r--r-- | src/server/scripts/Northrend/zone_sholazar_basin.cpp | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/src/server/scripts/Northrend/zone_sholazar_basin.cpp b/src/server/scripts/Northrend/zone_sholazar_basin.cpp index 70c5d0ec729..bfbe806410a 100644 --- a/src/server/scripts/Northrend/zone_sholazar_basin.cpp +++ b/src/server/scripts/Northrend/zone_sholazar_basin.cpp @@ -130,7 +130,10 @@ class spell_q12688_detonate_1 : public SpellScript target->GetMap()->SpawnGroupSpawn(SPAWN_GROUP_FLAMES, false, false, &flames); target->GetMap()->SetSpawnGroupInactive(SPAWN_GROUP_FLAMES); for (WorldObject* flame : flames) - dynamic_cast<GameObject*>(flame)->DespawnOrUnsummon(20s); + { + if (GameObject* flame_go = flame->ToGameObject()) + flame_go->DespawnOrUnsummon(20s); + } } } @@ -168,7 +171,10 @@ class spell_q12688_detonate_2 : public SpellScript target->GetMap()->SpawnGroupSpawn(SPAWN_GROUP_FLAMES, false, false, &flames); target->GetMap()->SetSpawnGroupInactive(SPAWN_GROUP_FLAMES); for (WorldObject* flame : flames) - dynamic_cast<GameObject*>(flame)->DespawnOrUnsummon(20s); + { + if (GameObject* flame_go = flame->ToGameObject()) + flame_go->DespawnOrUnsummon(20s); + } } } |