diff options
| author | Peter Keresztes Schmidt <carbenium@outlook.com> | 2021-07-03 12:08:30 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-07-03 12:08:30 +0200 |
| commit | 3bcda5acf4564b662db4dfde0af7279f99a93b79 (patch) | |
| tree | 3cf1b450d6e63155fe2c5f32c77cb9684601376f | |
| parent | f157d16e2f39c00e571a01326fa47e3844e08af2 (diff) | |
Scripts/SholazarBasin: Fix a possible nullptr dereference issue found by coverity (#26648)
| -rw-r--r-- | src/server/scripts/Northrend/zone_sholazar_basin.cpp | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/src/server/scripts/Northrend/zone_sholazar_basin.cpp b/src/server/scripts/Northrend/zone_sholazar_basin.cpp index 723dd0d75de..941832c59bb 100644 --- a/src/server/scripts/Northrend/zone_sholazar_basin.cpp +++ b/src/server/scripts/Northrend/zone_sholazar_basin.cpp @@ -130,7 +130,10 @@ class spell_q12688_detonate_1 : public SpellScript target->GetMap()->SpawnGroupSpawn(SPAWN_GROUP_FLAMES, false, false, &flames); target->GetMap()->SetSpawnGroupInactive(SPAWN_GROUP_FLAMES); for (WorldObject* flame : flames) - dynamic_cast<GameObject*>(flame)->DespawnOrUnsummon(20s); + { + if (GameObject* flame_go = flame->ToGameObject()) + flame_go->DespawnOrUnsummon(20s); + } } } @@ -168,7 +171,10 @@ class spell_q12688_detonate_2 : public SpellScript target->GetMap()->SpawnGroupSpawn(SPAWN_GROUP_FLAMES, false, false, &flames); target->GetMap()->SetSpawnGroupInactive(SPAWN_GROUP_FLAMES); for (WorldObject* flame : flames) - dynamic_cast<GameObject*>(flame)->DespawnOrUnsummon(20s); + { + if (GameObject* flame_go = flame->ToGameObject()) + flame_go->DespawnOrUnsummon(20s); + } } } |