aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorjackpoz <giacomopoz@gmail.com>2019-02-05 21:10:39 +0100
committerShauren <shauren.trinity@gmail.com>2021-11-23 22:20:39 +0100
commit3ddbf02dc7b10cedf8c4c8b6998e547486a3b757 (patch)
tree60d33ebcb8de76b1a73cfbd8ba286fabba9fb920
parent9807f32334cd9318c911712121821e14aba5acd9 (diff)
Core/Misc: Fix issues reported by static analysis
Fix issues reported by Coverity Scan (cherry picked from commit 2fda1572d214d0b114e0291106363f49c2d3179e)
-rw-r--r--src/server/game/Maps/Map.h2
-rw-r--r--src/server/game/Movement/Spline/Spline.h2
-rw-r--r--src/server/scripts/Commands/cs_go.cpp2
-rw-r--r--src/server/scripts/Northrend/Ulduar/Ulduar/boss_algalon_the_observer.cpp2
-rw-r--r--src/server/scripts/Northrend/Ulduar/Ulduar/boss_xt002.cpp2
5 files changed, 5 insertions, 5 deletions
diff --git a/src/server/game/Maps/Map.h b/src/server/game/Maps/Map.h
index 88da98bcdb0..d4e0452a400 100644
--- a/src/server/game/Maps/Map.h
+++ b/src/server/game/Maps/Map.h
@@ -113,7 +113,7 @@ struct PositionFullTerrainStatus
uint32 const mogpFlags;
};
- PositionFullTerrainStatus() : areaId(0), floorZ(0.0f), outdoors(true) { }
+ PositionFullTerrainStatus() : areaId(0), floorZ(0.0f), outdoors(true), liquidStatus(LIQUID_MAP_NO_WATER) { }
uint32 areaId;
float floorZ;
bool outdoors;
diff --git a/src/server/game/Movement/Spline/Spline.h b/src/server/game/Movement/Spline/Spline.h
index 5681b990c2b..f45c04551a2 100644
--- a/src/server/game/Movement/Spline/Spline.h
+++ b/src/server/game/Movement/Spline/Spline.h
@@ -90,7 +90,7 @@ protected:
public:
- explicit SplineBase() : index_lo(0), index_hi(0), m_mode(UninitializedMode), cyclic(false) { }
+ explicit SplineBase() : index_lo(0), index_hi(0), m_mode(UninitializedMode), cyclic(false), initialOrientation(0.f) { }
/** Caclulates the position for given segment Idx, and percent of segment length t
@param t - percent of segment length, assumes that t in range [0, 1]
diff --git a/src/server/scripts/Commands/cs_go.cpp b/src/server/scripts/Commands/cs_go.cpp
index dfa7d76b433..edf75078b8a 100644
--- a/src/server/scripts/Commands/cs_go.cpp
+++ b/src/server/scripts/Commands/cs_go.cpp
@@ -533,7 +533,7 @@ public:
return true;
}
- handler->PSendSysMessage(LANG_COMMAND_GO_INSTANCE_FAILED, mapid, scriptname.c_str(), exit->target_mapId);
+ handler->PSendSysMessage(LANG_COMMAND_GO_INSTANCE_FAILED, mapid, scriptname.c_str(), exit ? exit->target_mapId : uint32(-1));
handler->SetSentErrorMessage(true);
return false;
}
diff --git a/src/server/scripts/Northrend/Ulduar/Ulduar/boss_algalon_the_observer.cpp b/src/server/scripts/Northrend/Ulduar/Ulduar/boss_algalon_the_observer.cpp
index 4f866278672..a6949a8a291 100644
--- a/src/server/scripts/Northrend/Ulduar/Ulduar/boss_algalon_the_observer.cpp
+++ b/src/server/scripts/Northrend/Ulduar/Ulduar/boss_algalon_the_observer.cpp
@@ -1159,7 +1159,7 @@ class spell_algalon_big_bang : public SpellScript
AfterCast += SpellCastFn(spell_algalon_big_bang::CheckTargets);
}
private:
- uint32 _targetCount;
+ uint32 _targetCount = 0;
};
// 64445 - Remove Player from Phase
diff --git a/src/server/scripts/Northrend/Ulduar/Ulduar/boss_xt002.cpp b/src/server/scripts/Northrend/Ulduar/Ulduar/boss_xt002.cpp
index cc0b6d6e3bb..ac4ba17dc91 100644
--- a/src/server/scripts/Northrend/Ulduar/Ulduar/boss_xt002.cpp
+++ b/src/server/scripts/Northrend/Ulduar/Ulduar/boss_xt002.cpp
@@ -955,7 +955,7 @@ class spell_xt002_exposed_heart : public AuraScript
}
private:
- uint32 _damageAmount;
+ uint32 _damageAmount = 0;
};
class achievement_nerf_engineering : public AchievementCriteriaScript