diff options
| author | Shauren <shauren.trinity@gmail.com> | 2021-03-27 00:25:50 +0100 |
|---|---|---|
| committer | Shauren <shauren.trinity@gmail.com> | 2021-03-27 00:25:50 +0100 |
| commit | 3f479399695ce4aed7f508be46cfdccfd4353eee (patch) | |
| tree | 1f002d93373411fc70f450b7b968c9b313e226ae | |
| parent | f8255b15419cd1efdd2ccaf77298c8598322288f (diff) | |
Core/Auras: Corrected logic used to determine if a spellmod should affect another spell, empty family name or class mask should not apply to any spell
| -rw-r--r-- | src/server/game/Spells/SpellInfo.cpp | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/server/game/Spells/SpellInfo.cpp b/src/server/game/Spells/SpellInfo.cpp index 0a73ed4ad1f..64652d6474b 100644 --- a/src/server/game/Spells/SpellInfo.cpp +++ b/src/server/game/Spells/SpellInfo.cpp @@ -1754,7 +1754,9 @@ bool SpellInfo::IsAffectedBySpellMod(SpellModifier const* mod) const if (!affectSpell) return false; - return IsAffected(affectSpell->SpellFamilyName, mod->mask); + // TEMP: dont use IsAffected - !familyName and !familyFlags are not valid options for spell mods + // TODO: investigate if the !familyName and !familyFlags conditions are even valid for all other (nonmod) uses of SpellInfo::IsAffected + return affectSpell->SpellFamilyName == SpellFamilyName && mod->mask & SpellFamilyFlags; } bool SpellInfo::CanPierceImmuneAura(SpellInfo const* auraSpellInfo) const |