aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorShauren <shauren.trinity@gmail.com>2025-01-13 15:02:07 +0100
committerShauren <shauren.trinity@gmail.com>2025-01-13 15:02:07 +0100
commit4bec94451fb239a4e2007413b5691ed19fea6981 (patch)
tree8109be1ce296e9fc69b84bb9cc3939257c557d77
parentae1f80c083b4352bf381c12f066eef7fe0ddc125 (diff)
Core/Spells: DynamicObject auras will now use the largest radius found in SPELL_EFFECT_PERSISTENT_AREA_AURA effects of the spell creating them
-rw-r--r--src/server/game/Spells/SpellEffects.cpp16
1 files changed, 11 insertions, 5 deletions
diff --git a/src/server/game/Spells/SpellEffects.cpp b/src/server/game/Spells/SpellEffects.cpp
index c0b852872e3..58098c7f1a7 100644
--- a/src/server/game/Spells/SpellEffects.cpp
+++ b/src/server/game/Spells/SpellEffects.cpp
@@ -1566,6 +1566,10 @@ void Spell::EffectPersistentAA()
if (!unitCaster)
return;
+ // Caster not in world, might be spell triggered from aura removal
+ if (!unitCaster->IsInWorld())
+ return;
+
// only handle at last effect
for (size_t i = effectInfo->EffectIndex + 1; i < m_spellInfo->GetEffects().size(); ++i)
if (m_spellInfo->GetEffect(SpellEffIndex(i)).IsEffect(SPELL_EFFECT_PERSISTENT_AREA_AURA))
@@ -1573,11 +1577,13 @@ void Spell::EffectPersistentAA()
ASSERT(!_dynObjAura);
- float radius = effectInfo->CalcRadius(unitCaster);
-
- // Caster not in world, might be spell triggered from aura removal
- if (!unitCaster->IsInWorld())
- return;
+ float radius = 0.0f;
+ for (size_t i = 0; i <= effectInfo->EffectIndex; ++i)
+ {
+ SpellEffectInfo const& spellEffectInfo = m_spellInfo->GetEffect(SpellEffIndex(i));
+ if (spellEffectInfo.IsEffect(SPELL_EFFECT_PERSISTENT_AREA_AURA))
+ radius = std::max(radius, spellEffectInfo.CalcRadius(unitCaster));
+ }
DynamicObject* dynObj = new DynamicObject(false);
if (!dynObj->CreateDynamicObject(unitCaster->GetMap()->GenerateLowGuid<HighGuid::DynamicObject>(), unitCaster, m_spellInfo->Id, *destTarget, radius, DYNAMIC_OBJECT_AREA_SPELL))