aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGhaster <theghaster1@gmail.com>2022-08-06 15:08:42 +0200
committerGitHub <noreply@github.com>2022-08-06 15:08:42 +0200
commit55d0adf15e310e95576fdc4ec406ec154c23ffbb (patch)
treeefe0ffb3e0a9163470fd6c34bb9cade9093584bc
parent240ff8314a8ed8c129a53a5208feeb1a25d514e1 (diff)
Core/Players: Prevent sending QuestUpdateAddCredit on QUEST_OBJECTIVE_ITEM (#28170)
-rw-r--r--src/server/game/Entities/Player/Player.cpp15
1 files changed, 11 insertions, 4 deletions
diff --git a/src/server/game/Entities/Player/Player.cpp b/src/server/game/Entities/Player/Player.cpp
index 39ca623c91e..1dab0e4b99c 100644
--- a/src/server/game/Entities/Player/Player.cpp
+++ b/src/server/game/Entities/Player/Player.cpp
@@ -16474,10 +16474,17 @@ void Player::UpdateQuestObjectiveProgress(QuestObjectiveType objectiveType, int3
SetQuestObjectiveData(objective, newProgress);
if (addCount > 0 && !(objective.Flags & QUEST_OBJECTIVE_FLAG_HIDE_CREDIT_MSG))
{
- if (objectiveType != QUEST_OBJECTIVE_PLAYERKILLS)
- SendQuestUpdateAddCredit(quest, victimGuid, objective, newProgress);
- else
- SendQuestUpdateAddPlayer(quest, newProgress);
+ switch (objectiveType)
+ {
+ case QUEST_OBJECTIVE_ITEM:
+ break; // case handled by SMSG_ITEM_PUSH_RESULT
+ case QUEST_OBJECTIVE_PLAYERKILLS:
+ SendQuestUpdateAddPlayer(quest, newProgress);
+ break;
+ default:
+ SendQuestUpdateAddCredit(quest, victimGuid, objective, newProgress);
+ break;
+ }
}
objectiveIsNowComplete = IsQuestObjectiveComplete(logSlot, quest, objective);