diff options
| author | ihm-tswow <76849026+ihm-tswow@users.noreply.github.com> | 2022-08-19 11:14:07 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-08-19 11:14:07 +0200 |
| commit | 6e37438e5dadd30dc2ce36e468045e0be4d26c83 (patch) | |
| tree | 922db2ec75b198f3dc44d3571d3d319e4fcbe3c0 | |
| parent | c04fe4974b9403f555d0d405aa4d3f4f1f02eb65 (diff) | |
Core/Debugging: Improve SymInitialize fail message (#28206)
* clarify that this is not the crash error, but an error with the crash report itself
* improve formatting and message boundaries
* warn the reader that this means the call stack symbols may be inaccurate
| -rw-r--r-- | src/common/Debugging/WheatyExceptionReport.cpp | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/src/common/Debugging/WheatyExceptionReport.cpp b/src/common/Debugging/WheatyExceptionReport.cpp index e140b0bf805..52bfe739a2d 100644 --- a/src/common/Debugging/WheatyExceptionReport.cpp +++ b/src/common/Debugging/WheatyExceptionReport.cpp @@ -713,8 +713,13 @@ PEXCEPTION_POINTERS pExceptionInfo) // Initialize DbgHelp if (!SymInitialize(GetCurrentProcess(), nullptr, TRUE)) { - Log(_T("\n\rCRITICAL ERROR.\n\r Couldn't initialize the symbol handler for process.\n\rError [%s].\n\r\n\r"), - ErrorMessage(GetLastError())); + Log(_T("\r\n")); + Log(_T("----\r\n")); + Log(_T("SYMBOL HANDLER ERROR (THIS IS NOT THE CRASH ERROR)\r\n\r\n")); + Log(_T("Couldn't initialize symbol handler for process when generating crash report\r\n")); + Log(_T("Error: %s\r\n"), ErrorMessage(GetLastError())); + Log(_T("THE BELOW CALL STACKS MIGHT HAVE MISSING OR INACCURATE FILE/FUNCTION NAMES\r\n\r\n")); + Log(_T("----\r\n")); } if (pExceptionRecord->ExceptionCode == 0xE06D7363 && pExceptionRecord->NumberParameters >= 2) |