diff options
| author | tkrokli <tkrokli@users.noreply.github.com> | 2016-10-28 15:49:00 +0200 |
|---|---|---|
| committer | Duarte Duarte <dnpd.dd@gmail.com> | 2016-10-28 14:49:00 +0100 |
| commit | 76910541cf0befd88c25dc2430580b30626591ac (patch) | |
| tree | 4e84ca43ab207ab9b3469b18b75806aad07404ae | |
| parent | 08d7f094a93b6427ba3f093e368f73de8e8683a4 (diff) | |
pull_request_template.md improvements (#18158)
* pull_request_template.md improvements
- hide bottom comments from saved view on github.com
- add 1 empty comment line for some sections (suggest where to write)
- add tick boxes for the branch names
- "TODO" -> ToDo (from the 2 words "to do")
* Update pull_request_template.md
| -rw-r--r-- | pull_request_template.md | 24 |
1 files changed, 14 insertions, 10 deletions
diff --git a/pull_request_template.md b/pull_request_template.md index fde2c1b4b47..3dbf695e21e 100644 --- a/pull_request_template.md +++ b/pull_request_template.md @@ -1,6 +1,6 @@ -[//]: # (*********************************) -[//]: # (** DO NOT DELETE THIS TEMPLATE **) -[//]: # (*********************************) +[//]: # (***************************) +[//]: # (** FILL IN THIS TEMPLATE **) +[//]: # (***************************) **Changes proposed:** @@ -10,17 +10,21 @@ **Target branch(es):** 3.3.5/master -**Issues addressed:** Closes # +- [ ] 3.3.5 +- [ ] master + +**Issues addressed:** Closes # (insert issue tracker number) + **Tests performed:** (Does it build, tested in-game, etc.) -**Known issues and TODO list:** + +**Known issues and TODO list:** (add/remove lines as needed) - [ ] - [ ] -**DEPRECATION NOTICE** When creating new PRs to the (old) 6.x branch, make sure the target branch is **master** instead of 6.x. -**NOTE** Enable the setting "Allow edits from maintainers." when creating your pull request. -**NOTE** If this PR __only__ contains SQL files, create an issue instead. -**NOTE** Squashing commits is not required. -**SUGGESTION** When adding new SQL files, name them 9999_99_99_99_db_name.sql to reduce the chance of possible merge conflicts. +[//]: # (**DEPRECATION NOTICE** Instead of creating new PRs to the (old) 6.x branch, make sure the target branch is **master** instead of 6.x.) +[//]: # (**NOTE** Enable the setting "[√] Allow edits from maintainers." when creating your pull request (if not enabled already).) +[//]: # (**NOTE** If this PR __only__ contains SQL files, open a new issue instead and post or link the SQL there.) +[//]: # (**SUGGESTION** When adding new SQL files, name them 9999_99_99_99_db_name.sql to reduce the chance of possible merge conflicts.) |