diff options
| author | jackpoz <giacomopoz@gmail.com> | 2017-02-11 21:01:11 +0100 |
|---|---|---|
| committer | jackpoz <giacomopoz@gmail.com> | 2017-02-11 21:01:11 +0100 |
| commit | 865a3a47eaa518cb9c7827e863d679697e38b03e (patch) | |
| tree | 589bb6cbcc415dd330642bbc1ed847d2241e4977 | |
| parent | e865e5cf8e66577e1bbabddba126a6bcbe5120ab (diff) | |
Core/Misc: Fix static analysis issues
| -rw-r--r-- | src/common/Collision/Models/WorldModel.h | 2 | ||||
| -rw-r--r-- | src/server/game/Handlers/MailHandler.cpp | 7 | ||||
| -rw-r--r-- | src/server/scripts/Northrend/UtgardeKeep/UtgardePinnacle/boss_palehoof.cpp | 2 |
3 files changed, 3 insertions, 8 deletions
diff --git a/src/common/Collision/Models/WorldModel.h b/src/common/Collision/Models/WorldModel.h index 59f0b74f31d..df472708209 100644 --- a/src/common/Collision/Models/WorldModel.h +++ b/src/common/Collision/Models/WorldModel.h @@ -107,7 +107,7 @@ namespace VMAP class TC_COMMON_API WorldModel { public: - WorldModel(): RootWMOID(0) { } + WorldModel(): Flags(0), RootWMOID(0) { } //! pass group models to WorldModel and create BIH. Passed vector is swapped with old geometry! void setGroupModels(std::vector<GroupModel> &models); diff --git a/src/server/game/Handlers/MailHandler.cpp b/src/server/game/Handlers/MailHandler.cpp index 91c3cf01449..1b186ae6c0a 100644 --- a/src/server/game/Handlers/MailHandler.cpp +++ b/src/server/game/Handlers/MailHandler.cpp @@ -739,12 +739,7 @@ void WorldSession::HandleMailCreateTextItem(WorldPacket& recvData) if (m->mailTemplateId) { MailTemplateEntry const* mailTemplateEntry = sMailTemplateStore.LookupEntry(m->mailTemplateId); - if (!mailTemplateEntry) - { - player->SendMailResult(mailId, MAIL_MADE_PERMANENT, MAIL_ERR_INTERNAL_ERROR); - return; - } - + ASSERT(mailTemplateEntry); bodyItem->SetText(mailTemplateEntry->content[GetSessionDbcLocale()]); } else diff --git a/src/server/scripts/Northrend/UtgardeKeep/UtgardePinnacle/boss_palehoof.cpp b/src/server/scripts/Northrend/UtgardeKeep/UtgardePinnacle/boss_palehoof.cpp index b559048d876..d39608cb53f 100644 --- a/src/server/scripts/Northrend/UtgardeKeep/UtgardePinnacle/boss_palehoof.cpp +++ b/src/server/scripts/Northrend/UtgardeKeep/UtgardePinnacle/boss_palehoof.cpp @@ -190,7 +190,7 @@ public: struct boss_palehoofAI : public BossAI { - boss_palehoofAI(Creature* creature) : BossAI(creature, DATA_GORTOK_PALEHOOF), _dungeonMode(DUNGEON_MODE(2, 4)) { } + boss_palehoofAI(Creature* creature) : BossAI(creature, DATA_GORTOK_PALEHOOF), _dungeonMode(DUNGEON_MODE(2, 4)), _encountersCount(0) { } void Reset() override { |