aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorariel- <ariel-@users.noreply.github.com>2016-10-07 12:52:01 -0300
committerjoschiwald <joschiwald.trinity@gmail.com>2017-08-26 23:49:15 +0200
commitb362788754e74c577e79ba374a9ee9cc87a1b864 (patch)
tree55fad65bd8847dc33b14c971030e16f08ea4e290
parente24976f813a65a7298dae19227411a027ea84254 (diff)
Core/Auras: prevent stack overflow while processing SPELL_EFFECT_ADD_EXTRA_ATTACKS
(cherry picked from commit b93ee312fac22bf4828dc1afece644e3bd93cb84)
-rw-r--r--src/server/game/Spells/Auras/SpellAuraEffects.cpp10
1 files changed, 10 insertions, 0 deletions
diff --git a/src/server/game/Spells/Auras/SpellAuraEffects.cpp b/src/server/game/Spells/Auras/SpellAuraEffects.cpp
index 0c12b28a5af..19bc046ce87 100644
--- a/src/server/game/Spells/Auras/SpellAuraEffects.cpp
+++ b/src/server/game/Spells/Auras/SpellAuraEffects.cpp
@@ -1224,6 +1224,16 @@ bool AuraEffect::CheckEffectProc(AuraApplication* aurApp, ProcEventInfo& eventIn
if (!spellInfo || !(spellInfo->GetSchoolMask() & GetMiscValue()))
result = false;
break;
+ case SPELL_AURA_PROC_TRIGGER_SPELL:
+ case SPELL_AURA_PROC_TRIGGER_SPELL_WITH_VALUE:
+ {
+ // Don't proc extra attacks while already processing extra attack spell
+ uint32 triggerSpellId = GetSpellInfo()->Effects[GetEffIndex()].TriggerSpell;
+ if (SpellInfo const* triggeredSpellInfo = sSpellMgr->GetSpellInfo(triggerSpellId))
+ if (aurApp->GetTarget()->m_extraAttacks && triggeredSpellInfo->HasEffect(SPELL_EFFECT_ADD_EXTRA_ATTACKS))
+ result = false;
+ break;
+ }
default:
break;
}