diff options
| author | Giacomo Pozzoni <giacomopoz@gmail.com> | 2020-10-25 10:31:29 +0100 |
|---|---|---|
| committer | Shauren <shauren.trinity@gmail.com> | 2022-02-28 23:13:59 +0100 |
| commit | b7a31241562089eb8df7f5243e26d5e9c23ba4de (patch) | |
| tree | 65e0c23097ee4ea40b9d3e59fe1b0924ab5cf41a | |
| parent | 2134546253b007dad872efd429e1ce96c85f3796 (diff) | |
CI/GitHub: Switch to GCC 8 (#25610)
* CI/GitHub: Switch to GCC 8
Build on GitHub Actions using GCC 8 as it's the oldest supported GCC
* Core/Misc: Attempt to fix GCC 8 build
(cherry picked from commit d7459cccedc7ca9ba85e209dfeef61969fc78d9a)
| -rw-r--r-- | .github/workflows/gcc-build.yml | 1 | ||||
| -rw-r--r-- | src/server/game/Chat/ChatCommands/ChatCommandTags.h | 2 |
2 files changed, 2 insertions, 1 deletions
diff --git a/.github/workflows/gcc-build.yml b/.github/workflows/gcc-build.yml index d699e0088b3..f9050a14be0 100644 --- a/.github/workflows/gcc-build.yml +++ b/.github/workflows/gcc-build.yml @@ -12,6 +12,7 @@ jobs: - name: Dependencies run: | sudo apt-get update && sudo apt-get install -yq libboost-all-dev + sudo update-alternatives --install /usr/bin/gcc gcc /usr/bin/gcc-8 100 --slave /usr/bin/g++ g++ /usr/bin/g++-8 - name: Setup run: | mkdir bin diff --git a/src/server/game/Chat/ChatCommands/ChatCommandTags.h b/src/server/game/Chat/ChatCommands/ChatCommandTags.h index eae2d3a575a..b72d2d60465 100644 --- a/src/server/game/Chat/ChatCommands/ChatCommandTags.h +++ b/src/server/game/Chat/ChatCommands/ChatCommandTags.h @@ -106,7 +106,7 @@ namespace Trinity::ChatCommands private: static constexpr std::array<char, sizeof...(chars)> _storage = { chars... }; static_assert(!_storage.empty() && (_storage.back() == '\0'), "ExactSequence parameters must be null terminated! Use the EXACT_SEQUENCE macro to make this easier!"); - static constexpr std::string_view _string = { _storage.data() }; + static constexpr std::string_view _string = { _storage.data(), std::string_view::traits_type::length(_storage.data()) }; }; #define EXACT_SEQUENCE(str) Trinity::ChatCommands::ExactSequence<CHATCOMMANDS_IMPL_SPLIT_LITERAL(str)> |