Core/Misc: Fix mac build

5 files changed, 23 insertions, 21 deletions

diff --git a/src/server/bnetserver/REST/LoginRESTService.cpp b/src/server/bnetserver/REST/LoginRESTService.cpp
index 2413ee7d90b..0833f5e73fd 100644
--- a/src/server/bnetserver/REST/LoginRESTService.cpp
+++ b/src/server/bnetserver/REST/LoginRESTService.cpp
@@ -553,7 +553,7 @@ void LoginRESTService::ResponseCodePlugin::Destroy(soap* s, soap_plugin* p)
     delete data;
 }
 
-int32 LoginRESTService::ResponseCodePlugin::ChangeResponse(soap* s, int32 originalResponse, size_t contentLength)
+int32 LoginRESTService::ResponseCodePlugin::ChangeResponse(soap* s, int32 originalResponse, uint64 contentLength)
 {
     ResponseCodePlugin* self = reinterpret_cast<ResponseCodePlugin*>(soap_lookup_plugin(s, PluginId));
     return self->fresponse(s, self->ErrorCode && originalResponse == SOAP_FILE ? self->ErrorCode : originalResponse, contentLength);
diff --git a/src/server/bnetserver/REST/LoginRESTService.h b/src/server/bnetserver/REST/LoginRESTService.h
index f36bfaa806f..e4d22dd9661 100644
--- a/src/server/bnetserver/REST/LoginRESTService.h
+++ b/src/server/bnetserver/REST/LoginRESTService.h
@@ -76,11 +76,11 @@ private:
         static int32 Init(soap* s, soap_plugin*, void*);
         static int32 Copy(soap* s, soap_plugin* dst, soap_plugin* src);
         static void Destroy(soap* s, soap_plugin* p);
-        static int32 ChangeResponse(soap* s, int32 originalResponse, size_t contentLength);
+        static int32 ChangeResponse(soap* s, int32 originalResponse, uint64 contentLength);
 
         static ResponseCodePlugin* GetForClient(soap* s);
 
-        int32(*fresponse)(soap* s, int32 status, size_t length);
+        int32(*fresponse)(soap* s, int32 status, uint64 length);
         int32 ErrorCode;
     };
 
diff --git a/src/server/scripts/Commands/cs_gobject.cpp b/src/server/scripts/Commands/cs_gobject.cpp
index a2d64bfcd77..36b25e92fef 100644
--- a/src/server/scripts/Commands/cs_gobject.cpp
+++ b/src/server/scripts/Commands/cs_gobject.cpp
@@ -87,7 +87,7 @@ public:
         GameObject* object = handler->GetObjectFromPlayerMapByDbGuid(guidLow);
         if (!object)
         {
-            handler->PSendSysMessage(LANG_COMMAND_OBJNOTFOUND, std::to_string(guidLow).c_str());
+            handler->PSendSysMessage(LANG_COMMAND_OBJNOTFOUND, std::to_string(*guidLow).c_str());
             handler->SetSentErrorMessage(true);
             return false;
         }
@@ -312,12 +312,12 @@ public:
 
         if (GameObject::DeleteFromDB(spawnId))
         {
-            handler->PSendSysMessage(LANG_COMMAND_DELOBJMESSAGE, std::to_string(spawnId).c_str());
+            handler->PSendSysMessage(LANG_COMMAND_DELOBJMESSAGE, std::to_string(*spawnId).c_str());
             return true;
         }
         else
         {
-            handler->PSendSysMessage(LANG_COMMAND_OBJNOTFOUND, std::to_string(spawnId).c_str());
+            handler->PSendSysMessage(LANG_COMMAND_OBJNOTFOUND, std::to_string(*spawnId).c_str());
             handler->SetSentErrorMessage(true);
             return false;
         }
@@ -332,7 +332,7 @@ public:
         GameObject* object = handler->GetObjectFromPlayerMapByDbGuid(guidLow);
         if (!object)
         {
-            handler->PSendSysMessage(LANG_COMMAND_OBJNOTFOUND, std::to_string(guidLow).c_str());
+            handler->PSendSysMessage(LANG_COMMAND_OBJNOTFOUND, std::to_string(*guidLow).c_str());
             handler->SetSentErrorMessage(true);
             return false;
         }
@@ -368,7 +368,7 @@ public:
         GameObject* object = handler->GetObjectFromPlayerMapByDbGuid(guidLow);
         if (!object)
         {
-            handler->PSendSysMessage(LANG_COMMAND_OBJNOTFOUND, std::to_string(guidLow).c_str());
+            handler->PSendSysMessage(LANG_COMMAND_OBJNOTFOUND, std::to_string(*guidLow).c_str());
             handler->SetSentErrorMessage(true);
             return false;
         }
@@ -422,7 +422,7 @@ public:
         GameObject* object = handler->GetObjectFromPlayerMapByDbGuid(guidLow);
         if (!object)
         {
-            handler->PSendSysMessage(LANG_COMMAND_OBJNOTFOUND, std::to_string(guidLow).c_str());
+            handler->PSendSysMessage(LANG_COMMAND_OBJNOTFOUND, std::to_string(*guidLow).c_str());
             handler->SetSentErrorMessage(true);
             return false;
         }
@@ -579,7 +579,7 @@ public:
         GameObject* object = handler->GetObjectFromPlayerMapByDbGuid(guidLow);
         if (!object)
         {
-            handler->PSendSysMessage(LANG_COMMAND_OBJNOTFOUND, std::to_string(guidLow).c_str());
+            handler->PSendSysMessage(LANG_COMMAND_OBJNOTFOUND, std::to_string(*guidLow).c_str());
             handler->SetSentErrorMessage(true);
             return false;
         }
diff --git a/src/server/scripts/Commands/cs_npc.cpp b/src/server/scripts/Commands/cs_npc.cpp
index 97ec8648d2e..e90ded28df5 100644
--- a/src/server/scripts/Commands/cs_npc.cpp
+++ b/src/server/scripts/Commands/cs_npc.cpp
@@ -217,7 +217,7 @@ public:
         CreatureData const* data = sObjectMgr->GetCreatureData(lowGuid);
         if (!data)
         {
-            handler->PSendSysMessage(LANG_COMMAND_CREATGUIDNOTFOUND, std::to_string(lowGuid).c_str());
+            handler->PSendSysMessage(LANG_COMMAND_CREATGUIDNOTFOUND, std::to_string(*lowGuid).c_str());
             handler->SetSentErrorMessage(true);
             return false;
         }
diff --git a/src/server/scripts/Events/fireworks_show.cpp b/src/server/scripts/Events/fireworks_show.cpp
index f055bebb89d..692e6c4defa 100644
--- a/src/server/scripts/Events/fireworks_show.cpp
+++ b/src/server/scripts/Events/fireworks_show.cpp
@@ -17,7 +17,6 @@
 
 #include "ScriptMgr.h"
 #include "Containers.h"
-#include "CreatureAIImpl.h"
 #include "EventMap.h"
 #include "GameEventMgr.h"
 #include "GameObject.h"
@@ -735,18 +734,20 @@ public:
 
         static uint32 CheerPicker()
         {
-            uint32 newid = RAND(
+            uint32 ids[] =
+            {
                 SOUND_CHEER_1,
                 SOUND_CHEER_2,
                 SOUND_CHEER_3,
                 SOUND_CHEER_4
-            );
-            return newid;
+            };
+            return Trinity::Containers::SelectRandomContainerElement(ids);
         }
 
         static uint32 FireworksPicker()
         {
-            uint32 newid = RAND(
+            uint32 ids[] =
+            {
                 FIREWORK_SHOW_TYPE_1_RED,
                 FIREWORK_SHOW_TYPE_2_RED,
                 FIREWORK_SHOW_TYPE_1_RED_BIG,
@@ -770,13 +771,14 @@ public:
                 FIREWORK_SHOW_TYPE_2_PURPLE,
                 FIREWORK_SHOW_TYPE_1_PURPLE_BIG,
                 FIREWORK_SHOW_TYPE_2_PURPLE_BIG
-            );
-            return newid;
+            };
+            return Trinity::Containers::SelectRandomContainerElement(ids);
         }
 
         static uint32 FireworksBIGOnlyPicker()
         {
-            uint32 newid = RAND(
+            uint32 ids[] =
+            {
                 FIREWORK_SHOW_TYPE_1_RED_BIG,
                 FIREWORK_SHOW_TYPE_2_RED_BIG,
                 FIREWORK_SHOW_TYPE_1_BLUE_BIG,
@@ -789,8 +791,8 @@ public:
                 FIREWORK_SHOW_TYPE_2_YELLOW_BIG,
                 FIREWORK_SHOW_TYPE_1_PURPLE_BIG,
                 FIREWORK_SHOW_TYPE_2_PURPLE_BIG
-            );
-            return newid;
+            };
+            return Trinity::Containers::SelectRandomContainerElement(ids);
         }
 
         void UpdateAI(uint32 diff) override