diff options
| author | ihm-tswow <76849026+ihm-tswow@users.noreply.github.com> | 2022-08-19 11:14:07 +0200 |
|---|---|---|
| committer | Shauren <shauren.trinity@gmail.com> | 2022-09-05 22:23:02 +0200 |
| commit | cec4cb0222d3825168f148cfc194b0f0ce93afb6 (patch) | |
| tree | 41725192a823da9a1ae1d670f72ea31aac356f36 | |
| parent | 8684af145d7ba73a0143d83532f661b36cfd2eae (diff) | |
Core/Debugging: Improve SymInitialize fail message (#28206)
* clarify that this is not the crash error, but an error with the crash report itself
* improve formatting and message boundaries
* warn the reader that this means the call stack symbols may be inaccurate
(cherry picked from commit 6e37438e5dadd30dc2ce36e468045e0be4d26c83)
| -rw-r--r-- | src/common/Debugging/WheatyExceptionReport.cpp | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/src/common/Debugging/WheatyExceptionReport.cpp b/src/common/Debugging/WheatyExceptionReport.cpp index ae2fb7e5ce1..852e38a2383 100644 --- a/src/common/Debugging/WheatyExceptionReport.cpp +++ b/src/common/Debugging/WheatyExceptionReport.cpp @@ -722,8 +722,13 @@ PEXCEPTION_POINTERS pExceptionInfo) // Initialize DbgHelp if (!SymInitialize(GetCurrentProcess(), nullptr, TRUE)) { - Log(_T("\n\rCRITICAL ERROR.\n\r Couldn't initialize the symbol handler for process.\n\rError [%s].\n\r\n\r"), - ErrorMessage(GetLastError())); + Log(_T("\r\n")); + Log(_T("----\r\n")); + Log(_T("SYMBOL HANDLER ERROR (THIS IS NOT THE CRASH ERROR)\r\n\r\n")); + Log(_T("Couldn't initialize symbol handler for process when generating crash report\r\n")); + Log(_T("Error: %s\r\n"), ErrorMessage(GetLastError())); + Log(_T("THE BELOW CALL STACKS MIGHT HAVE MISSING OR INACCURATE FILE/FUNCTION NAMES\r\n\r\n")); + Log(_T("----\r\n")); } if (pExceptionRecord->ExceptionCode == 0xE06D7363 && pExceptionRecord->NumberParameters >= 2) |