aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTreeston <treeston.mmoc@gmail.com>2017-07-09 13:58:59 +0200
committerGitHub <noreply@github.com>2017-07-09 13:58:59 +0200
commited241a2fd6c8fd419d350210aa61eb1ad05b27bb (patch)
treeed9d6cf475f11fa2eb194150b376ff41884a4588
parent9bacaf15b60dc455ae913062b05a5adb2b8bdcf9 (diff)
Prevent an issue that stopped Aura AfterEffect handlers being called on default handler prevention. (#20001)
Fixes #19996.
-rw-r--r--src/server/game/Spells/Auras/SpellAuraEffects.cpp10
1 files changed, 6 insertions, 4 deletions
diff --git a/src/server/game/Spells/Auras/SpellAuraEffects.cpp b/src/server/game/Spells/Auras/SpellAuraEffects.cpp
index a69ebe9212e..2d57d1472b4 100644
--- a/src/server/game/Spells/Auras/SpellAuraEffects.cpp
+++ b/src/server/game/Spells/Auras/SpellAuraEffects.cpp
@@ -665,13 +665,15 @@ void AuraEffect::HandleEffect(AuraApplication * aurApp, uint8 mode, bool apply)
else
prevented = GetBase()->CallScriptEffectRemoveHandlers(this, aurApp, (AuraEffectHandleModes)mode);
- // check if script events have removed the aura or if default effect prevention was requested
- if ((apply && aurApp->GetRemoveMode()) || prevented)
+ // check if script events have removed the aura already
+ if (apply && aurApp->GetRemoveMode())
return;
- (*this.*AuraEffectHandler[GetAuraType()])(aurApp, mode, apply);
+ // call default effect handler if it wasn't prevented
+ if (!prevented)
+ (*this.*AuraEffectHandler[GetAuraType()])(aurApp, mode, apply);
- // check if script events have removed the aura or if default effect prevention was requested
+ // check if the default handler reemoved the aura
if (apply && aurApp->GetRemoveMode())
return;