diff options
| author | jackpoz <giacomopoz@gmail.com> | 2013-08-25 14:04:17 +0100 |
|---|---|---|
| committer | Nay <dnpd.dd@gmail.com> | 2013-08-25 14:04:17 +0100 |
| commit | ee3d3ab1ff5589036c41c236e4fc376f11854467 (patch) | |
| tree | 5917ab28bc009ab954ff3a6679c8bd61c7c93586 | |
| parent | ba22baebbd1394cc69366d7a19d879da43885430 (diff) | |
Core/Player: Fix uninitialized Player field.
m_MonthlyQuestChanged was initialized only when loading a Player from DB and left uninitialized when creating a new Player.
Valgrind log:
Conditional jump or move depends on uninitialised value(s)
at 0x1148E2A: Player::_SaveMonthlyQuestStatus(Trinity::AutoPtr<Transaction, ACE_Thread_Mutex>&) (Player.cpp:19694)
by 0x1146510: Player::SaveToDB(bool) (Player.cpp:19191)
by 0x14F5D5C: WorldSession::HandleCharCreateCallback(Trinity::AutoPtr<PreparedResultSet, ACE_Thread_Mutex>, CharacterCreateInfo*) (CharacterHandler.cpp:660)
Closes #10620
Signed-off-by: Nay <dnpd.dd@gmail.com>
| -rw-r--r-- | src/server/game/Entities/Player/Player.cpp | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/server/game/Entities/Player/Player.cpp b/src/server/game/Entities/Player/Player.cpp index 8f3379ee254..d570ecb1117 100644 --- a/src/server/game/Entities/Player/Player.cpp +++ b/src/server/game/Entities/Player/Player.cpp @@ -864,6 +864,8 @@ Player::Player(WorldSession* session): Unit(true) m_WeeklyQuestChanged = false; + m_MonthlyQuestChanged = false; + m_SeasonalQuestChanged = false; SetPendingBind(0, 0); |