aboutsummaryrefslogtreecommitdiff
path: root/cmake
diff options
context:
space:
mode:
authorGiacomo Pozzoni <giacomopoz@gmail.com>2020-12-06 17:52:13 +0100
committerGitHub <noreply@github.com>2020-12-06 17:52:13 +0100
commita4e93d779c9638bc0a61cb4405ef28cb935d1065 (patch)
tree5ef8f6c87f056f6263fb5793b582af0f0e6f5e48 /cmake
parent0800055005d708520a9665b53a17264471e7401e (diff)
Improve multithreading of mmaps_generator (#25625)
* Build/Misc: Add a few *San CMake flags Add the following flags for the related tools: - MSAN for Memory Sanitizer - UBSAN for Undefined Behavior Sanitizer - TSAN for Thread Sanitizer * Remove unused parameter * Fix UBSan reported issue * Disable G3D buffer pools when using Thread Sanitizer as it has its custom locking mechanisms * Code cleanup * Move threads from maps to tiles * Move tile building logic to TileBuilder class * Fix memory leak in TileBuilder * Fix build * Store TileBuilder as raw pointer for now, it will be changed later on to use modern C++ constructs * Fix crash on shutdown * Revert pvs-studio change * Fix generating 1 single tile not closing the program
Diffstat (limited to 'cmake')
-rw-r--r--cmake/compiler/clang/settings.cmake48
-rw-r--r--cmake/showoptions.cmake21
2 files changed, 68 insertions, 1 deletions
diff --git a/cmake/compiler/clang/settings.cmake b/cmake/compiler/clang/settings.cmake
index 2bd16a57579..896dd0ef157 100644
--- a/cmake/compiler/clang/settings.cmake
+++ b/cmake/compiler/clang/settings.cmake
@@ -74,7 +74,53 @@ if(ASAN)
-fsanitize-recover=address
-fsanitize-address-use-after-scope)
- message(STATUS "Clang: Enabled Address Sanitizer")
+ message(STATUS "Clang: Enabled Address Sanitizer ASan")
+endif()
+
+if(MSAN)
+ target_compile_options(trinity-compile-option-interface
+ INTERFACE
+ -fno-omit-frame-pointer
+ -fsanitize=memory
+ -fsanitize-memory-track-origins
+ -mllvm
+ -msan-keep-going=1)
+
+ target_link_options(trinity-compile-option-interface
+ INTERFACE
+ -fno-omit-frame-pointer
+ -fsanitize=memory
+ -fsanitize-memory-track-origins)
+
+ message(STATUS "Clang: Enabled Memory Sanitizer MSan")
+endif()
+
+if(UBSAN)
+ target_compile_options(trinity-compile-option-interface
+ INTERFACE
+ -fno-omit-frame-pointer
+ -fsanitize=undefined)
+
+ target_link_options(trinity-compile-option-interface
+ INTERFACE
+ -fno-omit-frame-pointer
+ -fsanitize=undefined)
+
+ message(STATUS "Clang: Enabled Undefined Behavior Sanitizer UBSan")
+endif()
+
+if(TSAN)
+ target_compile_options(trinity-compile-option-interface
+ INTERFACE
+ -fno-omit-frame-pointer
+ -fsanitize=thread)
+
+ target_link_options(trinity-compile-option-interface
+ INTERFACE
+ -fno-omit-frame-pointer
+ -fsanitize=thread)
+
+ message(STATUS "Clang: Enabled Thread Sanitizer TSan")
endif()
# -Wno-narrowing needed to suppress a warning in g3d
diff --git a/cmake/showoptions.cmake b/cmake/showoptions.cmake
index f9bfa1f33fa..004e28e308e 100644
--- a/cmake/showoptions.cmake
+++ b/cmake/showoptions.cmake
@@ -122,6 +122,27 @@ if(ASAN)
add_definitions(-DASAN)
endif()
+if(MSAN)
+ message("")
+ message(" *** MSAN - WARNING!")
+ message(" *** Please note that this is for DEBUGGING WITH MEMORY SANITIZER only!")
+ add_definitions(-DMSAN)
+endif()
+
+if(UBSAN)
+ message("")
+ message(" *** UBSAN - WARNING!")
+ message(" *** Please note that this is for DEBUGGING WITH UNDEFINED BEHAVIOR SANITIZER only!")
+ add_definitions(-DUBSAN)
+endif()
+
+if(TSAN)
+ message("")
+ message(" *** TSAN - WARNING!")
+ message(" *** Please note that this is for DEBUGGING WITH THREAD SANITIZER only!")
+ add_definitions(-DTSAN -DNO_BUFFERPOOL)
+endif()
+
if(PERFORMANCE_PROFILING)
message("")
message(" *** PERFORMANCE_PROFILING - WARNING!")