diff options
author | Giacomo Pozzoni <giacomopoz@gmail.com> | 2020-07-28 12:27:54 +0000 |
---|---|---|
committer | Shauren <shauren.trinity@gmail.com> | 2022-01-24 13:02:38 +0100 |
commit | 835098597559f3bc1d5974e3376cd84875669fe9 (patch) | |
tree | fc41d7e8359e377b16eb53520e28f03f7a3eb5da /contrib | |
parent | c7899c1e76bc1c6f1277a4e8127288dc65ba3520 (diff) |
Core/Metric: Log detailed metrics about each opcode handler (#25153)
* Core/Metric: Log detailed metrics about each opcode handler
* Add new panel to Performance profiling dashboard and use fill(0) instead of fill(none)
* Add new settings Metric.Threshold.* to be able to specify the minimum threshold for the specified metrics
* Update dashboard
* Change thresholds to be required to send the metrics. A TC_METRIC_DETAILED_TIMER metric with an expected threshold not configured will be ignored
* Use typedef Milliseconds
* Refresh realms on load
(cherry picked from commit 8a2c79c850199a73fd431d04f83d6aa89733060d)
Diffstat (limited to 'contrib')
-rw-r--r-- | contrib/grafana/2_Maps.json | 6 | ||||
-rw-r--r-- | contrib/grafana/3_Network.json | 6 | ||||
-rw-r--r-- | contrib/grafana/4_Performance_profiling.json | 155 |
3 files changed, 156 insertions, 11 deletions
diff --git a/contrib/grafana/2_Maps.json b/contrib/grafana/2_Maps.json index c8efcdf56f8..aaad5d6e138 100644 --- a/contrib/grafana/2_Maps.json +++ b/contrib/grafana/2_Maps.json @@ -28,7 +28,7 @@ "gnetId": null, "graphTooltip": 0, "id": 6, - "iteration": 1592337831334, + "iteration": 1595939001794, "links": [], "panels": [ { @@ -643,7 +643,7 @@ "name": "realm", "options": [], "query": "show tag values from events with key = realm", - "refresh": true, + "refresh": 1, "regex": "", "skipUrlSync": false, "sort": 0, @@ -687,5 +687,5 @@ "timezone": "browser", "title": "Maps, vmaps and mmaps", "uid": "6IhqWiWGz", - "version": 1 + "version": 2 }
\ No newline at end of file diff --git a/contrib/grafana/3_Network.json b/contrib/grafana/3_Network.json index 4d26a179d8b..fd849a19d14 100644 --- a/contrib/grafana/3_Network.json +++ b/contrib/grafana/3_Network.json @@ -28,7 +28,7 @@ "gnetId": null, "graphTooltip": 0, "id": 7, - "iteration": 1592337929176, + "iteration": 1595939048589, "links": [], "panels": [ { @@ -232,7 +232,7 @@ "name": "realm", "options": [], "query": "show tag values from events with key = realm", - "refresh": true, + "refresh": 1, "regex": "", "skipUrlSync": false, "sort": 0, @@ -276,5 +276,5 @@ "timezone": "browser", "title": "Network", "uid": "_QtkMmWMk", - "version": 1 + "version": 2 }
\ No newline at end of file diff --git a/contrib/grafana/4_Performance_profiling.json b/contrib/grafana/4_Performance_profiling.json index cc04153e2a7..b16c2bf5d80 100644 --- a/contrib/grafana/4_Performance_profiling.json +++ b/contrib/grafana/4_Performance_profiling.json @@ -29,7 +29,7 @@ "gnetId": null, "graphTooltip": 0, "id": 15, - "iteration": 1595854392473, + "iteration": 1595882804610, "links": [], "panels": [ { @@ -246,7 +246,7 @@ }, { "params": [ - "none" + "0" ], "type": "fill" } @@ -297,7 +297,7 @@ }, { "params": [ - "none" + "0" ], "type": "fill" } @@ -440,7 +440,7 @@ }, { "params": [ - "none" + "0" ], "type": "fill" } @@ -1094,6 +1094,151 @@ "align": false, "alignLevel": null } + }, + { + "aliasColors": {}, + "bars": true, + "dashLength": 10, + "dashes": false, + "datasource": null, + "fieldConfig": { + "defaults": { + "custom": {} + }, + "overrides": [] + }, + "fill": 1, + "fillGradient": 0, + "gridPos": { + "h": 8, + "w": 12, + "x": 0, + "y": 31 + }, + "hiddenSeries": false, + "id": 11, + "legend": { + "alignAsTable": true, + "avg": false, + "current": false, + "hideEmpty": true, + "hideZero": true, + "max": true, + "min": false, + "rightSide": true, + "show": true, + "sort": "max", + "sortDesc": true, + "total": false, + "values": true + }, + "lines": false, + "linewidth": 2, + "nullPointMode": "null", + "options": { + "dataLinks": [] + }, + "percentage": false, + "pointradius": 2, + "points": true, + "renderer": "flot", + "seriesOverrides": [], + "spaceLength": 10, + "stack": false, + "steppedLine": false, + "targets": [ + { + "alias": "Opcode $tag_opcode", + "groupBy": [ + { + "params": [ + "$__interval" + ], + "type": "time" + }, + { + "params": [ + "opcode" + ], + "type": "tag" + }, + { + "params": [ + "null" + ], + "type": "fill" + } + ], + "measurement": "worldsession_update_opcode_time", + "orderByTime": "ASC", + "policy": "default", + "query": "SELECT max(\"value\") FROM \"worldsession_update_opcode_time\" WHERE (\"realm\" =~ /^$realm$/) AND $timeFilter GROUP BY time($__interval), \"opcode\" fill(null)", + "rawQuery": false, + "refId": "A", + "resultFormat": "time_series", + "select": [ + [ + { + "params": [ + "value" + ], + "type": "field" + }, + { + "params": [], + "type": "max" + } + ] + ], + "tags": [ + { + "key": "realm", + "operator": "=~", + "value": "/^$realm$/" + } + ] + } + ], + "thresholds": [], + "timeFrom": null, + "timeRegions": [], + "timeShift": null, + "title": "Opcode handlers - Split", + "tooltip": { + "shared": false, + "sort": 2, + "value_type": "individual" + }, + "type": "graph", + "xaxis": { + "buckets": null, + "mode": "time", + "name": null, + "show": true, + "values": [] + }, + "yaxes": [ + { + "format": "ms", + "label": null, + "logBase": 1, + "max": null, + "min": null, + "show": true + }, + { + "format": "short", + "label": null, + "logBase": 1, + "max": null, + "min": null, + "show": true + } + ], + "yaxis": { + "align": false, + "alignLevel": null + } } ], "refresh": "1m", @@ -1150,5 +1295,5 @@ "timezone": "", "title": "Performance profiling", "uid": "IRRL03nMk", - "version": 5 + "version": 6 }
\ No newline at end of file |