aboutsummaryrefslogtreecommitdiff
path: root/issue_template.md
diff options
context:
space:
mode:
authorAokromes <Aokromes@users.noreply.github.com>2019-06-26 09:43:35 +0200
committerGitHub <noreply@github.com>2019-06-26 09:43:35 +0200
commit3510c222209e8c04d65b2a165d3c02b626d1aa19 (patch)
treee3529e67b94bf1c04c8ef75839f7040bdeabc95f /issue_template.md
parentcd071ec570a8dc567b2a8f2a145f2623412e5d78 (diff)
Update issue_template.md
Diffstat (limited to 'issue_template.md')
-rw-r--r--issue_template.md15
1 files changed, 14 insertions, 1 deletions
diff --git a/issue_template.md b/issue_template.md
index 14b65c7296c..0fed4ea782c 100644
--- a/issue_template.md
+++ b/issue_template.md
@@ -1,6 +1,19 @@
<!--- (**********************************)
(** Fill in the following fields **)
- (**********************************) --->
+ (**********************************)
+ For SQL fixes:
+ don't modify WDB fields without supply one sniff of those fields (censure guids, character names, anything blizzard can use to identify source)
+ don't use pull requests for sql only fixes, unless it's to fix one existing unable to apply file.
+ don't hardcode guids.
+ don't DELETE + INSERT to update only few fields of one row.
+ don't use database names.
+ don't put ' around numbers.
+ don't put ( ) if they aren't needed.
+ use only 1 DELETE + INSERT when we add multiple items to one table, unless you are scripting multiple creatures.
+ put default values on every new column we want to add on that way we can make smallers inserts.
+ start fix by -- in case some previous sql misses proper ending.
+ DELETE by guid AND entry to be sure we don't delete existing spawns.
+ start sql code with 3 ` sql --->
**Description:**