Core/Authserver: Authserver cleanup (PR#25093)

- Fix a handful of 1/256 bugs with most significant byte zero in BigNumber
- Get rid of (most of) the C-style arrays in authserver
- CryptoRandom as a unified source for cryptographic randomness
- Bring our other crypto APIs into 2020
- BigNumber usability improvements
- Authserver is now actually readable as a result of all of the above

1 files changed, 2 insertions, 1 deletions

diff --git a/src/common/Cryptography/Argon2.cpp b/src/common/Cryptography/Argon2.cpp
index c3a2f07310b..225d92c3994 100644
--- a/src/common/Cryptography/Argon2.cpp
+++ b/src/common/Cryptography/Argon2.cpp
@@ -21,12 +21,13 @@
 /*static*/ Optional<std::string> Trinity::Crypto::Argon2::Hash(std::string const& password, BigNumber const& salt, uint32 nIterations, uint32 kibMemoryCost)
 {
     char buf[ENCODED_HASH_LEN];
+    std::vector<uint8> saltBytes = salt.ToByteVector();
     int status = argon2id_hash_encoded(
         nIterations,
         kibMemoryCost,
         PARALLELISM,
         password.c_str(), password.length(),
-        salt.AsByteArray().get(), salt.GetNumBytes(),
+        saltBytes.data(), saltBytes.size(),
         HASH_LEN, buf, ENCODED_HASH_LEN
     );