diff options
| author | Alan Deutscher <adeutscher@gmail.com> | 2020-04-16 11:21:01 -0700 |
|---|---|---|
| committer | Shauren <shauren.trinity@gmail.com> | 2022-01-01 16:29:06 +0100 |
| commit | 68e1dc8adb84a3df5241358be591400db39e4d62 (patch) | |
| tree | d1d6ce8c44bb167bd1adf8308f2d9d85251ae41f /src/common/GitRevision.cpp | |
| parent | d6931f392e4a5d11c7eeb8c415b5757a4381f03b (diff) | |
Core/Players: Improve trade exchange calculations (#24435)
* Add some comments to Player::CanStoreItems to help me wrap my head around how the method works.
* Experimental fix for incoming trade-stack problem.
* Only add to stacks that aren't already full.
* Use remaining_count instead of static 1.
* Remove debug logging from exploration.
* More uses of remaining_count for consistency.
* Correct space count check
* Correct overflow problem.
* Remove redundant check, handled in existing for statement.
* Store Item pointers in order to be able to merge in multiple incoming stacks.
* Build fix - was continually working locally, but failing in CI.
* Break build in order to keep PR focused on Player.cpp changes.
* Adjust phrasing of how arrays are initialized.
* Fix phrasing of comments to avoid sounding like a ToDo item
* In the spirit of b649273d5f, rephrase an old comment to be a statement rather than a question.
(cherry picked from commit e11a13c755fcc7912d54bd4732795e1d992aab0c)
Diffstat (limited to 'src/common/GitRevision.cpp')
0 files changed, 0 insertions, 0 deletions