[3.3.5] Core/ChatCommands: C++17 cleanup (if constexpr + std::string_view)

1 files changed, 6 insertions, 2 deletions

diff --git a/src/common/Utilities/Util.cpp b/src/common/Utilities/Util.cpp
index da086c6b6cc..cb70cc114d3 100644
--- a/src/common/Utilities/Util.cpp
+++ b/src/common/Utilities/Util.cpp
@@ -651,9 +651,13 @@ void Trinity::Impl::HexStrToByteArray(std::string_view str, uint8* out, size_t o
     }
 }
 
-bool StringToBool(std::string_view str)
+Optional<bool> StringToBool(std::string_view str)
 {
-    return ((str == "1") || StringEqualI(str, "true") || StringEqualI(str, "yes"));
+    if (str == "1" || StringEqualI(str, "y") || StringEqualI(str, "on")  || StringEqualI(str, "yes") || StringEqualI(str, "true"))
+        return true;
+    if (str == "0" || StringEqualI(str, "n") || StringEqualI(str, "off") || StringEqualI(str, "no") || StringEqualI(str, "false"))
+        return false;
+    return std::nullopt;
 }
 
 bool StringEqualI(std::string_view str1, std::string_view str2)