diff options
| author | megamage <none@none> | 2009-08-19 16:26:22 -0500 |
|---|---|---|
| committer | megamage <none@none> | 2009-08-19 16:26:22 -0500 |
| commit | e954904e6d0f026254d4ab93c6b4d051cc7253c6 (patch) | |
| tree | 24374c0508ddd062dccb7b30bb7455eb9a191b3c /src/game/DuelHandler.cpp | |
| parent | d9ed49749db71f971c650c109d5bc1ce8af5d8ad (diff) | |
[8378] Use exceptions instead of explicit size checking for each packet Author: arrai
CHECK_PACKET_SIZE was pretty error prone; once it was forgotten mangosd
could crash due to the asserts in ByteBuffer.h. That was exploitable by
malicious players.
Furthermore, there were duplicate checks: Additionally to
CHECK_PACKET_SIZE, the ByteBuffer assertions keept an eye
on not exceeding the packet boundaries - just to crash the server for
sure in such a case.
To prevent memory leaks or other undesirable states, please read in
every handler all variables _before_ doing any concrete handling.
--HG--
branch : trunk
Diffstat (limited to 'src/game/DuelHandler.cpp')
| -rw-r--r-- | src/game/DuelHandler.cpp | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/src/game/DuelHandler.cpp b/src/game/DuelHandler.cpp index e235395f1f4..c35b9dbdc07 100644 --- a/src/game/DuelHandler.cpp +++ b/src/game/DuelHandler.cpp @@ -28,8 +28,6 @@ void WorldSession::HandleDuelAcceptedOpcode(WorldPacket& recvPacket) { - CHECK_PACKET_SIZE(recvPacket,8); - uint64 guid; Player *pl; Player *plTarget; @@ -61,8 +59,6 @@ void WorldSession::HandleDuelAcceptedOpcode(WorldPacket& recvPacket) void WorldSession::HandleDuelCancelledOpcode(WorldPacket& recvPacket) { - CHECK_PACKET_SIZE(recvPacket,8); - //sLog.outDebug( "WORLD: received CMSG_DUEL_CANCELLED" ); // no duel requested |