Core: fixed few coverity issues and warnings

6 files changed, 13 insertions, 13 deletions

diff --git a/src/server/bnetserver/Packets/AuthenticationPackets.h b/src/server/bnetserver/Packets/AuthenticationPackets.h
index bcaa0e72011..fd5838720ab 100644
--- a/src/server/bnetserver/Packets/AuthenticationPackets.h
+++ b/src/server/bnetserver/Packets/AuthenticationPackets.h
@@ -60,7 +60,7 @@ namespace Battlenet
             std::string Locale;
             std::vector<Component> Components;
             std::string Login;
-            uint8 Region;
+            uint8 Region = 0;
             std::string GameAccountName;
         };
 
@@ -98,7 +98,7 @@ namespace Battlenet
             std::string Locale;
             std::vector<Component> Components;
             std::string Login;
-            uint64 Compatibility;
+            uint64 Compatibility = 0;
         };
 
         class ResponseFailure
@@ -138,8 +138,8 @@ namespace Battlenet
         {
         public:
             LogonResponse() : ServerPacket(PacketHeader(SMSG_LOGON_RESPONSE, AUTHENTICATION)),
-                PingTimeout(120000), FirstName(""), LastName(""), AccountId(0), Region(2), Flags(0),
-                GameAccountRegion(2), GameAccountName(""), FailedLogins(0)
+                PingTimeout(120000), AccountId(0), Region(2), Flags(0),
+                GameAccountRegion(2), GameAccountFlags(0), FailedLogins(0)
             {
             }
 
diff --git a/src/server/bnetserver/Packets/CachePackets.h b/src/server/bnetserver/Packets/CachePackets.h
index a65ab2651c8..57ccd448081 100644
--- a/src/server/bnetserver/Packets/CachePackets.h
+++ b/src/server/bnetserver/Packets/CachePackets.h
@@ -54,8 +54,8 @@ namespace Battlenet
             std::string Channel;
             std::string ItemName;
             std::string Locale;
-            uint32 Index;
-            int32 ReferenceTime;
+            uint32 Index = 0;
+            int32 ReferenceTime = 0;
         };
 
         class GetStreamItemsResponse final : public ServerPacket
@@ -70,7 +70,7 @@ namespace Battlenet
             void Write() override;
             std::string ToString() const override;
 
-            uint32 Index;
+            uint32 Index = 0;
             std::vector<ModuleInfo*> Modules;
         };
     }
diff --git a/src/server/bnetserver/Packets/ConnectionPackets.h b/src/server/bnetserver/Packets/ConnectionPackets.h
index 8572cd5d854..1c4619c6df3 100644
--- a/src/server/bnetserver/Packets/ConnectionPackets.h
+++ b/src/server/bnetserver/Packets/ConnectionPackets.h
@@ -89,8 +89,8 @@ namespace Battlenet
             void Read() override;
             std::string ToString() const override;
 
-            uint16 Timeout;
-            uint32 Tick;
+            uint16 Timeout = 0;
+            uint32 Tick = 0;
         };
 
         class ConnectionClosing final : public ClientPacket
diff --git a/src/server/bnetserver/Packets/FriendsPackets.cpp b/src/server/bnetserver/Packets/FriendsPackets.cpp
index 2659ec6204f..8b5d92389af 100644
--- a/src/server/bnetserver/Packets/FriendsPackets.cpp
+++ b/src/server/bnetserver/Packets/FriendsPackets.cpp
@@ -20,8 +20,8 @@
 
 void Battlenet::Friends::GetFriendsOfFriend::Read()
 {
-    uint8 unk = _stream.Read<uint8>(2);
-    uint32 unk1 = _stream.Read<uint32>(32);
+    _stream.Read<uint8>(2);
+    _stream.Read<uint32>(32);
 }
 
 std::string Battlenet::Friends::GetFriendsOfFriend::ToString() const
diff --git a/src/server/bnetserver/Packets/FriendsPackets.h b/src/server/bnetserver/Packets/FriendsPackets.h
index ea4d6d2ea92..12935ddc4da 100644
--- a/src/server/bnetserver/Packets/FriendsPackets.h
+++ b/src/server/bnetserver/Packets/FriendsPackets.h
@@ -78,7 +78,7 @@ namespace Battlenet
             std::string ToString() const override;
             void CallHandler(Session* session) override;
 
-            uint32 SocialNetworkId;
+            uint32 SocialNetworkId = 0;
         };
 
         class RealIdFriendInvite final : public ClientPacket
diff --git a/src/server/bnetserver/Packets/WoWRealmPackets.h b/src/server/bnetserver/Packets/WoWRealmPackets.h
index b411c63100a..dc958db501b 100644
--- a/src/server/bnetserver/Packets/WoWRealmPackets.h
+++ b/src/server/bnetserver/Packets/WoWRealmPackets.h
@@ -78,7 +78,7 @@ namespace Battlenet
             std::string ToString() const override;
             void CallHandler(Session* session) override;
 
-            uint32 ClientSeed;
+            uint32 ClientSeed = 0;
             RealmId Realm;
         };