Core/Logging: Minor internal refactor

* Avoid formatting to output with fprintf
* Use vector instead of unordered_map to store appenders in Logger

2 files changed, 5 insertions, 4 deletions

diff --git a/src/server/database/Logging/AppenderDB.cpp b/src/server/database/Logging/AppenderDB.cpp
index 5bac05b47e1..8041cbafdaa 100644
--- a/src/server/database/Logging/AppenderDB.cpp
+++ b/src/server/database/Logging/AppenderDB.cpp
@@ -20,10 +20,10 @@
 #include "LogMessage.h"
 #include "PreparedStatement.h"
 
-AppenderDB::AppenderDB(uint8 id, std::string const& name, LogLevel level, AppenderFlags /*flags*/, std::vector<std::string_view> const& /*args*/)
-    : Appender(id, name, level), realmId(0), enabled(false) { }
+AppenderDB::AppenderDB(uint8 id, std::string name, LogLevel level, AppenderFlags /*flags*/, std::vector<std::string_view> const& /*args*/)
+    : Appender(id, std::move(name), level), realmId(0), enabled(false) { }
 
-AppenderDB::~AppenderDB() { }
+AppenderDB::~AppenderDB() = default;
 
 void AppenderDB::_write(LogMessage const* message)
 {
diff --git a/src/server/database/Logging/AppenderDB.h b/src/server/database/Logging/AppenderDB.h
index f4880df659a..64c8aa57f6a 100644
--- a/src/server/database/Logging/AppenderDB.h
+++ b/src/server/database/Logging/AppenderDB.h
@@ -19,13 +19,14 @@
 #define APPENDERDB_H
 
 #include "Appender.h"
+#include <vector>
 
 class TC_DATABASE_API AppenderDB: public Appender
 {
     public:
         static constexpr AppenderType type = APPENDER_DB;
 
-        AppenderDB(uint8 id, std::string const& name, LogLevel level, AppenderFlags flags, std::vector<std::string_view> const& args);
+        AppenderDB(uint8 id, std::string name, LogLevel level, AppenderFlags flags, std::vector<std::string_view> const& args);
         ~AppenderDB();
 
         void setRealmId(uint32 realmId) override;