diff options
| author | Shauren <shauren.trinity@gmail.com> | 2020-09-05 18:00:00 +0200 |
|---|---|---|
| committer | Shauren <shauren.trinity@gmail.com> | 2022-02-05 13:07:25 +0100 |
| commit | 04021a30baa6ec37d9c8908534b1f46c84fb1190 (patch) | |
| tree | 15249ca08a32800e122964572ed1f66a939c037e /src/server/game/Achievements/CriteriaHandler.cpp | |
| parent | ae6f8bc4f546b0db9b39acad03687d968a348779 (diff) | |
Core/Players: Directly store PlayerSpell in m_spells, not as pointer
Closes #25402
(cherry picked from commit 1e446b021b704818fb4ef9bd8622716d138295b0)
Diffstat (limited to 'src/server/game/Achievements/CriteriaHandler.cpp')
| -rw-r--r-- | src/server/game/Achievements/CriteriaHandler.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/server/game/Achievements/CriteriaHandler.cpp b/src/server/game/Achievements/CriteriaHandler.cpp index 3104fe53936..166a2c9270c 100644 --- a/src/server/game/Achievements/CriteriaHandler.cpp +++ b/src/server/game/Achievements/CriteriaHandler.cpp @@ -688,9 +688,9 @@ void CriteriaHandler::UpdateCriteria(CriteriaType type, uint64 miscValue1 /*= 0* case CriteriaType::LearnTradeskillSkillLine: { uint32 spellCount = 0; - for (std::pair<uint32 const, PlayerSpell*>& spellIter : referencePlayer->GetSpellMap()) + for (auto& [spellId, _] : referencePlayer->GetSpellMap()) { - SkillLineAbilityMapBounds bounds = sSpellMgr->GetSkillLineAbilityMapBounds(spellIter.first); + SkillLineAbilityMapBounds bounds = sSpellMgr->GetSkillLineAbilityMapBounds(spellId); for (SkillLineAbilityMap::const_iterator skillIter = bounds.first; skillIter != bounds.second; ++skillIter) { if (skillIter->second->SkillLine == int32(criteria->Entry->Asset.SkillID)) |