aboutsummaryrefslogtreecommitdiff
path: root/src/server/game/AuctionHouseBot/AuctionHouseBotBuyer.cpp
diff options
context:
space:
mode:
authorShauren <shauren.trinity@gmail.com>2024-11-03 20:51:03 +0100
committerOvahlord <dreadkiller@gmx.de>2024-12-24 20:17:34 +0100
commit1c9facc73ad017dddd67785985fc6fb3d1eb1556 (patch)
tree8338a8a9ab3178474c69c2e5506bb409f59fcdec /src/server/game/AuctionHouseBot/AuctionHouseBotBuyer.cpp
parenta2d99b2219cb772741085927ab74e0e2a997702a (diff)
Core/AuctionHouse: Fixed use after free
Closes #30128 (cherry picked from commit b83de81a70b580045540ed4db5627aff5edc682c)
Diffstat (limited to 'src/server/game/AuctionHouseBot/AuctionHouseBotBuyer.cpp')
-rw-r--r--src/server/game/AuctionHouseBot/AuctionHouseBotBuyer.cpp8
1 files changed, 4 insertions, 4 deletions
diff --git a/src/server/game/AuctionHouseBot/AuctionHouseBotBuyer.cpp b/src/server/game/AuctionHouseBot/AuctionHouseBotBuyer.cpp
index c96281ca7b9..e88994eba3a 100644
--- a/src/server/game/AuctionHouseBot/AuctionHouseBotBuyer.cpp
+++ b/src/server/game/AuctionHouseBot/AuctionHouseBotBuyer.cpp
@@ -415,12 +415,12 @@ void AuctionBotBuyer::BuyEntry(AuctionPosting* auction, AuctionHouseObject* auct
// Copy data before freeing AuctionPosting in auctionHouse->RemoveAuction
// Because auctionHouse->SendAuctionWon can unload items if bidder is offline
// we need to RemoveAuction before sending mails
- AuctionPosting copy = *auction;
- auctionHouse->RemoveAuction(trans, auction);
+ std::map<uint32, AuctionPosting>::node_type removedAuctionNode = auctionHouse->RemoveAuction(trans, auction);
+ auction = &removedAuctionNode.mapped();
// Mails must be under transaction control too to prevent data loss
- auctionHouse->SendAuctionSold(&copy, nullptr, trans);
- auctionHouse->SendAuctionWon(&copy, nullptr, trans);
+ auctionHouse->SendAuctionSold(auction, nullptr, trans);
+ auctionHouse->SendAuctionWon(auction, nullptr, trans);
// Run SQLs
CharacterDatabase.CommitTransaction(trans);