aboutsummaryrefslogtreecommitdiff
path: root/src/server/game/Chat/Chat.cpp
diff options
context:
space:
mode:
authorTreeston <treeston.mmoc@gmail.com>2020-08-30 13:45:04 +0200
committerTreeston <treeston.mmoc@gmail.com>2020-08-30 13:45:04 +0200
commit944f49d61355926e0d9e5c2d16eb4ad1af03d13c (patch)
treefe5da28c18e7eaced8f55e0402daf75a65ad322e /src/server/game/Chat/Chat.cpp
parent2f7d2ef3e979ecd0536f3a3713e56c8e59652a47 (diff)
Scripts/Commands: Fix a crash in .help - closes #25360
Diffstat (limited to 'src/server/game/Chat/Chat.cpp')
-rw-r--r--src/server/game/Chat/Chat.cpp14
1 files changed, 8 insertions, 6 deletions
diff --git a/src/server/game/Chat/Chat.cpp b/src/server/game/Chat/Chat.cpp
index 7413c6ec28c..b41578717de 100644
--- a/src/server/game/Chat/Chat.cpp
+++ b/src/server/game/Chat/Chat.cpp
@@ -154,7 +154,7 @@ bool ChatHandler::hasStringAbbr(char const* name, char const* part)
while (true)
{
- if (!*part)
+ if (!*part || *part == ' ')
return true;
else if (!*name)
return false;
@@ -456,6 +456,10 @@ bool ChatHandler::ShowHelpForCommand(std::vector<ChatCommand> const& table, char
{
if (*cmd)
{
+ std::string subcmd;
+ if (size_t n = std::string_view(cmd).find(' '); n != std::string_view::npos)
+ subcmd.assign(cmd+n+1);
+
for (uint32 i = 0; i < table.size(); ++i)
{
// must be available (ignore handler existence to show command with possible available subcommands)
@@ -466,11 +470,9 @@ bool ChatHandler::ShowHelpForCommand(std::vector<ChatCommand> const& table, char
continue;
// have subcommand
- char const* subcmd = (*cmd) ? strtok(nullptr, " ") : "";
-
- if (!table[i].ChildCommands.empty() && subcmd && *subcmd)
+ if (!table[i].ChildCommands.empty() && !subcmd.empty())
{
- if (ShowHelpForCommand(table[i].ChildCommands, subcmd))
+ if (ShowHelpForCommand(table[i].ChildCommands, subcmd.c_str()))
return true;
}
@@ -478,7 +480,7 @@ bool ChatHandler::ShowHelpForCommand(std::vector<ChatCommand> const& table, char
SendSysMessage(table[i].Help.c_str());
if (!table[i].ChildCommands.empty())
- if (ShowHelpForSubCommands(table[i].ChildCommands, table[i].Name, subcmd ? subcmd : ""))
+ if (ShowHelpForSubCommands(table[i].ChildCommands, table[i].Name, subcmd.c_str()))
return true;
return !table[i].Help.empty();