diff options
| author | Spp <spp@jorge.gr> | 2012-10-24 15:34:23 +0200 |
|---|---|---|
| committer | Spp <spp@jorge.gr> | 2012-10-24 15:34:48 +0200 |
| commit | 9fbc4c0ae2acab3ceba717b33c72e2382a1e5bb8 (patch) | |
| tree | 2190f494bc8830b8a695c5fcad612e4d0c350fee /src/server/game/Chat | |
| parent | 013fb1f4d9131fc8ec45931445e6a05408dce8f9 (diff) | |
Core/Misc: reduced amount of string memory allocations (Step II)
Diffstat (limited to 'src/server/game/Chat')
| -rwxr-xr-x | src/server/game/Chat/Channels/Channel.h | 14 | ||||
| -rwxr-xr-x | src/server/game/Chat/Chat.h | 2 |
2 files changed, 8 insertions, 8 deletions
diff --git a/src/server/game/Chat/Channels/Channel.h b/src/server/game/Chat/Channels/Channel.h index 6794a4ea93b..bdb5112c7ef 100755 --- a/src/server/game/Chat/Channels/Channel.h +++ b/src/server/game/Chat/Channels/Channel.h @@ -172,7 +172,7 @@ class Channel void MakeNotModerator(WorldPacket* data); //? 0x06 void MakePasswordChanged(WorldPacket* data, uint64 guid); //+ 0x07 void MakeOwnerChanged(WorldPacket* data, uint64 guid); //? 0x08 - void MakePlayerNotFound(WorldPacket* data, const std::string& name); //+ 0x09 + void MakePlayerNotFound(WorldPacket* data, std::string const& name); //+ 0x09 void MakeNotOwner(WorldPacket* data); //? 0x0A void MakeChannelOwner(WorldPacket* data); //? 0x0B void MakeModeChange(WorldPacket* data, uint64 guid, uint8 oldflags); //+ 0x0C @@ -183,15 +183,15 @@ class Channel void MakeBanned(WorldPacket* data); //? 0x13 void MakePlayerBanned(WorldPacket* data, uint64 bad, uint64 good); //? 0x14 void MakePlayerUnbanned(WorldPacket* data, uint64 bad, uint64 good); //? 0x15 - void MakePlayerNotBanned(WorldPacket* data, const std::string& name); //? 0x16 + void MakePlayerNotBanned(WorldPacket* data, std::string const& name); //? 0x16 void MakePlayerAlreadyMember(WorldPacket* data, uint64 guid); //+ 0x17 void MakeInvite(WorldPacket* data, uint64 guid); //? 0x18 void MakeInviteWrongFaction(WorldPacket* data); //? 0x19 void MakeWrongFaction(WorldPacket* data); //? 0x1A void MakeInvalidName(WorldPacket* data); //? 0x1B void MakeNotModerated(WorldPacket* data); //? 0x1C - void MakePlayerInvited(WorldPacket* data, const std::string& name); //+ 0x1D - void MakePlayerInviteBanned(WorldPacket* data, const std::string &name);//? 0x1E + void MakePlayerInvited(WorldPacket* data, std::string const& name); //+ 0x1D + void MakePlayerInviteBanned(WorldPacket* data, std::string const& name);//? 0x1E void MakeThrottled(WorldPacket* data); //? 0x1F void MakeNotInArea(WorldPacket* data); //? 0x20 void MakeNotInLfg(WorldPacket* data); //? 0x21 @@ -245,14 +245,14 @@ class Channel public: uint32 m_Team; - Channel(const std::string& name, uint32 channel_id, uint32 Team = 0); + Channel(std::string const& name, uint32 channel_id, uint32 Team = 0); std::string const& GetName() const { return m_name; } uint32 GetChannelId() const { return m_channelId; } bool IsConstant() const { return m_channelId != 0; } bool IsAnnounce() const { return m_announce; } bool IsLFG() const { return GetFlags() & CHANNEL_FLAG_LFG; } - std::string GetPassword() const { return m_password; } - void SetPassword(const std::string& npassword) { m_password = npassword; } + std::string const& GetPassword() const { return m_password; } + void SetPassword(std::string const& npassword) { m_password = npassword; } void SetAnnounce(bool nannounce) { m_announce = nannounce; } uint32 GetNumPlayers() const { return players.size(); } uint8 GetFlags() const { return m_flags; } diff --git a/src/server/game/Chat/Chat.h b/src/server/game/Chat/Chat.h index d4701b10ce1..d07f036f780 100755 --- a/src/server/game/Chat/Chat.h +++ b/src/server/game/Chat/Chat.h @@ -128,7 +128,7 @@ class ChatHandler protected: explicit ChatHandler() : m_session(NULL), sentErrorMessage(false) {} // for CLI subclass static bool SetDataForCommandInTable(ChatCommand* table, const char* text, uint32 security, std::string const& help, std::string const& fullcommand); - bool ExecuteCommandInTable(ChatCommand* table, const char* text, const std::string& fullcmd); + bool ExecuteCommandInTable(ChatCommand* table, const char* text, std::string const& fullcmd); bool ShowHelpForSubCommands(ChatCommand* table, char const* cmd, char const* subcmd); private: |