Core/Criterias: Define 31 criteria types (#19042)

Defined criteria types:
CRITERIA_TYPE_SURVEY_GAMEOBJECT
CRITERIA_TYPE_CLEAR_DIGSITE
CRITERIA_TYPE_MANUAL_COMPLETE_CRITERIA
CRITERIA_TYPE_COMPLETE_CHALLENGE_MODE_GUILD
CRITERIA_TYPE_DEFEAT_CREATURE_GROUP
CRITERIA_TYPE_COMPLETE_CHALLENGE_MODE
CRITERIA_TYPE_SEND_EVENT
CRITERIA_TYPE_COOK_RECIPES_GUILD
CRITERIA_TYPE_EARN_PET_BATTLE_ACHIEVEMENT_POINTS
CRITERIA_TYPE_SEND_EVENT_SCENARIO
CRITERIA_TYPE_RELEASE_SPIRIT
CRITERIA_TYPE_OWN_PET
CRITERIA_TYPE_GARRISON_COMPLETE_DUNGEON_ENCOUNTER
CRITERIA_TYPE_COMPLETE_LFG_DUNGEON
CRITERIA_TYPE_LFG_VOTE_KICKS_INITIATED_BY_PLAYER
CRITERIA_TYPE_LFG_VOTE_KICKS_NOT_INIT_BY_PLAYER
CRITERIA_TYPE_BE_KICKED_FROM_LFG
CRITERIA_TYPE_LFG_LEAVES
CRITERIA_TYPE_COUNT_OF_LFG_QUEUE_BOOSTS_BY_TANK
CRITERIA_TYPE_REACH_AREATRIGGER_WITH_ACTIONSET
CRITERIA_TYPE_START_ORDER_HALL_MISSION
CRITERIA_TYPE_RECRUIT_GARRISON_FOLLOWER (was defined for id 187)
CRITERIA_TYPE_OWN_HEIRLOOMS
CRITERIA_TYPE_ARTIFACT_POWER_EARNED
CRITERIA_TYPE_ARTIFACT_TRAITS_UNLOCKED
CRITERIA_TYPE_HONOR_LEVEL_REACHED

Redefined criteria types:
CRITERIA_TYPE_RECRUIT_GARRISON_FOLLOWER_WITH_QUALITY (was
CRITERIA_TYPE_RECRUIT_GARRISON_FOLLOWER)

1 files changed, 65 insertions, 21 deletions

diff --git a/src/server/game/DataStores/DBCEnums.h b/src/server/game/DataStores/DBCEnums.h
index 5d1b3e536f8..ebdf6eac626 100644
--- a/src/server/game/DataStores/DBCEnums.h
+++ b/src/server/game/DataStores/DBCEnums.h
@@ -219,7 +219,9 @@ enum CriteriaAdditionalCondition
     CRITERIA_ADDITIONAL_CONDITION_RATED_BATTLEGROUND            = 63, // NYI
     CRITERIA_ADDITIONAL_CONDITION_PROJECT_RARITY                = 65,
     CRITERIA_ADDITIONAL_CONDITION_PROJECT_RACE                  = 66,
+    CRITERIA_ADDITIONAL_CONDITION_CHALLENGE_MODE_MEDAL          = 83, // NYI
     CRITERIA_ADDITIONAL_CONDITION_BATTLE_PET_SPECIES            = 91,
+    CRITERIA_ADDITIONAL_CONDITION_GARRISON_FOLLOWER_ENTRY       = 144,
     CRITERIA_ADDITIONAL_CONDITION_GARRISON_FOLLOWER_QUALITY     = 145,
     CRITERIA_ADDITIONAL_CONDITION_GARRISON_FOLLOWER_LEVEL       = 146,
     CRITERIA_ADDITIONAL_CONDITION_GARRISON_RARE_MISSION         = 147, // NYI
@@ -257,8 +259,11 @@ enum CriteriaTypes
 {
     CRITERIA_TYPE_KILL_CREATURE                         = 0,
     CRITERIA_TYPE_WIN_BG                                = 1,
+    // 2 - unused (Legion - 23420)
     CRITERIA_TYPE_COMPLETE_ARCHAEOLOGY_PROJECTS         = 3, // struct { uint32 itemCount; }
+    CRITERIA_TYPE_SURVEY_GAMEOBJECT                     = 4,
     CRITERIA_TYPE_REACH_LEVEL                           = 5,
+    CRITERIA_TYPE_CLEAR_DIGSITE                         = 6,
     CRITERIA_TYPE_REACH_SKILL_LEVEL                     = 7,
     CRITERIA_TYPE_COMPLETE_ACHIEVEMENT                  = 8,
     CRITERIA_TYPE_COMPLETE_QUEST_COUNT                  = 9,
@@ -273,8 +278,11 @@ enum CriteriaTypes
     CRITERIA_TYPE_DEATH_IN_DUNGEON                      = 18,
     CRITERIA_TYPE_COMPLETE_RAID                         = 19,
     CRITERIA_TYPE_KILLED_BY_CREATURE                    = 20,
+    CRITERIA_TYPE_MANUAL_COMPLETE_CRITERIA              = 21,
+    CRITERIA_TYPE_COMPLETE_CHALLENGE_MODE_GUILD         = 22,
     CRITERIA_TYPE_KILLED_BY_PLAYER                      = 23,
     CRITERIA_TYPE_FALL_WITHOUT_DYING                    = 24,
+    // 25 - unused (Legion - 23420)
     CRITERIA_TYPE_DEATHS_FROM                           = 26,
     CRITERIA_TYPE_COMPLETE_QUEST                        = 27,
     CRITERIA_TYPE_BE_SPELL_TARGET                       = 28,
@@ -307,25 +315,30 @@ enum CriteriaTypes
     CRITERIA_TYPE_HEALING_DONE                          = 55,
     CRITERIA_TYPE_GET_KILLING_BLOWS                     = 56, /// @todo in some cases map not present, and in some cases need do without die
     CRITERIA_TYPE_EQUIP_ITEM                            = 57,
+    // 58 - unused (Legion - 23420)
     CRITERIA_TYPE_MONEY_FROM_VENDORS                    = 59,
     CRITERIA_TYPE_GOLD_SPENT_FOR_TALENTS                = 60,
     CRITERIA_TYPE_NUMBER_OF_TALENT_RESETS               = 61,
     CRITERIA_TYPE_MONEY_FROM_QUEST_REWARD               = 62,
     CRITERIA_TYPE_GOLD_SPENT_FOR_TRAVELLING             = 63,
+    CRITERIA_TYPE_DEFEAT_CREATURE_GROUP                 = 64,
     CRITERIA_TYPE_GOLD_SPENT_AT_BARBER                  = 65,
     CRITERIA_TYPE_GOLD_SPENT_FOR_MAIL                   = 66,
     CRITERIA_TYPE_LOOT_MONEY                            = 67,
     CRITERIA_TYPE_USE_GAMEOBJECT                        = 68,
     CRITERIA_TYPE_BE_SPELL_TARGET2                      = 69,
     CRITERIA_TYPE_SPECIAL_PVP_KILL                      = 70,
+    CRITERIA_TYPE_COMPLETE_CHALLENGE_MODE               = 71,
     CRITERIA_TYPE_FISH_IN_GAMEOBJECT                    = 72,
-    /// @todo 73: Achievements 1515, 1241, 1103 (Name: Mal'Ganis)
+    CRITERIA_TYPE_SEND_EVENT                            = 73,
     CRITERIA_TYPE_ON_LOGIN                              = 74,
     CRITERIA_TYPE_LEARN_SKILLLINE_SPELLS                = 75,
     CRITERIA_TYPE_WIN_DUEL                              = 76,
     CRITERIA_TYPE_LOSE_DUEL                             = 77,
     CRITERIA_TYPE_KILL_CREATURE_TYPE                    = 78,
+    CRITERIA_TYPE_COOK_RECIPES_GUILD                    = 79,
     CRITERIA_TYPE_GOLD_EARNED_BY_AUCTIONS               = 80,
+    CRITERIA_TYPE_EARN_PET_BATTLE_ACHIEVEMENT_POINTS    = 81,
     CRITERIA_TYPE_CREATE_AUCTION                        = 82,
     CRITERIA_TYPE_HIGHEST_AUCTION_BID                   = 83,
     CRITERIA_TYPE_WON_AUCTIONS                          = 84,
@@ -336,9 +349,15 @@ enum CriteriaTypes
     CRITERIA_TYPE_KNOWN_FACTIONS                        = 89,
     CRITERIA_TYPE_LOOT_EPIC_ITEM                        = 90,
     CRITERIA_TYPE_RECEIVE_EPIC_ITEM                     = 91,
-    CRITERIA_TYPE_SEND_EVENT                            = 92,
+    CRITERIA_TYPE_SEND_EVENT_SCENARIO                   = 92,
     CRITERIA_TYPE_ROLL_NEED                             = 93,
     CRITERIA_TYPE_ROLL_GREED                            = 94,
+    CRITERIA_TYPE_RELEASE_SPIRIT                        = 95,
+    CRITERIA_TYPE_OWN_PET                               = 96,
+    CRITERIA_TYPE_GARRISON_COMPLETE_DUNGEON_ENCOUNTER   = 97,
+    // 98 - unused (Legion - 23420)
+    // 99 - unused (Legion - 23420)
+    // 100 - unused (Legion - 23420)
     CRITERIA_TYPE_HIGHEST_HIT_DEALT                     = 101,
     CRITERIA_TYPE_HIGHEST_HIT_RECEIVED                  = 102,
     CRITERIA_TYPE_TOTAL_DAMAGE_RECEIVED                 = 103,
@@ -349,11 +368,19 @@ enum CriteriaTypes
     CRITERIA_TYPE_FLIGHT_PATHS_TAKEN                    = 108,
     CRITERIA_TYPE_LOOT_TYPE                             = 109,
     CRITERIA_TYPE_CAST_SPELL2                           = 110, /// @todo target entry is missing
+    // 111 - unused (Legion - 23420)
     CRITERIA_TYPE_LEARN_SKILL_LINE                      = 112,
     CRITERIA_TYPE_EARN_HONORABLE_KILL                   = 113,
     CRITERIA_TYPE_ACCEPTED_SUMMONINGS                   = 114,
     CRITERIA_TYPE_EARN_ACHIEVEMENT_POINTS               = 115,
+    // 116 - unused (Legion - 23420)
+    // 117 - unused (Legion - 23420)
+    CRITERIA_TYPE_COMPLETE_LFG_DUNGEON                  = 118,
     CRITERIA_TYPE_USE_LFD_TO_GROUP_WITH_PLAYERS         = 119,
+    CRITERIA_TYPE_LFG_VOTE_KICKS_INITIATED_BY_PLAYER    = 120,
+    CRITERIA_TYPE_LFG_VOTE_KICKS_NOT_INIT_BY_PLAYER     = 121,
+    CRITERIA_TYPE_BE_KICKED_FROM_LFG                    = 122,
+    CRITERIA_TYPE_LFG_LEAVES                            = 123,
     CRITERIA_TYPE_SPENT_GOLD_GUILD_REPAIRS              = 124,
     CRITERIA_TYPE_REACH_GUILD_LEVEL                     = 125,
     CRITERIA_TYPE_CRAFT_ITEMS_GUILD                     = 126,
@@ -361,18 +388,20 @@ enum CriteriaTypes
     CRITERIA_TYPE_BUY_GUILD_BANK_SLOTS                  = 128,
     CRITERIA_TYPE_EARN_GUILD_ACHIEVEMENT_POINTS         = 129,
     CRITERIA_TYPE_WIN_RATED_BATTLEGROUND                = 130,
+    // 131 - unused (Legion - 23420)
     CRITERIA_TYPE_REACH_BG_RATING                       = 132,
     CRITERIA_TYPE_BUY_GUILD_TABARD                      = 133,
     CRITERIA_TYPE_COMPLETE_QUESTS_GUILD                 = 134,
     CRITERIA_TYPE_HONORABLE_KILLS_GUILD                 = 135,
     CRITERIA_TYPE_KILL_CREATURE_TYPE_GUILD              = 136,
+    CRITERIA_TYPE_COUNT_OF_LFG_QUEUE_BOOSTS_BY_TANK     = 137,
     CRITERIA_TYPE_COMPLETE_GUILD_CHALLENGE_TYPE         = 138, //struct { Flag flag; uint32 count; } 1: Guild Dungeon, 2:Guild Challenge, 3:Guild battlefield
     CRITERIA_TYPE_COMPLETE_GUILD_CHALLENGE              = 139, //struct { uint32 count; } Guild Challenge
-    // 140 unk
-    // 141 unk
-    // 142 unk
-    // 143 unk
-    // 144 unk
+    // 140 - 1 criteria (16883), unused (Legion - 23420)
+    // 141 - 1 criteria (16884), unused (Legion - 23420)
+    // 142 - 1 criteria (16881), unused (Legion - 23420)
+    // 143 - 1 criteria (16882), unused (Legion - 23420)
+    // 144 - 1 criteria (17386), unused (Legion - 23420)
     CRITERIA_TYPE_LFR_DUNGEONS_COMPLETED                = 145,
     CRITERIA_TYPE_LFR_LEAVES                            = 146,
     CRITERIA_TYPE_LFR_VOTE_KICKS_INITIATED_BY_PLAYER    = 147,
@@ -381,44 +410,59 @@ enum CriteriaTypes
     CRITERIA_TYPE_COUNT_OF_LFR_QUEUE_BOOSTS_BY_TANK     = 150,
     CRITERIA_TYPE_COMPLETE_SCENARIO_COUNT               = 151,
     CRITERIA_TYPE_COMPLETE_SCENARIO                     = 152,
-    // CRITERIA_TYPE_REACH_SOMETHING_LIKE_AREATRIGGER   = 153,
-    // 154
+    CRITERIA_TYPE_REACH_AREATRIGGER_WITH_ACTIONSET      = 153,
+    // 154 - unused (Legion - 23420)
     CRITERIA_TYPE_OWN_BATTLE_PET                        = 155,
     CRITERIA_TYPE_OWN_BATTLE_PET_COUNT                  = 156,
     CRITERIA_TYPE_CAPTURE_BATTLE_PET                    = 157,
     CRITERIA_TYPE_WIN_PET_BATTLE                        = 158,
-    // 159
+    // 159 - 2 criterias (22312,22314), unused (Legion - 23420)
     CRITERIA_TYPE_LEVEL_BATTLE_PET                      = 160,
     CRITERIA_TYPE_CAPTURE_BATTLE_PET_CREDIT             = 161, // triggers a quest credit
     CRITERIA_TYPE_LEVEL_BATTLE_PET_CREDIT               = 162, // triggers a quest credit
     CRITERIA_TYPE_ENTER_AREA                            = 163, // triggers a quest credit
     CRITERIA_TYPE_LEAVE_AREA                            = 164, // triggers a quest credit
     CRITERIA_TYPE_COMPLETE_DUNGEON_ENCOUNTER            = 165,
+    // 166 - unused (Legion - 23420)
     CRITERIA_TYPE_PLACE_GARRISON_BUILDING               = 167,
     CRITERIA_TYPE_UPGRADE_GARRISON_BUILDING             = 168,
     CRITERIA_TYPE_CONSTRUCT_GARRISON_BUILDING           = 169,
     CRITERIA_TYPE_UPGRADE_GARRISON                      = 170,
     CRITERIA_TYPE_START_GARRISON_MISSION                = 171,
-    // 172
+    CRITERIA_TYPE_START_ORDER_HALL_MISSION              = 172,
     CRITERIA_TYPE_COMPLETE_GARRISON_MISSION_COUNT       = 173,
     CRITERIA_TYPE_COMPLETE_GARRISON_MISSION             = 174,
     CRITERIA_TYPE_RECRUIT_GARRISON_FOLLOWER_COUNT       = 175,
-    // 176
-    // 177
+    CRITERIA_TYPE_RECRUIT_GARRISON_FOLLOWER             = 176,
+    // 177 - 0 criterias (Legion - 23420)
     CRITERIA_TYPE_LEARN_GARRISON_BLUEPRINT_COUNT        = 178,
-    // 179
-    // 180
-    // 181
+    // 179 - 0 criterias (Legion - 23420)
+    // 180 - 0 criterias (Legion - 23420)
+    // 181 - 0 criterias (Legion - 23420)
     CRITERIA_TYPE_COMPLETE_GARRISON_SHIPMENT            = 182,
     CRITERIA_TYPE_RAISE_GARRISON_FOLLOWER_ITEM_LEVEL    = 183,
     CRITERIA_TYPE_RAISE_GARRISON_FOLLOWER_LEVEL         = 184,
     CRITERIA_TYPE_OWN_TOY                               = 185,
     CRITERIA_TYPE_OWN_TOY_COUNT                         = 186,
-    CRITERIA_TYPE_RECRUIT_GARRISON_FOLLOWER             = 187,
-    CRITERIA_TYPE_OWN_HEIRLOOMS                         = 189
-};
-
-#define CRITERIA_TYPE_TOTAL 190
+    CRITERIA_TYPE_RECRUIT_GARRISON_FOLLOWER_WITH_QUALITY= 187,
+    // 188 - 0 criterias (Legion - 23420)
+    CRITERIA_TYPE_OWN_HEIRLOOMS                         = 189,
+    CRITERIA_TYPE_ARTIFACT_POWER_EARNED                 = 190,
+    CRITERIA_TYPE_ARTIFACT_TRAITS_UNLOCKED              = 191,
+    CRITERIA_TYPE_HONOR_LEVEL_REACHED                   = 194,
+    CRITERIA_TYPE_PRESTIGE_REACHED                      = 195,
+    // 196 - CRITERIA_TYPE_REACH_LEVEL_2 or something
+    // 197 - Order Hall Advancement related
+    CRITERIA_TYPE_ORDER_HALL_TALENT_LEARNED             = 198,
+    CRITERIA_TYPE_APPEARANCE_UNLOCKED_BY_SLOT           = 199,
+    CRITERIA_TYPE_ORDER_HALL_RECRUIT_TROOP              = 200,
+    // 201 - 0 criterias (Legion - 23420)
+    // 202 - 0 criterias (Legion - 23420)
+    CRITERIA_TYPE_COMPLETE_WORLD_QUEST                  = 203,
+    // 204 - Special criteria type to award players for some external events? Comes with what looks like an identifier, so guessing it's not unique.
+};
+
+#define CRITERIA_TYPE_TOTAL 205
 
 enum CriteriaTreeFlags : uint16
 {