aboutsummaryrefslogtreecommitdiff
path: root/src/server/game/Entities
diff options
context:
space:
mode:
authorleak <leak@bitmx.net>2012-03-14 18:51:51 +0100
committerleak <leak@bitmx.net>2012-03-14 18:51:51 +0100
commit2a5caef4a64645f788f6d3e33d6159725358f1dd (patch)
tree82978b70c72e756d5252bbce68fdec359e71f423 /src/server/game/Entities
parentb02a012b4784e2073593a75315616e093327e738 (diff)
Revert "Core: more more cleanup" - Build test anyone?
This reverts commit 20cd4c71ee6336610daab304959909b2f6397287.
Diffstat (limited to 'src/server/game/Entities')
-rwxr-xr-xsrc/server/game/Entities/Item/Container/Bag.cpp36
-rwxr-xr-xsrc/server/game/Entities/Item/Container/Bag.h2
-rwxr-xr-xsrc/server/game/Entities/Item/Item.cpp10
-rwxr-xr-xsrc/server/game/Entities/Player/Player.cpp946
-rwxr-xr-xsrc/server/game/Entities/Player/Player.h54
5 files changed, 524 insertions, 524 deletions
diff --git a/src/server/game/Entities/Item/Container/Bag.cpp b/src/server/game/Entities/Item/Container/Bag.cpp
index 1b9d5c12978..4eede93bd37 100755
--- a/src/server/game/Entities/Item/Container/Bag.cpp
+++ b/src/server/game/Entities/Item/Container/Bag.cpp
@@ -153,18 +153,18 @@ void Bag::RemoveItem(uint8 slot, bool /*update*/)
SetUInt64Value(CONTAINER_FIELD_SLOT_1 + (slot * 2), 0);
}
-void Bag::StoreItem(uint8 slot, Item* item, bool /*update*/)
+void Bag::StoreItem(uint8 slot, Item* pItem, bool /*update*/)
{
ASSERT(slot < MAX_BAG_SIZE);
- if (item && item->GetGUID() != this->GetGUID())
+ if (pItem && pItem->GetGUID() != this->GetGUID())
{
- m_bagslot[slot] = item;
- SetUInt64Value(CONTAINER_FIELD_SLOT_1 + (slot * 2), item->GetGUID());
- item->SetUInt64Value(ITEM_FIELD_CONTAINED, GetGUID());
- item->SetUInt64Value(ITEM_FIELD_OWNER, GetOwnerGUID());
- item->SetContainer(this);
- item->SetSlot(slot);
+ m_bagslot[slot] = pItem;
+ SetUInt64Value(CONTAINER_FIELD_SLOT_1 + (slot * 2), pItem->GetGUID());
+ pItem->SetUInt64Value(ITEM_FIELD_CONTAINED, GetGUID());
+ pItem->SetUInt64Value(ITEM_FIELD_OWNER, GetOwnerGUID());
+ pItem->SetContainer(this);
+ pItem->SetSlot(slot);
}
}
@@ -189,22 +189,22 @@ bool Bag::IsEmpty() const
uint32 Bag::GetItemCount(uint32 item, Item* eItem) const
{
- Item* item;
+ Item* pItem;
uint32 count = 0;
for (uint32 i=0; i < GetBagSize(); ++i)
{
- item = m_bagslot[i];
- if (item && item != eItem && item->GetEntry() == item)
- count += item->GetCount();
+ pItem = m_bagslot[i];
+ if (pItem && pItem != eItem && pItem->GetEntry() == item)
+ count += pItem->GetCount();
}
if (eItem && eItem->GetTemplate()->GemProperties)
{
for (uint32 i=0; i < GetBagSize(); ++i)
{
- item = m_bagslot[i];
- if (item && item != eItem && item->GetTemplate()->Socket[0].Color)
- count += item->GetGemCountWithID(item);
+ pItem = m_bagslot[i];
+ if (pItem && pItem != eItem && pItem->GetTemplate()->Socket[0].Color)
+ count += pItem->GetGemCountWithID(item);
}
}
@@ -215,9 +215,9 @@ uint32 Bag::GetItemCountWithLimitCategory(uint32 limitCategory, Item* skipItem)
{
uint32 count = 0;
for (uint32 i = 0; i < GetBagSize(); ++i)
- if (Item* item = m_bagslot[i])
- if (item != skipItem)
- if (ItemTemplate const* pProto = item->GetTemplate())
+ if (Item* pItem = m_bagslot[i])
+ if (pItem != skipItem)
+ if (ItemTemplate const* pProto = pItem->GetTemplate())
if (pProto->ItemLimitCategory == limitCategory)
count += m_bagslot[i]->GetCount();
diff --git a/src/server/game/Entities/Item/Container/Bag.h b/src/server/game/Entities/Item/Container/Bag.h
index 79acd9ba4af..5a533d9cf57 100755
--- a/src/server/game/Entities/Item/Container/Bag.h
+++ b/src/server/game/Entities/Item/Container/Bag.h
@@ -38,7 +38,7 @@ class Bag : public Item
bool Create(uint32 guidlow, uint32 itemid, Player const* owner);
void Clear();
- void StoreItem(uint8 slot, Item* item, bool update);
+ void StoreItem(uint8 slot, Item* pItem, bool update);
void RemoveItem(uint8 slot, bool update);
Item* GetItemByPos(uint8 slot) const;
diff --git a/src/server/game/Entities/Item/Item.cpp b/src/server/game/Entities/Item/Item.cpp
index 4e76ddfe0a8..90f6f4a217c 100755
--- a/src/server/game/Entities/Item/Item.cpp
+++ b/src/server/game/Entities/Item/Item.cpp
@@ -1021,14 +1021,14 @@ Item* Item::CreateItem(uint32 item, uint32 count, Player const* player)
ASSERT(count !=0 && "pProto->Stackable == 0 but checked at loading already");
- Item* item = NewItemOrBag(pProto);
- if (item->Create(sObjectMgr->GenerateLowGuid(HIGHGUID_ITEM), item, player))
+ Item* pItem = NewItemOrBag(pProto);
+ if (pItem->Create(sObjectMgr->GenerateLowGuid(HIGHGUID_ITEM), item, player))
{
- item->SetCount(count);
- return item;
+ pItem->SetCount(count);
+ return pItem;
}
else
- delete item;
+ delete pItem;
}
else
ASSERT(false);
diff --git a/src/server/game/Entities/Player/Player.cpp b/src/server/game/Entities/Player/Player.cpp
index a1e8ddd95d1..f0b974fa673 100755
--- a/src/server/game/Entities/Player/Player.cpp
+++ b/src/server/game/Entities/Player/Player.cpp
@@ -1160,31 +1160,31 @@ bool Player::Create(uint32 guidlow, CharacterCreateInfo* createInfo)
// or ammo not equipped in special bag
for (uint8 i = INVENTORY_SLOT_ITEM_START; i < INVENTORY_SLOT_ITEM_END; i++)
{
- if (Item* item = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
+ if (Item* pItem = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
{
uint16 eDest;
// equip offhand weapon/shield if it attempt equipped before main-hand weapon
- InventoryResult msg = CanEquipItem(NULL_SLOT, eDest, item, false);
+ InventoryResult msg = CanEquipItem(NULL_SLOT, eDest, pItem, false);
if (msg == EQUIP_ERR_OK)
{
RemoveItem(INVENTORY_SLOT_BAG_0, i, true);
- EquipItem(eDest, item, true);
+ EquipItem(eDest, pItem, true);
}
// move other items to more appropriate slots (ammo not equipped in special bag)
else
{
ItemPosCountVec sDest;
- msg = CanStoreItem(NULL_BAG, NULL_SLOT, sDest, item, false);
+ msg = CanStoreItem(NULL_BAG, NULL_SLOT, sDest, pItem, false);
if (msg == EQUIP_ERR_OK)
{
RemoveItem(INVENTORY_SLOT_BAG_0, i, true);
- item = StoreItem(sDest, item, true);
+ pItem = StoreItem(sDest, pItem, true);
}
// if this is ammo then use it
- msg = CanUseAmmo(item->GetEntry());
+ msg = CanUseAmmo(pItem->GetEntry());
if (msg == EQUIP_ERR_OK)
- SetAmmo(item->GetEntry());
+ SetAmmo(pItem->GetEntry());
}
}
}
@@ -4854,15 +4854,15 @@ void Player::DeleteFromDB(uint64 playerguid, uint32 accountId, bool updateRealmC
continue;
}
- Item* item = NewItemOrBag(itemProto);
- if (!item->LoadFromDB(item_guidlow, MAKE_NEW_GUID(guid, 0, HIGHGUID_PLAYER), fields, item_template))
+ Item* pItem = NewItemOrBag(itemProto);
+ if (!pItem->LoadFromDB(item_guidlow, MAKE_NEW_GUID(guid, 0, HIGHGUID_PLAYER), fields, item_template))
{
- item->FSetState(ITEM_REMOVED);
- item->SaveToDB(trans); // it also deletes item object!
+ pItem->FSetState(ITEM_REMOVED);
+ pItem->SaveToDB(trans); // it also deletes item object!
continue;
}
- draft.AddItem(item);
+ draft.AddItem(pItem);
}
while (resultItems->NextRow());
}
@@ -5270,8 +5270,8 @@ Corpse* Player::GetCorpse() const
void Player::DurabilityLossAll(double percent, bool inventory)
{
for (uint8 i = EQUIPMENT_SLOT_START; i < EQUIPMENT_SLOT_END; i++)
- if (Item* item = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
- DurabilityLoss(item, percent);
+ if (Item* pItem = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
+ DurabilityLoss(pItem, percent);
if (inventory)
{
@@ -5279,8 +5279,8 @@ void Player::DurabilityLossAll(double percent, bool inventory)
// for (int i = INVENTORY_SLOT_BAG_START; i < INVENTORY_SLOT_BAG_END; i++)
for (uint8 i = INVENTORY_SLOT_ITEM_START; i < INVENTORY_SLOT_ITEM_END; i++)
- if (Item* item = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
- DurabilityLoss(item, percent);
+ if (Item* pItem = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
+ DurabilityLoss(pItem, percent);
// keys not have durability
//for (int i = KEYRING_SLOT_START; i < KEYRING_SLOT_END; i++)
@@ -5288,8 +5288,8 @@ void Player::DurabilityLossAll(double percent, bool inventory)
for (uint8 i = INVENTORY_SLOT_BAG_START; i < INVENTORY_SLOT_BAG_END; i++)
if (Bag* pBag = GetBagByPos(i))
for (uint32 j = 0; j < pBag->GetBagSize(); j++)
- if (Item* item = GetItemByPos(i, j))
- DurabilityLoss(item, percent);
+ if (Item* pItem = GetItemByPos(i, j))
+ DurabilityLoss(pItem, percent);
}
}
@@ -5314,8 +5314,8 @@ void Player::DurabilityLoss(Item* item, double percent)
void Player::DurabilityPointsLossAll(int32 points, bool inventory)
{
for (uint8 i = EQUIPMENT_SLOT_START; i < EQUIPMENT_SLOT_END; i++)
- if (Item* item = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
- DurabilityPointsLoss(item, points);
+ if (Item* pItem = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
+ DurabilityPointsLoss(pItem, points);
if (inventory)
{
@@ -5323,8 +5323,8 @@ void Player::DurabilityPointsLossAll(int32 points, bool inventory)
// for (int i = INVENTORY_SLOT_BAG_START; i < INVENTORY_SLOT_BAG_END; i++)
for (uint8 i = INVENTORY_SLOT_ITEM_START; i < INVENTORY_SLOT_ITEM_END; i++)
- if (Item* item = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
- DurabilityPointsLoss(item, points);
+ if (Item* pItem = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
+ DurabilityPointsLoss(pItem, points);
// keys not have durability
//for (int i = KEYRING_SLOT_START; i < KEYRING_SLOT_END; i++)
@@ -5332,8 +5332,8 @@ void Player::DurabilityPointsLossAll(int32 points, bool inventory)
for (uint8 i = INVENTORY_SLOT_BAG_START; i < INVENTORY_SLOT_BAG_END; i++)
if (Bag* pBag = (Bag*)GetItemByPos(INVENTORY_SLOT_BAG_0, i))
for (uint32 j = 0; j < pBag->GetBagSize(); j++)
- if (Item* item = GetItemByPos(i, j))
- DurabilityPointsLoss(item, points);
+ if (Item* pItem = GetItemByPos(i, j))
+ DurabilityPointsLoss(pItem, points);
}
}
@@ -5366,8 +5366,8 @@ void Player::DurabilityPointsLoss(Item* item, int32 points)
void Player::DurabilityPointLossForEquipSlot(EquipmentSlots slot)
{
- if (Item* item = GetItemByPos(INVENTORY_SLOT_BAG_0, slot))
- DurabilityPointsLoss(item, 1);
+ if (Item* pItem = GetItemByPos(INVENTORY_SLOT_BAG_0, slot))
+ DurabilityPointsLoss(pItem, 1);
}
uint32 Player::DurabilityRepairAll(bool cost, float discountMod, bool guildBank)
@@ -9916,13 +9916,13 @@ InventoryResult Player::CanUnequipItems(uint32 item, uint32 count) const
InventoryResult res = EQUIP_ERR_OK;
for (uint8 i = EQUIPMENT_SLOT_START; i < INVENTORY_SLOT_BAG_END; ++i)
- if (Item* item = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
- if (item->GetEntry() == item)
+ if (Item* pItem = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
+ if (pItem->GetEntry() == item)
{
InventoryResult ires = CanUnequipItem(INVENTORY_SLOT_BAG_0 << 8 | i, false);
if (ires == EQUIP_ERR_OK)
{
- tempcount += item->GetCount();
+ tempcount += pItem->GetCount();
if (tempcount >= count)
return EQUIP_ERR_OK;
}
@@ -9931,19 +9931,19 @@ InventoryResult Player::CanUnequipItems(uint32 item, uint32 count) const
}
for (uint8 i = INVENTORY_SLOT_ITEM_START; i < INVENTORY_SLOT_ITEM_END; ++i)
- if (Item* item = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
- if (item->GetEntry() == item)
+ if (Item* pItem = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
+ if (pItem->GetEntry() == item)
{
- tempcount += item->GetCount();
+ tempcount += pItem->GetCount();
if (tempcount >= count)
return EQUIP_ERR_OK;
}
for (uint8 i = KEYRING_SLOT_START; i < CURRENCYTOKEN_SLOT_END; ++i)
- if (Item* item = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
- if (item->GetEntry() == item)
+ if (Item* pItem = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
+ if (pItem->GetEntry() == item)
{
- tempcount += item->GetCount();
+ tempcount += pItem->GetCount();
if (tempcount >= count)
return EQUIP_ERR_OK;
}
@@ -9951,10 +9951,10 @@ InventoryResult Player::CanUnequipItems(uint32 item, uint32 count) const
for (uint8 i = INVENTORY_SLOT_BAG_START; i < INVENTORY_SLOT_BAG_END; ++i)
if (Bag* pBag = GetBagByPos(i))
for (uint32 j = 0; j < pBag->GetBagSize(); ++j)
- if (Item* item = GetItemByPos(i, j))
- if (item->GetEntry() == item)
+ if (Item* pItem = GetItemByPos(i, j))
+ if (pItem->GetEntry() == item)
{
- tempcount += item->GetCount();
+ tempcount += pItem->GetCount();
if (tempcount >= count)
return EQUIP_ERR_OK;
}
@@ -9967,14 +9967,14 @@ uint32 Player::GetItemCount(uint32 item, bool inBankAlso, Item* skipItem) const
{
uint32 count = 0;
for (uint8 i = EQUIPMENT_SLOT_START; i < INVENTORY_SLOT_ITEM_END; i++)
- if (Item* item = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
- if (item != skipItem && item->GetEntry() == item)
- count += item->GetCount();
+ if (Item* pItem = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
+ if (pItem != skipItem && pItem->GetEntry() == item)
+ count += pItem->GetCount();
for (uint8 i = KEYRING_SLOT_START; i < CURRENCYTOKEN_SLOT_END; ++i)
- if (Item* item = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
- if (item != skipItem && item->GetEntry() == item)
- count += item->GetCount();
+ if (Item* pItem = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
+ if (pItem != skipItem && pItem->GetEntry() == item)
+ count += pItem->GetCount();
for (uint8 i = INVENTORY_SLOT_BAG_START; i < INVENTORY_SLOT_BAG_END; ++i)
if (Bag* pBag = GetBagByPos(i))
@@ -9982,16 +9982,16 @@ uint32 Player::GetItemCount(uint32 item, bool inBankAlso, Item* skipItem) const
if (skipItem && skipItem->GetTemplate()->GemProperties)
for (uint8 i = EQUIPMENT_SLOT_START; i < INVENTORY_SLOT_ITEM_END; ++i)
- if (Item* item = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
- if (item != skipItem && item->GetTemplate()->Socket[0].Color)
- count += item->GetGemCountWithID(item);
+ if (Item* pItem = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
+ if (pItem != skipItem && pItem->GetTemplate()->Socket[0].Color)
+ count += pItem->GetGemCountWithID(item);
if (inBankAlso)
{
for (uint8 i = BANK_SLOT_ITEM_START; i < BANK_SLOT_ITEM_END; ++i)
- if (Item* item = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
- if (item != skipItem && item->GetEntry() == item)
- count += item->GetCount();
+ if (Item* pItem = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
+ if (pItem != skipItem && pItem->GetEntry() == item)
+ count += pItem->GetCount();
for (uint8 i = BANK_SLOT_BAG_START; i < BANK_SLOT_BAG_END; ++i)
if (Bag* pBag = GetBagByPos(i))
@@ -9999,9 +9999,9 @@ uint32 Player::GetItemCount(uint32 item, bool inBankAlso, Item* skipItem) const
if (skipItem && skipItem->GetTemplate()->GemProperties)
for (uint8 i = BANK_SLOT_ITEM_START; i < BANK_SLOT_ITEM_END; ++i)
- if (Item* item = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
- if (item != skipItem && item->GetTemplate()->Socket[0].Color)
- count += item->GetGemCountWithID(item);
+ if (Item* pItem = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
+ if (pItem != skipItem && pItem->GetTemplate()->Socket[0].Color)
+ count += pItem->GetGemCountWithID(item);
}
return count;
@@ -10011,29 +10011,29 @@ uint32 Player::GetItemCountWithLimitCategory(uint32 limitCategory, Item* skipIte
{
uint32 count = 0;
for (int i = EQUIPMENT_SLOT_START; i < INVENTORY_SLOT_ITEM_END; ++i)
- if (Item* item = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
- if (item != skipItem)
- if (ItemTemplate const* pProto = item->GetTemplate())
+ if (Item* pItem = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
+ if (pItem != skipItem)
+ if (ItemTemplate const* pProto = pItem->GetTemplate())
if (pProto->ItemLimitCategory == limitCategory)
- count += item->GetCount();
+ count += pItem->GetCount();
for (int i = KEYRING_SLOT_START; i < CURRENCYTOKEN_SLOT_END; ++i)
- if (Item* item = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
- if (item != skipItem)
- if (ItemTemplate const* pProto = item->GetTemplate())
+ if (Item* pItem = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
+ if (pItem != skipItem)
+ if (ItemTemplate const* pProto = pItem->GetTemplate())
if (pProto->ItemLimitCategory == limitCategory)
- count += item->GetCount();
+ count += pItem->GetCount();
for (int i = INVENTORY_SLOT_BAG_START; i < INVENTORY_SLOT_BAG_END; ++i)
if (Bag* pBag = GetBagByPos(i))
count += pBag->GetItemCountWithLimitCategory(limitCategory, skipItem);
for (int i = BANK_SLOT_ITEM_START; i < BANK_SLOT_ITEM_END; ++i)
- if (Item* item = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
- if (item != skipItem)
- if (ItemTemplate const* pProto = item->GetTemplate())
+ if (Item* pItem = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
+ if (pItem != skipItem)
+ if (ItemTemplate const* pProto = pItem->GetTemplate())
if (pProto->ItemLimitCategory == limitCategory)
- count += item->GetCount();
+ count += pItem->GetCount();
for (int i = BANK_SLOT_BAG_START; i < BANK_SLOT_BAG_END; ++i)
if (Bag* pBag = GetBagByPos(i))
@@ -10045,33 +10045,33 @@ uint32 Player::GetItemCountWithLimitCategory(uint32 limitCategory, Item* skipIte
Item* Player::GetItemByGuid(uint64 guid) const
{
for (uint8 i = EQUIPMENT_SLOT_START; i < INVENTORY_SLOT_ITEM_END; ++i)
- if (Item* item = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
- if (item->GetGUID() == guid)
- return item;
+ if (Item* pItem = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
+ if (pItem->GetGUID() == guid)
+ return pItem;
for (uint8 i = KEYRING_SLOT_START; i < CURRENCYTOKEN_SLOT_END; ++i)
- if (Item* item = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
- if (item->GetGUID() == guid)
- return item;
+ if (Item* pItem = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
+ if (pItem->GetGUID() == guid)
+ return pItem;
for (int i = BANK_SLOT_ITEM_START; i < BANK_SLOT_ITEM_END; ++i)
- if (Item* item = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
- if (item->GetGUID() == guid)
- return item;
+ if (Item* pItem = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
+ if (pItem->GetGUID() == guid)
+ return pItem;
for (uint8 i = INVENTORY_SLOT_BAG_START; i < INVENTORY_SLOT_BAG_END; ++i)
if (Bag* pBag = GetBagByPos(i))
for (uint32 j = 0; j < pBag->GetBagSize(); ++j)
- if (Item* item = pBag->GetItemByPos(j))
- if (item->GetGUID() == guid)
- return item;
+ if (Item* pItem = pBag->GetItemByPos(j))
+ if (pItem->GetGUID() == guid)
+ return pItem;
for (uint8 i = BANK_SLOT_BAG_START; i < BANK_SLOT_BAG_END; ++i)
if (Bag* pBag = GetBagByPos(i))
for (uint32 j = 0; j < pBag->GetBagSize(); ++j)
- if (Item* item = pBag->GetItemByPos(j))
- if (item->GetGUID() == guid)
- return item;
+ if (Item* pItem = pBag->GetItemByPos(j))
+ if (pItem->GetGUID() == guid)
+ return pItem;
return NULL;
}
@@ -10262,20 +10262,20 @@ bool Player::HasItemCount(uint32 item, uint32 count, bool inBankAlso) const
uint32 tempcount = 0;
for (uint8 i = EQUIPMENT_SLOT_START; i < INVENTORY_SLOT_ITEM_END; i++)
{
- Item* item = GetItemByPos(INVENTORY_SLOT_BAG_0, i);
- if (item && item->GetEntry() == item && !item->IsInTrade())
+ Item* pItem = GetItemByPos(INVENTORY_SLOT_BAG_0, i);
+ if (pItem && pItem->GetEntry() == item && !pItem->IsInTrade())
{
- tempcount += item->GetCount();
+ tempcount += pItem->GetCount();
if (tempcount >= count)
return true;
}
}
for (uint8 i = KEYRING_SLOT_START; i < CURRENCYTOKEN_SLOT_END; ++i)
{
- Item* item = GetItemByPos(INVENTORY_SLOT_BAG_0, i);
- if (item && item->GetEntry() == item && !item->IsInTrade())
+ Item* pItem = GetItemByPos(INVENTORY_SLOT_BAG_0, i);
+ if (pItem && pItem->GetEntry() == item && !pItem->IsInTrade())
{
- tempcount += item->GetCount();
+ tempcount += pItem->GetCount();
if (tempcount >= count)
return true;
}
@@ -10286,10 +10286,10 @@ bool Player::HasItemCount(uint32 item, uint32 count, bool inBankAlso) const
{
for (uint32 j = 0; j < pBag->GetBagSize(); j++)
{
- Item* item = GetItemByPos(i, j);
- if (item && item->GetEntry() == item && !item->IsInTrade())
+ Item* pItem = GetItemByPos(i, j);
+ if (pItem && pItem->GetEntry() == item && !pItem->IsInTrade())
{
- tempcount += item->GetCount();
+ tempcount += pItem->GetCount();
if (tempcount >= count)
return true;
}
@@ -10301,10 +10301,10 @@ bool Player::HasItemCount(uint32 item, uint32 count, bool inBankAlso) const
{
for (uint8 i = BANK_SLOT_ITEM_START; i < BANK_SLOT_ITEM_END; i++)
{
- Item* item = GetItemByPos(INVENTORY_SLOT_BAG_0, i);
- if (item && item->GetEntry() == item && !item->IsInTrade())
+ Item* pItem = GetItemByPos(INVENTORY_SLOT_BAG_0, i);
+ if (pItem && pItem->GetEntry() == item && !pItem->IsInTrade())
{
- tempcount += item->GetCount();
+ tempcount += pItem->GetCount();
if (tempcount >= count)
return true;
}
@@ -10315,10 +10315,10 @@ bool Player::HasItemCount(uint32 item, uint32 count, bool inBankAlso) const
{
for (uint32 j = 0; j < pBag->GetBagSize(); j++)
{
- Item* item = GetItemByPos(i, j);
- if (item && item->GetEntry() == item && !item->IsInTrade())
+ Item* pItem = GetItemByPos(i, j);
+ if (pItem && pItem->GetEntry() == item && !pItem->IsInTrade())
{
- tempcount += item->GetCount();
+ tempcount += pItem->GetCount();
if (tempcount >= count)
return true;
}
@@ -10338,10 +10338,10 @@ bool Player::HasItemOrGemWithIdEquipped(uint32 item, uint32 count, uint8 except_
if (i == except_slot)
continue;
- Item* item = GetItemByPos(INVENTORY_SLOT_BAG_0, i);
- if (item && item->GetEntry() == item)
+ Item* pItem = GetItemByPos(INVENTORY_SLOT_BAG_0, i);
+ if (pItem && pItem->GetEntry() == item)
{
- tempcount += item->GetCount();
+ tempcount += pItem->GetCount();
if (tempcount >= count)
return true;
}
@@ -10355,10 +10355,10 @@ bool Player::HasItemOrGemWithIdEquipped(uint32 item, uint32 count, uint8 except_
if (i == except_slot)
continue;
- Item* item = GetItemByPos(INVENTORY_SLOT_BAG_0, i);
- if (item && item->GetTemplate()->Socket[0].Color)
+ Item* pItem = GetItemByPos(INVENTORY_SLOT_BAG_0, i);
+ if (pItem && pItem->GetTemplate()->Socket[0].Color)
{
- tempcount += item->GetGemCountWithID(item);
+ tempcount += pItem->GetGemCountWithID(item);
if (tempcount >= count)
return true;
}
@@ -10376,24 +10376,24 @@ bool Player::HasItemOrGemWithLimitCategoryEquipped(uint32 limitCategory, uint32
if (i == except_slot)
continue;
- Item* item = GetItemByPos(INVENTORY_SLOT_BAG_0, i);
- if (!item)
+ Item* pItem = GetItemByPos(INVENTORY_SLOT_BAG_0, i);
+ if (!pItem)
continue;
- ItemTemplate const* pProto = item->GetTemplate();
+ ItemTemplate const* pProto = pItem->GetTemplate();
if (!pProto)
continue;
if (pProto->ItemLimitCategory == limitCategory)
{
- tempcount += item->GetCount();
+ tempcount += pItem->GetCount();
if (tempcount >= count)
return true;
}
- if (pProto->Socket[0].Color || item->GetEnchantmentId(PRISMATIC_ENCHANTMENT_SLOT))
+ if (pProto->Socket[0].Color || pItem->GetEnchantmentId(PRISMATIC_ENCHANTMENT_SLOT))
{
- tempcount += item->GetGemCountWithLimitCategory(limitCategory);
+ tempcount += pItem->GetGemCountWithLimitCategory(limitCategory);
if (tempcount >= count)
return true;
}
@@ -10402,7 +10402,7 @@ bool Player::HasItemOrGemWithLimitCategoryEquipped(uint32 limitCategory, uint32
return false;
}
-InventoryResult Player::CanTakeMoreSimilarItems(uint32 entry, uint32 count, Item* item, uint32* no_space_count) const
+InventoryResult Player::CanTakeMoreSimilarItems(uint32 entry, uint32 count, Item* pItem, uint32* no_space_count) const
{
ItemTemplate const* pProto = sObjectMgr->GetItemTemplate(entry);
if (!pProto)
@@ -10412,7 +10412,7 @@ InventoryResult Player::CanTakeMoreSimilarItems(uint32 entry, uint32 count, Item
return EQUIP_ERR_CANT_CARRY_MORE_OF_THIS;
}
- if (item && item->m_lootGenerated)
+ if (pItem && pItem->m_lootGenerated)
return EQUIP_ERR_ALREADY_LOOTED;
// no maximum
@@ -10421,7 +10421,7 @@ InventoryResult Player::CanTakeMoreSimilarItems(uint32 entry, uint32 count, Item
if (pProto->MaxCount > 0)
{
- uint32 curcount = GetItemCount(pProto->ItemId, true, item);
+ uint32 curcount = GetItemCount(pProto->ItemId, true, pItem);
if (curcount + count > uint32(pProto->MaxCount))
{
if (no_space_count)
@@ -10443,7 +10443,7 @@ InventoryResult Player::CanTakeMoreSimilarItems(uint32 entry, uint32 count, Item
if (limitEntry->mode == ITEM_LIMIT_CATEGORY_MODE_HAVE)
{
- uint32 curcount = GetItemCountWithLimitCategory(pProto->ItemLimitCategory, item);
+ uint32 curcount = GetItemCountWithLimitCategory(pProto->ItemLimitCategory, pItem);
if (curcount + count > uint32(limitEntry->maxCount))
{
if (no_space_count)
@@ -10458,17 +10458,17 @@ InventoryResult Player::CanTakeMoreSimilarItems(uint32 entry, uint32 count, Item
bool Player::HasItemTotemCategory(uint32 TotemCategory) const
{
- Item* item;
+ Item* pItem;
for (uint8 i = EQUIPMENT_SLOT_START; i < INVENTORY_SLOT_ITEM_END; ++i)
{
- item = GetUseableItemByPos(INVENTORY_SLOT_BAG_0, i);
- if (item && IsTotemCategoryCompatiableWith(item->GetTemplate()->TotemCategory, TotemCategory))
+ pItem = GetUseableItemByPos(INVENTORY_SLOT_BAG_0, i);
+ if (pItem && IsTotemCategoryCompatiableWith(pItem->GetTemplate()->TotemCategory, TotemCategory))
return true;
}
for (uint8 i = KEYRING_SLOT_START; i < CURRENCYTOKEN_SLOT_END; ++i)
{
- item = GetUseableItemByPos(INVENTORY_SLOT_BAG_0, i);
- if (item && IsTotemCategoryCompatiableWith(item->GetTemplate()->TotemCategory, TotemCategory))
+ pItem = GetUseableItemByPos(INVENTORY_SLOT_BAG_0, i);
+ if (pItem && IsTotemCategoryCompatiableWith(pItem->GetTemplate()->TotemCategory, TotemCategory))
return true;
}
for (uint8 i = INVENTORY_SLOT_BAG_START; i < INVENTORY_SLOT_BAG_END; ++i)
@@ -10477,8 +10477,8 @@ bool Player::HasItemTotemCategory(uint32 TotemCategory) const
{
for (uint32 j = 0; j < pBag->GetBagSize(); ++j)
{
- item = GetUseableItemByPos(i, j);
- if (item && IsTotemCategoryCompatiableWith(item->GetTemplate()->TotemCategory, TotemCategory))
+ pItem = GetUseableItemByPos(i, j);
+ if (pItem && IsTotemCategoryCompatiableWith(pItem->GetTemplate()->TotemCategory, TotemCategory))
return true;
}
}
@@ -10681,7 +10681,7 @@ InventoryResult Player::CanStoreItem_InInventorySlots(uint8 slot_begin, uint8 sl
return EQUIP_ERR_OK;
}
-InventoryResult Player::CanStoreItem(uint8 bag, uint8 slot, ItemPosCountVec &dest, uint32 entry, uint32 count, Item* item, bool swap, uint32* no_space_count) const
+InventoryResult Player::CanStoreItem(uint8 bag, uint8 slot, ItemPosCountVec &dest, uint32 entry, uint32 count, Item* pItem, bool swap, uint32* no_space_count) const
{
sLog->outDebug(LOG_FILTER_PLAYER_ITEMS, "STORAGE: CanStoreItem bag = %u, slot = %u, item = %u, count = %u", bag, slot, entry, count);
@@ -10693,17 +10693,17 @@ InventoryResult Player::CanStoreItem(uint8 bag, uint8 slot, ItemPosCountVec &des
return swap ? EQUIP_ERR_ITEMS_CANT_BE_SWAPPED :EQUIP_ERR_ITEM_NOT_FOUND;
}
- if (item)
+ if (pItem)
{
// item used
- if (item->m_lootGenerated)
+ if (pItem->m_lootGenerated)
{
if (no_space_count)
*no_space_count = count;
return EQUIP_ERR_ALREADY_LOOTED;
}
- if (item->IsBindedNotWith(this))
+ if (pItem->IsBindedNotWith(this))
{
if (no_space_count)
*no_space_count = count;
@@ -10713,7 +10713,7 @@ InventoryResult Player::CanStoreItem(uint8 bag, uint8 slot, ItemPosCountVec &des
// check count of items (skip for auto move for same player from bank)
uint32 no_similar_count = 0; // can't store this amount similar items
- InventoryResult res = CanTakeMoreSimilarItems(entry, count, item, &no_similar_count);
+ InventoryResult res = CanTakeMoreSimilarItems(entry, count, pItem, &no_similar_count);
if (res != EQUIP_ERR_OK)
{
if (count == no_similar_count)
@@ -10728,7 +10728,7 @@ InventoryResult Player::CanStoreItem(uint8 bag, uint8 slot, ItemPosCountVec &des
// in specific slot
if (bag != NULL_BAG && slot != NULL_SLOT)
{
- res = CanStoreItem_InSpecificSlot(bag, slot, dest, pProto, count, swap, item);
+ res = CanStoreItem_InSpecificSlot(bag, slot, dest, pProto, count, swap, pItem);
if (res != EQUIP_ERR_OK)
{
if (no_space_count)
@@ -10757,7 +10757,7 @@ InventoryResult Player::CanStoreItem(uint8 bag, uint8 slot, ItemPosCountVec &des
{
if (bag == INVENTORY_SLOT_BAG_0) // inventory
{
- res = CanStoreItem_InInventorySlots(KEYRING_SLOT_START, CURRENCYTOKEN_SLOT_END, dest, pProto, count, true, item, bag, slot);
+ res = CanStoreItem_InInventorySlots(KEYRING_SLOT_START, CURRENCYTOKEN_SLOT_END, dest, pProto, count, true, pItem, bag, slot);
if (res != EQUIP_ERR_OK)
{
if (no_space_count)
@@ -10775,7 +10775,7 @@ InventoryResult Player::CanStoreItem(uint8 bag, uint8 slot, ItemPosCountVec &des
return EQUIP_ERR_CANT_CARRY_MORE_OF_THIS;
}
- res = CanStoreItem_InInventorySlots(INVENTORY_SLOT_ITEM_START, INVENTORY_SLOT_ITEM_END, dest, pProto, count, true, item, bag, slot);
+ res = CanStoreItem_InInventorySlots(INVENTORY_SLOT_ITEM_START, INVENTORY_SLOT_ITEM_END, dest, pProto, count, true, pItem, bag, slot);
if (res != EQUIP_ERR_OK)
{
if (no_space_count)
@@ -10796,9 +10796,9 @@ InventoryResult Player::CanStoreItem(uint8 bag, uint8 slot, ItemPosCountVec &des
else // equipped bag
{
// we need check 2 time (specialized/non_specialized), use NULL_BAG to prevent skipping bag
- res = CanStoreItem_InBag(bag, dest, pProto, count, true, false, item, NULL_BAG, slot);
+ res = CanStoreItem_InBag(bag, dest, pProto, count, true, false, pItem, NULL_BAG, slot);
if (res != EQUIP_ERR_OK)
- res = CanStoreItem_InBag(bag, dest, pProto, count, true, true, item, NULL_BAG, slot);
+ res = CanStoreItem_InBag(bag, dest, pProto, count, true, true, pItem, NULL_BAG, slot);
if (res != EQUIP_ERR_OK)
{
@@ -10826,7 +10826,7 @@ InventoryResult Player::CanStoreItem(uint8 bag, uint8 slot, ItemPosCountVec &des
if (pProto->BagFamily & BAG_FAMILY_MASK_KEYS)
{
uint32 keyringSize = GetMaxKeyringSize();
- res = CanStoreItem_InInventorySlots(KEYRING_SLOT_START, KEYRING_SLOT_START+keyringSize, dest, pProto, count, false, item, bag, slot);
+ res = CanStoreItem_InInventorySlots(KEYRING_SLOT_START, KEYRING_SLOT_START+keyringSize, dest, pProto, count, false, pItem, bag, slot);
if (res != EQUIP_ERR_OK)
{
if (no_space_count)
@@ -10844,7 +10844,7 @@ InventoryResult Player::CanStoreItem(uint8 bag, uint8 slot, ItemPosCountVec &des
return EQUIP_ERR_CANT_CARRY_MORE_OF_THIS;
}
- res = CanStoreItem_InInventorySlots(CURRENCYTOKEN_SLOT_START, CURRENCYTOKEN_SLOT_END, dest, pProto, count, false, item, bag, slot);
+ res = CanStoreItem_InInventorySlots(CURRENCYTOKEN_SLOT_START, CURRENCYTOKEN_SLOT_END, dest, pProto, count, false, pItem, bag, slot);
if (res != EQUIP_ERR_OK)
{
if (no_space_count)
@@ -10864,7 +10864,7 @@ InventoryResult Player::CanStoreItem(uint8 bag, uint8 slot, ItemPosCountVec &des
}
else if (pProto->BagFamily & BAG_FAMILY_MASK_CURRENCY_TOKENS)
{
- res = CanStoreItem_InInventorySlots(CURRENCYTOKEN_SLOT_START, CURRENCYTOKEN_SLOT_END, dest, pProto, count, false, item, bag, slot);
+ res = CanStoreItem_InInventorySlots(CURRENCYTOKEN_SLOT_START, CURRENCYTOKEN_SLOT_END, dest, pProto, count, false, pItem, bag, slot);
if (res != EQUIP_ERR_OK)
{
if (no_space_count)
@@ -10883,7 +10883,7 @@ InventoryResult Player::CanStoreItem(uint8 bag, uint8 slot, ItemPosCountVec &des
}
}
- res = CanStoreItem_InInventorySlots(INVENTORY_SLOT_ITEM_START, INVENTORY_SLOT_ITEM_END, dest, pProto, count, false, item, bag, slot);
+ res = CanStoreItem_InInventorySlots(INVENTORY_SLOT_ITEM_START, INVENTORY_SLOT_ITEM_END, dest, pProto, count, false, pItem, bag, slot);
if (res != EQUIP_ERR_OK)
{
if (no_space_count)
@@ -10903,9 +10903,9 @@ InventoryResult Player::CanStoreItem(uint8 bag, uint8 slot, ItemPosCountVec &des
}
else // equipped bag
{
- res = CanStoreItem_InBag(bag, dest, pProto, count, false, false, item, NULL_BAG, slot);
+ res = CanStoreItem_InBag(bag, dest, pProto, count, false, false, pItem, NULL_BAG, slot);
if (res != EQUIP_ERR_OK)
- res = CanStoreItem_InBag(bag, dest, pProto, count, false, true, item, NULL_BAG, slot);
+ res = CanStoreItem_InBag(bag, dest, pProto, count, false, true, pItem, NULL_BAG, slot);
if (res != EQUIP_ERR_OK)
{
@@ -10931,7 +10931,7 @@ InventoryResult Player::CanStoreItem(uint8 bag, uint8 slot, ItemPosCountVec &des
// search stack for merge to
if (pProto->Stackable != 1)
{
- res = CanStoreItem_InInventorySlots(KEYRING_SLOT_START, CURRENCYTOKEN_SLOT_END, dest, pProto, count, true, item, bag, slot);
+ res = CanStoreItem_InInventorySlots(KEYRING_SLOT_START, CURRENCYTOKEN_SLOT_END, dest, pProto, count, true, pItem, bag, slot);
if (res != EQUIP_ERR_OK)
{
if (no_space_count)
@@ -10949,7 +10949,7 @@ InventoryResult Player::CanStoreItem(uint8 bag, uint8 slot, ItemPosCountVec &des
return EQUIP_ERR_CANT_CARRY_MORE_OF_THIS;
}
- res = CanStoreItem_InInventorySlots(INVENTORY_SLOT_ITEM_START, INVENTORY_SLOT_ITEM_END, dest, pProto, count, true, item, bag, slot);
+ res = CanStoreItem_InInventorySlots(INVENTORY_SLOT_ITEM_START, INVENTORY_SLOT_ITEM_END, dest, pProto, count, true, pItem, bag, slot);
if (res != EQUIP_ERR_OK)
{
if (no_space_count)
@@ -10971,7 +10971,7 @@ InventoryResult Player::CanStoreItem(uint8 bag, uint8 slot, ItemPosCountVec &des
{
for (uint32 i = INVENTORY_SLOT_BAG_START; i < INVENTORY_SLOT_BAG_END; i++)
{
- res = CanStoreItem_InBag(i, dest, pProto, count, true, false, item, bag, slot);
+ res = CanStoreItem_InBag(i, dest, pProto, count, true, false, pItem, bag, slot);
if (res != EQUIP_ERR_OK)
continue;
@@ -10989,7 +10989,7 @@ InventoryResult Player::CanStoreItem(uint8 bag, uint8 slot, ItemPosCountVec &des
for (uint32 i = INVENTORY_SLOT_BAG_START; i < INVENTORY_SLOT_BAG_END; i++)
{
- res = CanStoreItem_InBag(i, dest, pProto, count, true, true, item, bag, slot);
+ res = CanStoreItem_InBag(i, dest, pProto, count, true, true, pItem, bag, slot);
if (res != EQUIP_ERR_OK)
continue;
@@ -11011,7 +11011,7 @@ InventoryResult Player::CanStoreItem(uint8 bag, uint8 slot, ItemPosCountVec &des
if (pProto->BagFamily & BAG_FAMILY_MASK_KEYS)
{
uint32 keyringSize = GetMaxKeyringSize();
- res = CanStoreItem_InInventorySlots(KEYRING_SLOT_START, KEYRING_SLOT_START+keyringSize, dest, pProto, count, false, item, bag, slot);
+ res = CanStoreItem_InInventorySlots(KEYRING_SLOT_START, KEYRING_SLOT_START+keyringSize, dest, pProto, count, false, pItem, bag, slot);
if (res != EQUIP_ERR_OK)
{
if (no_space_count)
@@ -11031,7 +11031,7 @@ InventoryResult Player::CanStoreItem(uint8 bag, uint8 slot, ItemPosCountVec &des
}
else if (pProto->BagFamily & BAG_FAMILY_MASK_CURRENCY_TOKENS)
{
- res = CanStoreItem_InInventorySlots(CURRENCYTOKEN_SLOT_START, CURRENCYTOKEN_SLOT_END, dest, pProto, count, false, item, bag, slot);
+ res = CanStoreItem_InInventorySlots(CURRENCYTOKEN_SLOT_START, CURRENCYTOKEN_SLOT_END, dest, pProto, count, false, pItem, bag, slot);
if (res != EQUIP_ERR_OK)
{
if (no_space_count)
@@ -11052,7 +11052,7 @@ InventoryResult Player::CanStoreItem(uint8 bag, uint8 slot, ItemPosCountVec &des
for (uint32 i = INVENTORY_SLOT_BAG_START; i < INVENTORY_SLOT_BAG_END; i++)
{
- res = CanStoreItem_InBag(i, dest, pProto, count, false, false, item, bag, slot);
+ res = CanStoreItem_InBag(i, dest, pProto, count, false, false, pItem, bag, slot);
if (res != EQUIP_ERR_OK)
continue;
@@ -11068,11 +11068,11 @@ InventoryResult Player::CanStoreItem(uint8 bag, uint8 slot, ItemPosCountVec &des
}
}
- if (item && item->IsNotEmptyBag())
+ if (pItem && pItem->IsNotEmptyBag())
return EQUIP_ERR_NONEMPTY_BAG_OVER_OTHER_BAG;
// search free slot
- res = CanStoreItem_InInventorySlots(INVENTORY_SLOT_ITEM_START, INVENTORY_SLOT_ITEM_END, dest, pProto, count, false, item, bag, slot);
+ res = CanStoreItem_InInventorySlots(INVENTORY_SLOT_ITEM_START, INVENTORY_SLOT_ITEM_END, dest, pProto, count, false, pItem, bag, slot);
if (res != EQUIP_ERR_OK)
{
if (no_space_count)
@@ -11092,7 +11092,7 @@ InventoryResult Player::CanStoreItem(uint8 bag, uint8 slot, ItemPosCountVec &des
for (uint8 i = INVENTORY_SLOT_BAG_START; i < INVENTORY_SLOT_BAG_END; i++)
{
- res = CanStoreItem_InBag(i, dest, pProto, count, false, true, item, bag, slot);
+ res = CanStoreItem_InBag(i, dest, pProto, count, false, true, pItem, bag, slot);
if (res != EQUIP_ERR_OK)
continue;
@@ -11162,30 +11162,30 @@ InventoryResult Player::CanStoreItems(Item** pItems, int count) const
// check free space for all items
for (int k = 0; k < count; ++k)
{
- Item* item = pItems[k];
+ Item* pItem = pItems[k];
// no item
- if (!item) continue;
+ if (!pItem) continue;
- sLog->outDebug(LOG_FILTER_PLAYER_ITEMS, "STORAGE: CanStoreItems %i. item = %u, count = %u", k + 1, item->GetEntry(), item->GetCount());
- ItemTemplate const* pProto = item->GetTemplate();
+ sLog->outDebug(LOG_FILTER_PLAYER_ITEMS, "STORAGE: CanStoreItems %i. item = %u, count = %u", k + 1, pItem->GetEntry(), pItem->GetCount());
+ ItemTemplate const* pProto = pItem->GetTemplate();
// strange item
if (!pProto)
return EQUIP_ERR_ITEM_NOT_FOUND;
// item used
- if (item->m_lootGenerated)
+ if (pItem->m_lootGenerated)
return EQUIP_ERR_ALREADY_LOOTED;
// item it 'bind'
- if (item->IsBindedNotWith(this))
+ if (pItem->IsBindedNotWith(this))
return EQUIP_ERR_DONT_OWN_THAT_ITEM;
ItemTemplate const* pBagProto;
// item is 'one item only'
- InventoryResult res = CanTakeMoreSimilarItems(item);
+ InventoryResult res = CanTakeMoreSimilarItems(pItem);
if (res != EQUIP_ERR_OK)
return res;
@@ -11197,9 +11197,9 @@ InventoryResult Player::CanStoreItems(Item** pItems, int count) const
for (uint8 t = KEYRING_SLOT_START; t < KEYRING_SLOT_END; ++t)
{
pItem2 = GetItemByPos(INVENTORY_SLOT_BAG_0, t);
- if (pItem2 && pItem2->CanBeMergedPartlyWith(pProto) == EQUIP_ERR_OK && inv_keys[t-KEYRING_SLOT_START] + item->GetCount() <= pProto->GetMaxStackSize())
+ if (pItem2 && pItem2->CanBeMergedPartlyWith(pProto) == EQUIP_ERR_OK && inv_keys[t-KEYRING_SLOT_START] + pItem->GetCount() <= pProto->GetMaxStackSize())
{
- inv_keys[t-KEYRING_SLOT_START] += item->GetCount();
+ inv_keys[t-KEYRING_SLOT_START] += pItem->GetCount();
b_found = true;
break;
}
@@ -11209,9 +11209,9 @@ InventoryResult Player::CanStoreItems(Item** pItems, int count) const
for (int t = CURRENCYTOKEN_SLOT_START; t < CURRENCYTOKEN_SLOT_END; ++t)
{
pItem2 = GetItemByPos(INVENTORY_SLOT_BAG_0, t);
- if (pItem2 && pItem2->CanBeMergedPartlyWith(pProto) == EQUIP_ERR_OK && inv_tokens[t-CURRENCYTOKEN_SLOT_START] + item->GetCount() <= pProto->GetMaxStackSize())
+ if (pItem2 && pItem2->CanBeMergedPartlyWith(pProto) == EQUIP_ERR_OK && inv_tokens[t-CURRENCYTOKEN_SLOT_START] + pItem->GetCount() <= pProto->GetMaxStackSize())
{
- inv_tokens[t-CURRENCYTOKEN_SLOT_START] += item->GetCount();
+ inv_tokens[t-CURRENCYTOKEN_SLOT_START] += pItem->GetCount();
b_found = true;
break;
}
@@ -11221,9 +11221,9 @@ InventoryResult Player::CanStoreItems(Item** pItems, int count) const
for (int t = INVENTORY_SLOT_ITEM_START; t < INVENTORY_SLOT_ITEM_END; ++t)
{
pItem2 = GetItemByPos(INVENTORY_SLOT_BAG_0, t);
- if (pItem2 && pItem2->CanBeMergedPartlyWith(pProto) == EQUIP_ERR_OK && inv_slot_items[t-INVENTORY_SLOT_ITEM_START] + item->GetCount() <= pProto->GetMaxStackSize())
+ if (pItem2 && pItem2->CanBeMergedPartlyWith(pProto) == EQUIP_ERR_OK && inv_slot_items[t-INVENTORY_SLOT_ITEM_START] + pItem->GetCount() <= pProto->GetMaxStackSize())
{
- inv_slot_items[t-INVENTORY_SLOT_ITEM_START] += item->GetCount();
+ inv_slot_items[t-INVENTORY_SLOT_ITEM_START] += pItem->GetCount();
b_found = true;
break;
}
@@ -11234,14 +11234,14 @@ InventoryResult Player::CanStoreItems(Item** pItems, int count) const
{
if (Bag* bag = GetBagByPos(t))
{
- if (ItemCanGoIntoBag(item->GetTemplate(), bag->GetTemplate()))
+ if (ItemCanGoIntoBag(pItem->GetTemplate(), bag->GetTemplate()))
{
for (uint32 j = 0; j < bag->GetBagSize(); j++)
{
pItem2 = GetItemByPos(t, j);
- if (pItem2 && pItem2->CanBeMergedPartlyWith(pProto) == EQUIP_ERR_OK && inv_bags[t-INVENTORY_SLOT_BAG_START][j] + item->GetCount() <= pProto->GetMaxStackSize())
+ if (pItem2 && pItem2->CanBeMergedPartlyWith(pProto) == EQUIP_ERR_OK && inv_bags[t-INVENTORY_SLOT_BAG_START][j] + pItem->GetCount() <= pProto->GetMaxStackSize())
{
- inv_bags[t-INVENTORY_SLOT_BAG_START][j] += item->GetCount();
+ inv_bags[t-INVENTORY_SLOT_BAG_START][j] += pItem->GetCount();
b_found = true;
break;
}
@@ -11360,35 +11360,35 @@ InventoryResult Player::CanStoreItems(Item** pItems, int count) const
InventoryResult Player::CanEquipNewItem(uint8 slot, uint16 &dest, uint32 item, bool swap) const
{
dest = 0;
- Item* item = Item::CreateItem(item, 1, this);
- if (item)
+ Item* pItem = Item::CreateItem(item, 1, this);
+ if (pItem)
{
- InventoryResult result = CanEquipItem(slot, dest, item, swap);
- delete item;
+ InventoryResult result = CanEquipItem(slot, dest, pItem, swap);
+ delete pItem;
return result;
}
return EQUIP_ERR_ITEM_NOT_FOUND;
}
-InventoryResult Player::CanEquipItem(uint8 slot, uint16 &dest, Item* item, bool swap, bool not_loading) const
+InventoryResult Player::CanEquipItem(uint8 slot, uint16 &dest, Item* pItem, bool swap, bool not_loading) const
{
dest = 0;
- if (item)
+ if (pItem)
{
- sLog->outDebug(LOG_FILTER_PLAYER_ITEMS, "STORAGE: CanEquipItem slot = %u, item = %u, count = %u", slot, item->GetEntry(), item->GetCount());
- ItemTemplate const* pProto = item->GetTemplate();
+ sLog->outDebug(LOG_FILTER_PLAYER_ITEMS, "STORAGE: CanEquipItem slot = %u, item = %u, count = %u", slot, pItem->GetEntry(), pItem->GetCount());
+ ItemTemplate const* pProto = pItem->GetTemplate();
if (pProto)
{
// item used
- if (item->m_lootGenerated)
+ if (pItem->m_lootGenerated)
return EQUIP_ERR_ALREADY_LOOTED;
- if (item->IsBindedNotWith(this))
+ if (pItem->IsBindedNotWith(this))
return EQUIP_ERR_DONT_OWN_THAT_ITEM;
// check count of items (skip for auto move for same player from bank)
- InventoryResult res = CanTakeMoreSimilarItems(item);
+ InventoryResult res = CanTakeMoreSimilarItems(pItem);
if (res != EQUIP_ERR_OK)
return res;
@@ -11429,7 +11429,7 @@ InventoryResult Player::CanEquipItem(uint8 slot, uint16 &dest, Item* item, bool
if (eslot == NULL_SLOT)
return EQUIP_ERR_ITEM_CANT_BE_EQUIPPED;
- res = CanUseItem(item, not_loading);
+ res = CanUseItem(pItem, not_loading);
if (res != EQUIP_ERR_OK)
return res;
@@ -11437,7 +11437,7 @@ InventoryResult Player::CanEquipItem(uint8 slot, uint16 &dest, Item* item, bool
return EQUIP_ERR_NO_EQUIPMENT_SLOT_AVAILABLE;
// if swap ignore item (equipped also)
- InventoryResult res2 = CanEquipUniqueItem(item, swap ? eslot : uint8(NULL_SLOT));
+ InventoryResult res2 = CanEquipUniqueItem(pItem, swap ? eslot : uint8(NULL_SLOT));
if (res2 != EQUIP_ERR_OK)
return res2;
@@ -11445,7 +11445,7 @@ InventoryResult Player::CanEquipItem(uint8 slot, uint16 &dest, Item* item, bool
if (pProto->Class == ITEM_CLASS_QUIVER)
for (uint8 i = INVENTORY_SLOT_BAG_START; i < INVENTORY_SLOT_BAG_END; ++i)
if (Item* pBag = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
- if (pBag != item)
+ if (pBag != pItem)
if (ItemTemplate const* pBagProto = pBag->GetTemplate())
if (pBagProto->Class == pProto->Class && (!swap || pBag->GetSlot() != eslot))
return (pBagProto->SubClass == ITEM_SUBCLASS_AMMO_POUCH)
@@ -11507,20 +11507,20 @@ InventoryResult Player::CanUnequipItem(uint16 pos, bool swap) const
if (!IsEquipmentPos(pos) && !IsBagPos(pos))
return EQUIP_ERR_OK;
- Item* item = GetItemByPos(pos);
+ Item* pItem = GetItemByPos(pos);
// Applied only to existed equipped item
- if (!item)
+ if (!pItem)
return EQUIP_ERR_OK;
- sLog->outDebug(LOG_FILTER_PLAYER_ITEMS, "STORAGE: CanUnequipItem slot = %u, item = %u, count = %u", pos, item->GetEntry(), item->GetCount());
+ sLog->outDebug(LOG_FILTER_PLAYER_ITEMS, "STORAGE: CanUnequipItem slot = %u, item = %u, count = %u", pos, pItem->GetEntry(), pItem->GetCount());
- ItemTemplate const* pProto = item->GetTemplate();
+ ItemTemplate const* pProto = pItem->GetTemplate();
if (!pProto)
return EQUIP_ERR_ITEM_NOT_FOUND;
// item used
- if (item->m_lootGenerated)
+ if (pItem->m_lootGenerated)
return EQUIP_ERR_ALREADY_LOOTED;
// do not allow unequipping gear except weapons, offhands, projectiles, relics in
@@ -11536,42 +11536,42 @@ InventoryResult Player::CanUnequipItem(uint16 pos, bool swap) const
return EQUIP_ERR_NOT_DURING_ARENA_MATCH;
}
- if (!swap && item->IsNotEmptyBag())
+ if (!swap && pItem->IsNotEmptyBag())
return EQUIP_ERR_CAN_ONLY_DO_WITH_EMPTY_BAGS;
return EQUIP_ERR_OK;
}
-InventoryResult Player::CanBankItem(uint8 bag, uint8 slot, ItemPosCountVec &dest, Item* item, bool swap, bool not_loading) const
+InventoryResult Player::CanBankItem(uint8 bag, uint8 slot, ItemPosCountVec &dest, Item* pItem, bool swap, bool not_loading) const
{
- if (!item)
+ if (!pItem)
return swap ? EQUIP_ERR_ITEMS_CANT_BE_SWAPPED : EQUIP_ERR_ITEM_NOT_FOUND;
- uint32 count = item->GetCount();
+ uint32 count = pItem->GetCount();
- sLog->outDebug(LOG_FILTER_PLAYER_ITEMS, "STORAGE: CanBankItem bag = %u, slot = %u, item = %u, count = %u", bag, slot, item->GetEntry(), item->GetCount());
- ItemTemplate const* pProto = item->GetTemplate();
+ sLog->outDebug(LOG_FILTER_PLAYER_ITEMS, "STORAGE: CanBankItem bag = %u, slot = %u, item = %u, count = %u", bag, slot, pItem->GetEntry(), pItem->GetCount());
+ ItemTemplate const* pProto = pItem->GetTemplate();
if (!pProto)
return swap ? EQUIP_ERR_ITEMS_CANT_BE_SWAPPED : EQUIP_ERR_ITEM_NOT_FOUND;
// item used
- if (item->m_lootGenerated)
+ if (pItem->m_lootGenerated)
return EQUIP_ERR_ALREADY_LOOTED;
- if (item->IsBindedNotWith(this))
+ if (pItem->IsBindedNotWith(this))
return EQUIP_ERR_DONT_OWN_THAT_ITEM;
// Currency tokens are not supposed to be swapped out of their hidden bag
- uint8 pItemslot = item->GetSlot();
+ uint8 pItemslot = pItem->GetSlot();
if (pItemslot >= CURRENCYTOKEN_SLOT_START && pItemslot < CURRENCYTOKEN_SLOT_END)
{
sLog->outError("Possible hacking attempt: Player %s [guid: %u] tried to move token [guid: %u, entry: %u] out of the currency bag!",
- GetName(), GetGUIDLow(), item->GetGUIDLow(), pProto->ItemId);
+ GetName(), GetGUIDLow(), pItem->GetGUIDLow(), pProto->ItemId);
return EQUIP_ERR_ITEMS_CANT_BE_SWAPPED;
}
// check count of items (skip for auto move for same player from bank)
- InventoryResult res = CanTakeMoreSimilarItems(item);
+ InventoryResult res = CanTakeMoreSimilarItems(pItem);
if (res != EQUIP_ERR_OK)
return res;
@@ -11580,18 +11580,18 @@ InventoryResult Player::CanBankItem(uint8 bag, uint8 slot, ItemPosCountVec &dest
{
if (slot >= BANK_SLOT_BAG_START && slot < BANK_SLOT_BAG_END)
{
- if (!item->IsBag())
+ if (!pItem->IsBag())
return EQUIP_ERR_ITEM_DOESNT_GO_TO_SLOT;
if (slot - BANK_SLOT_BAG_START >= GetBankBagSlotCount())
return EQUIP_ERR_MUST_PURCHASE_THAT_BAG_SLOT;
- res = CanUseItem(item, not_loading);
+ res = CanUseItem(pItem, not_loading);
if (res != EQUIP_ERR_OK)
return res;
}
- res = CanStoreItem_InSpecificSlot(bag, slot, dest, pProto, count, swap, item);
+ res = CanStoreItem_InSpecificSlot(bag, slot, dest, pProto, count, swap, pItem);
if (res != EQUIP_ERR_OK)
return res;
@@ -11604,7 +11604,7 @@ InventoryResult Player::CanBankItem(uint8 bag, uint8 slot, ItemPosCountVec &dest
// in specific bag
if (bag != NULL_BAG)
{
- if (item->IsNotEmptyBag())
+ if (pItem->IsNotEmptyBag())
return EQUIP_ERR_NONEMPTY_BAG_OVER_OTHER_BAG;
// search stack in bag for merge to
@@ -11612,7 +11612,7 @@ InventoryResult Player::CanBankItem(uint8 bag, uint8 slot, ItemPosCountVec &dest
{
if (bag == INVENTORY_SLOT_BAG_0)
{
- res = CanStoreItem_InInventorySlots(BANK_SLOT_ITEM_START, BANK_SLOT_ITEM_END, dest, pProto, count, true, item, bag, slot);
+ res = CanStoreItem_InInventorySlots(BANK_SLOT_ITEM_START, BANK_SLOT_ITEM_END, dest, pProto, count, true, pItem, bag, slot);
if (res != EQUIP_ERR_OK)
return res;
@@ -11621,9 +11621,9 @@ InventoryResult Player::CanBankItem(uint8 bag, uint8 slot, ItemPosCountVec &dest
}
else
{
- res = CanStoreItem_InBag(bag, dest, pProto, count, true, false, item, NULL_BAG, slot);
+ res = CanStoreItem_InBag(bag, dest, pProto, count, true, false, pItem, NULL_BAG, slot);
if (res != EQUIP_ERR_OK)
- res = CanStoreItem_InBag(bag, dest, pProto, count, true, true, item, NULL_BAG, slot);
+ res = CanStoreItem_InBag(bag, dest, pProto, count, true, true, pItem, NULL_BAG, slot);
if (res != EQUIP_ERR_OK)
return res;
@@ -11636,7 +11636,7 @@ InventoryResult Player::CanBankItem(uint8 bag, uint8 slot, ItemPosCountVec &dest
// search free slot in bag
if (bag == INVENTORY_SLOT_BAG_0)
{
- res = CanStoreItem_InInventorySlots(BANK_SLOT_ITEM_START, BANK_SLOT_ITEM_END, dest, pProto, count, false, item, bag, slot);
+ res = CanStoreItem_InInventorySlots(BANK_SLOT_ITEM_START, BANK_SLOT_ITEM_END, dest, pProto, count, false, pItem, bag, slot);
if (res != EQUIP_ERR_OK)
return res;
@@ -11645,9 +11645,9 @@ InventoryResult Player::CanBankItem(uint8 bag, uint8 slot, ItemPosCountVec &dest
}
else
{
- res = CanStoreItem_InBag(bag, dest, pProto, count, false, false, item, NULL_BAG, slot);
+ res = CanStoreItem_InBag(bag, dest, pProto, count, false, false, pItem, NULL_BAG, slot);
if (res != EQUIP_ERR_OK)
- res = CanStoreItem_InBag(bag, dest, pProto, count, false, true, item, NULL_BAG, slot);
+ res = CanStoreItem_InBag(bag, dest, pProto, count, false, true, pItem, NULL_BAG, slot);
if (res != EQUIP_ERR_OK)
return res;
@@ -11663,7 +11663,7 @@ InventoryResult Player::CanBankItem(uint8 bag, uint8 slot, ItemPosCountVec &dest
if (pProto->Stackable != 1)
{
// in slots
- res = CanStoreItem_InInventorySlots(BANK_SLOT_ITEM_START, BANK_SLOT_ITEM_END, dest, pProto, count, true, item, bag, slot);
+ res = CanStoreItem_InInventorySlots(BANK_SLOT_ITEM_START, BANK_SLOT_ITEM_END, dest, pProto, count, true, pItem, bag, slot);
if (res != EQUIP_ERR_OK)
return res;
@@ -11675,7 +11675,7 @@ InventoryResult Player::CanBankItem(uint8 bag, uint8 slot, ItemPosCountVec &dest
{
for (uint8 i = BANK_SLOT_BAG_START; i < BANK_SLOT_BAG_END; i++)
{
- res = CanStoreItem_InBag(i, dest, pProto, count, true, false, item, bag, slot);
+ res = CanStoreItem_InBag(i, dest, pProto, count, true, false, pItem, bag, slot);
if (res != EQUIP_ERR_OK)
continue;
@@ -11686,7 +11686,7 @@ InventoryResult Player::CanBankItem(uint8 bag, uint8 slot, ItemPosCountVec &dest
for (uint8 i = BANK_SLOT_BAG_START; i < BANK_SLOT_BAG_END; i++)
{
- res = CanStoreItem_InBag(i, dest, pProto, count, true, true, item, bag, slot);
+ res = CanStoreItem_InBag(i, dest, pProto, count, true, true, pItem, bag, slot);
if (res != EQUIP_ERR_OK)
continue;
@@ -11700,7 +11700,7 @@ InventoryResult Player::CanBankItem(uint8 bag, uint8 slot, ItemPosCountVec &dest
{
for (uint8 i = BANK_SLOT_BAG_START; i < BANK_SLOT_BAG_END; i++)
{
- res = CanStoreItem_InBag(i, dest, pProto, count, false, false, item, bag, slot);
+ res = CanStoreItem_InBag(i, dest, pProto, count, false, false, pItem, bag, slot);
if (res != EQUIP_ERR_OK)
continue;
@@ -11710,7 +11710,7 @@ InventoryResult Player::CanBankItem(uint8 bag, uint8 slot, ItemPosCountVec &dest
}
// search free space
- res = CanStoreItem_InInventorySlots(BANK_SLOT_ITEM_START, BANK_SLOT_ITEM_END, dest, pProto, count, false, item, bag, slot);
+ res = CanStoreItem_InInventorySlots(BANK_SLOT_ITEM_START, BANK_SLOT_ITEM_END, dest, pProto, count, false, pItem, bag, slot);
if (res != EQUIP_ERR_OK)
return res;
@@ -11719,7 +11719,7 @@ InventoryResult Player::CanBankItem(uint8 bag, uint8 slot, ItemPosCountVec &dest
for (uint8 i = BANK_SLOT_BAG_START; i < BANK_SLOT_BAG_END; i++)
{
- res = CanStoreItem_InBag(i, dest, pProto, count, false, true, item, bag, slot);
+ res = CanStoreItem_InBag(i, dest, pProto, count, false, true, pItem, bag, slot);
if (res != EQUIP_ERR_OK)
continue;
@@ -11729,11 +11729,11 @@ InventoryResult Player::CanBankItem(uint8 bag, uint8 slot, ItemPosCountVec &dest
return EQUIP_ERR_BANK_FULL;
}
-InventoryResult Player::CanUseItem(Item* item, bool not_loading) const
+InventoryResult Player::CanUseItem(Item* pItem, bool not_loading) const
{
- if (item)
+ if (pItem)
{
- sLog->outDebug(LOG_FILTER_PLAYER_ITEMS, "STORAGE: CanUseItem item = %u", item->GetEntry());
+ sLog->outDebug(LOG_FILTER_PLAYER_ITEMS, "STORAGE: CanUseItem item = %u", pItem->GetEntry());
if (!isAlive() && not_loading)
return EQUIP_ERR_YOU_ARE_DEAD;
@@ -11741,20 +11741,20 @@ InventoryResult Player::CanUseItem(Item* item, bool not_loading) const
//if (isStunned())
// return EQUIP_ERR_YOU_ARE_STUNNED;
- ItemTemplate const* pProto = item->GetTemplate();
+ ItemTemplate const* pProto = pItem->GetTemplate();
if (pProto)
{
- if (item->IsBindedNotWith(this))
+ if (pItem->IsBindedNotWith(this))
return EQUIP_ERR_DONT_OWN_THAT_ITEM;
InventoryResult res = CanUseItem(pProto);
if (res != EQUIP_ERR_OK)
return res;
- if (item->GetSkill() != 0)
+ if (pItem->GetSkill() != 0)
{
bool allowEquip = false;
- uint32 itemSkill = item->GetSkill();
+ uint32 itemSkill = pItem->GetSkill();
// Armor that is binded to account can "morph" from plate to mail, etc. if skill is not learned yet.
if (pProto->Quality == ITEM_QUALITY_HEIRLOOM && pProto->Class == ITEM_CLASS_ARMOR && !HasSkill(itemSkill))
{
@@ -11985,33 +11985,33 @@ Item* Player::StoreNewItem(ItemPosCountVec const& dest, uint32 item, bool update
return StoreNewItem(dest, item, update, randomPropertyId, allowedLooters);
}
-// Return stored item (if stored to stack, it can diff. from item). And item ca be deleted in this case.
+// Return stored item (if stored to stack, it can diff. from pItem). And pItem ca be deleted in this case.
Item* Player::StoreNewItem(ItemPosCountVec const& dest, uint32 item, bool update, int32 randomPropertyId, AllowedLooterSet& allowedLooters)
{
uint32 count = 0;
for (ItemPosCountVec::const_iterator itr = dest.begin(); itr != dest.end(); ++itr)
count += itr->count;
- Item* item = Item::CreateItem(item, count, this);
- if (item)
+ Item* pItem = Item::CreateItem(item, count, this);
+ if (pItem)
{
ItemAddedQuestCheck(item, count);
GetAchievementMgr().UpdateAchievementCriteria(ACHIEVEMENT_CRITERIA_TYPE_RECEIVE_EPIC_ITEM, item, count);
GetAchievementMgr().UpdateAchievementCriteria(ACHIEVEMENT_CRITERIA_TYPE_OWN_ITEM, item, 1);
if (randomPropertyId)
- item->SetItemRandomProperties(randomPropertyId);
- item = StoreItem(dest, item, update);
+ pItem->SetItemRandomProperties(randomPropertyId);
+ pItem = StoreItem(dest, pItem, update);
- const ItemTemplate* proto = item->GetTemplate();
+ const ItemTemplate* proto = pItem->GetTemplate();
for (uint8 i = 0; i < MAX_ITEM_PROTO_SPELLS; ++i)
if (proto->Spells[i].SpellTrigger == ITEM_SPELLTRIGGER_ON_NO_DELAY_USE && proto->Spells[i].SpellId > 0) // On obtain trigger
- CastSpell(this, proto->Spells[i].SpellId, true, item);
+ CastSpell(this, proto->Spells[i].SpellId, true, pItem);
- if (allowedLooters.size() > 1 && item->GetTemplate()->GetMaxStackSize() == 1 && item->IsSoulBound())
+ if (allowedLooters.size() > 1 && pItem->GetTemplate()->GetMaxStackSize() == 1 && pItem->IsSoulBound())
{
- item->SetSoulboundTradeable(allowedLooters);
- item->SetUInt32Value(ITEM_FIELD_CREATE_PLAYED_TIME, GetTotalPlayedTime());
- AddTradeableItem(item);
+ pItem->SetSoulboundTradeable(allowedLooters);
+ pItem->SetUInt32Value(ITEM_FIELD_CREATE_PLAYED_TIME, GetTotalPlayedTime());
+ AddTradeableItem(pItem);
// save data
std::ostringstream ss;
@@ -12021,20 +12021,20 @@ Item* Player::StoreNewItem(ItemPosCountVec const& dest, uint32 item, bool update
ss << ' ' << *itr;
PreparedStatement* stmt = CharacterDatabase.GetPreparedStatement(CHAR_INS_ITEM_BOP_TRADE);
- stmt->setUInt32(0, item->GetGUIDLow());
+ stmt->setUInt32(0, pItem->GetGUIDLow());
stmt->setString(1, ss.str());
CharacterDatabase.Execute(stmt);
}
}
- return item;
+ return pItem;
}
-Item* Player::StoreItem(ItemPosCountVec const& dest, Item* item, bool update)
+Item* Player::StoreItem(ItemPosCountVec const& dest, Item* pItem, bool update)
{
- if (!item)
+ if (!pItem)
return NULL;
- Item* lastItem = item;
+ Item* lastItem = pItem;
for (ItemPosCountVec::const_iterator itr = dest.begin(); itr != dest.end();)
{
uint16 pos = itr->pos;
@@ -12044,75 +12044,75 @@ Item* Player::StoreItem(ItemPosCountVec const& dest, Item* item, bool update)
if (itr == dest.end())
{
- lastItem = _StoreItem(pos, item, count, false, update);
+ lastItem = _StoreItem(pos, pItem, count, false, update);
break;
}
- lastItem = _StoreItem(pos, item, count, true, update);
+ lastItem = _StoreItem(pos, pItem, count, true, update);
}
return lastItem;
}
-// Return stored item (if stored to stack, it can diff. from item). And item ca be deleted in this case.
-Item* Player::_StoreItem(uint16 pos, Item* item, uint32 count, bool clone, bool update)
+// Return stored item (if stored to stack, it can diff. from pItem). And pItem ca be deleted in this case.
+Item* Player::_StoreItem(uint16 pos, Item* pItem, uint32 count, bool clone, bool update)
{
- if (!item)
+ if (!pItem)
return NULL;
uint8 bag = pos >> 8;
uint8 slot = pos & 255;
- sLog->outDebug(LOG_FILTER_PLAYER_ITEMS, "STORAGE: StoreItem bag = %u, slot = %u, item = %u, count = %u, guid = %u", bag, slot, item->GetEntry(), count, item->GetGUIDLow());
+ sLog->outDebug(LOG_FILTER_PLAYER_ITEMS, "STORAGE: StoreItem bag = %u, slot = %u, item = %u, count = %u, guid = %u", bag, slot, pItem->GetEntry(), count, pItem->GetGUIDLow());
Item* pItem2 = GetItemByPos(bag, slot);
if (!pItem2)
{
if (clone)
- item = item->CloneItem(count, this);
+ pItem = pItem->CloneItem(count, this);
else
- item->SetCount(count);
+ pItem->SetCount(count);
- if (!item)
+ if (!pItem)
return NULL;
- if (item->GetTemplate()->Bonding == BIND_WHEN_PICKED_UP ||
- item->GetTemplate()->Bonding == BIND_QUEST_ITEM ||
- (item->GetTemplate()->Bonding == BIND_WHEN_EQUIPED && IsBagPos(pos)))
- item->SetBinding(true);
+ if (pItem->GetTemplate()->Bonding == BIND_WHEN_PICKED_UP ||
+ pItem->GetTemplate()->Bonding == BIND_QUEST_ITEM ||
+ (pItem->GetTemplate()->Bonding == BIND_WHEN_EQUIPED && IsBagPos(pos)))
+ pItem->SetBinding(true);
Bag* pBag = (bag == INVENTORY_SLOT_BAG_0) ? NULL : GetBagByPos(bag);
if (!pBag)
{
- m_items[slot] = item;
- SetUInt64Value(PLAYER_FIELD_INV_SLOT_HEAD + (slot * 2), item->GetGUID());
- item->SetUInt64Value(ITEM_FIELD_CONTAINED, GetGUID());
- item->SetUInt64Value(ITEM_FIELD_OWNER, GetGUID());
+ m_items[slot] = pItem;
+ SetUInt64Value(PLAYER_FIELD_INV_SLOT_HEAD + (slot * 2), pItem->GetGUID());
+ pItem->SetUInt64Value(ITEM_FIELD_CONTAINED, GetGUID());
+ pItem->SetUInt64Value(ITEM_FIELD_OWNER, GetGUID());
- item->SetSlot(slot);
- item->SetContainer(NULL);
+ pItem->SetSlot(slot);
+ pItem->SetContainer(NULL);
// need update known currency
if (slot >= CURRENCYTOKEN_SLOT_START && slot < CURRENCYTOKEN_SLOT_END)
- AddKnownCurrency(item->GetEntry());
+ AddKnownCurrency(pItem->GetEntry());
}
else
- pBag->StoreItem(slot, item, update);
+ pBag->StoreItem(slot, pItem, update);
if (IsInWorld() && update)
{
- item->AddToWorld();
- item->SendUpdateToPlayer(this);
+ pItem->AddToWorld();
+ pItem->SendUpdateToPlayer(this);
}
- item->SetState(ITEM_CHANGED, this);
+ pItem->SetState(ITEM_CHANGED, this);
if (pBag)
pBag->SetState(ITEM_CHANGED, this);
- AddEnchantmentDurations(item);
- AddItemDurations(item);
+ AddEnchantmentDurations(pItem);
+ AddItemDurations(pItem);
- return item;
+ return pItem;
}
else
{
@@ -12130,18 +12130,18 @@ Item* Player::_StoreItem(uint16 pos, Item* item, uint32 count, bool clone, bool
// delete item (it not in any slot currently)
if (IsInWorld() && update)
{
- item->RemoveFromWorld();
- item->DestroyForPlayer(this);
+ pItem->RemoveFromWorld();
+ pItem->DestroyForPlayer(this);
}
- RemoveEnchantmentDurations(item);
- RemoveItemDurations(item);
+ RemoveEnchantmentDurations(pItem);
+ RemoveItemDurations(pItem);
- item->SetOwnerGUID(GetGUID()); // prevent error at next SetState in case trade/mail/buy from vendor
- item->SetNotRefundable(this);
- item->ClearSoulboundTradeable(this);
- RemoveTradeableItem(item);
- item->SetState(ITEM_REMOVED, this);
+ pItem->SetOwnerGUID(GetGUID()); // prevent error at next SetState in case trade/mail/buy from vendor
+ pItem->SetNotRefundable(this);
+ pItem->ClearSoulboundTradeable(this);
+ RemoveTradeableItem(pItem);
+ pItem->SetState(ITEM_REMOVED, this);
}
AddEnchantmentDurations(pItem2);
@@ -12154,20 +12154,20 @@ Item* Player::_StoreItem(uint16 pos, Item* item, uint32 count, bool clone, bool
Item* Player::EquipNewItem(uint16 pos, uint32 item, bool update)
{
- if (Item* item = Item::CreateItem(item, 1, this))
+ if (Item* pItem = Item::CreateItem(item, 1, this))
{
ItemAddedQuestCheck(item, 1);
GetAchievementMgr().UpdateAchievementCriteria(ACHIEVEMENT_CRITERIA_TYPE_RECEIVE_EPIC_ITEM, item, 1);
- return EquipItem(pos, item, update);
+ return EquipItem(pos, pItem, update);
}
return NULL;
}
-Item* Player::EquipItem(uint16 pos, Item* item, bool update)
+Item* Player::EquipItem(uint16 pos, Item* pItem, bool update)
{
- AddEnchantmentDurations(item);
- AddItemDurations(item);
+ AddEnchantmentDurations(pItem);
+ AddItemDurations(pItem);
uint8 bag = pos >> 8;
uint8 slot = pos & 255;
@@ -12176,17 +12176,17 @@ Item* Player::EquipItem(uint16 pos, Item* item, bool update)
if (!pItem2)
{
- VisualizeItem(slot, item);
+ VisualizeItem(slot, pItem);
if (isAlive())
{
- ItemTemplate const* pProto = item->GetTemplate();
+ ItemTemplate const* pProto = pItem->GetTemplate();
// item set bonuses applied only at equip and removed at unequip, and still active for broken items
if (pProto && pProto->ItemSet)
- AddItemsSetItem(this, item);
+ AddItemsSetItem(this, pItem);
- _ApplyItemMods(item, slot, true);
+ _ApplyItemMods(pItem, slot, true);
if (pProto && isInCombat() && (pProto->Class == ITEM_CLASS_WEAPON || pProto->InventoryType == INVTYPE_RELIC) && m_weaponChangeTimer == 0)
{
@@ -12213,11 +12213,11 @@ Item* Player::EquipItem(uint16 pos, Item* item, bool update)
if (IsInWorld() && update)
{
- item->AddToWorld();
- item->SendUpdateToPlayer(this);
+ pItem->AddToWorld();
+ pItem->SendUpdateToPlayer(this);
}
- ApplyEquipCooldown(item);
+ ApplyEquipCooldown(pItem);
// update expertise and armor penetration - passive auras may need it
@@ -12239,26 +12239,26 @@ Item* Player::EquipItem(uint16 pos, Item* item, bool update)
}
else
{
- pItem2->SetCount(pItem2->GetCount() + item->GetCount());
+ pItem2->SetCount(pItem2->GetCount() + pItem->GetCount());
if (IsInWorld() && update)
pItem2->SendUpdateToPlayer(this);
// delete item (it not in any slot currently)
- //item->DeleteFromDB();
+ //pItem->DeleteFromDB();
if (IsInWorld() && update)
{
- item->RemoveFromWorld();
- item->DestroyForPlayer(this);
+ pItem->RemoveFromWorld();
+ pItem->DestroyForPlayer(this);
}
- RemoveEnchantmentDurations(item);
- RemoveItemDurations(item);
+ RemoveEnchantmentDurations(pItem);
+ RemoveItemDurations(pItem);
- item->SetOwnerGUID(GetGUID()); // prevent error at next SetState in case trade/mail/buy from vendor
- item->SetNotRefundable(this);
- item->ClearSoulboundTradeable(this);
- RemoveTradeableItem(item);
- item->SetState(ITEM_REMOVED, this);
+ pItem->SetOwnerGUID(GetGUID()); // prevent error at next SetState in case trade/mail/buy from vendor
+ pItem->SetNotRefundable(this);
+ pItem->ClearSoulboundTradeable(this);
+ RemoveTradeableItem(pItem);
+ pItem->SetState(ITEM_REMOVED, this);
pItem2->SetState(ITEM_CHANGED, this);
ApplyEquipCooldown(pItem2);
@@ -12267,40 +12267,40 @@ Item* Player::EquipItem(uint16 pos, Item* item, bool update)
}
// only for full equip instead adding to stack
- GetAchievementMgr().UpdateAchievementCriteria(ACHIEVEMENT_CRITERIA_TYPE_EQUIP_ITEM, item->GetEntry());
- GetAchievementMgr().UpdateAchievementCriteria(ACHIEVEMENT_CRITERIA_TYPE_EQUIP_EPIC_ITEM, item->GetEntry(), slot);
+ GetAchievementMgr().UpdateAchievementCriteria(ACHIEVEMENT_CRITERIA_TYPE_EQUIP_ITEM, pItem->GetEntry());
+ GetAchievementMgr().UpdateAchievementCriteria(ACHIEVEMENT_CRITERIA_TYPE_EQUIP_EPIC_ITEM, pItem->GetEntry(), slot);
- return item;
+ return pItem;
}
-void Player::QuickEquipItem(uint16 pos, Item* item)
+void Player::QuickEquipItem(uint16 pos, Item* pItem)
{
- if (item)
+ if (pItem)
{
- AddEnchantmentDurations(item);
- AddItemDurations(item);
+ AddEnchantmentDurations(pItem);
+ AddItemDurations(pItem);
uint8 slot = pos & 255;
- VisualizeItem(slot, item);
+ VisualizeItem(slot, pItem);
if (IsInWorld())
{
- item->AddToWorld();
- item->SendUpdateToPlayer(this);
+ pItem->AddToWorld();
+ pItem->SendUpdateToPlayer(this);
}
- GetAchievementMgr().UpdateAchievementCriteria(ACHIEVEMENT_CRITERIA_TYPE_EQUIP_ITEM, item->GetEntry());
- GetAchievementMgr().UpdateAchievementCriteria(ACHIEVEMENT_CRITERIA_TYPE_EQUIP_EPIC_ITEM, item->GetEntry(), slot);
+ GetAchievementMgr().UpdateAchievementCriteria(ACHIEVEMENT_CRITERIA_TYPE_EQUIP_ITEM, pItem->GetEntry());
+ GetAchievementMgr().UpdateAchievementCriteria(ACHIEVEMENT_CRITERIA_TYPE_EQUIP_EPIC_ITEM, pItem->GetEntry(), slot);
}
}
-void Player::SetVisibleItemSlot(uint8 slot, Item* item)
+void Player::SetVisibleItemSlot(uint8 slot, Item* pItem)
{
- if (item)
+ if (pItem)
{
- SetUInt32Value(PLAYER_VISIBLE_ITEM_1_ENTRYID + (slot * 2), item->GetEntry());
- SetUInt16Value(PLAYER_VISIBLE_ITEM_1_ENCHANTMENT + (slot * 2), 0, item->GetEnchantmentId(PERM_ENCHANTMENT_SLOT));
- SetUInt16Value(PLAYER_VISIBLE_ITEM_1_ENCHANTMENT + (slot * 2), 1, item->GetEnchantmentId(TEMP_ENCHANTMENT_SLOT));
+ SetUInt32Value(PLAYER_VISIBLE_ITEM_1_ENTRYID + (slot * 2), pItem->GetEntry());
+ SetUInt16Value(PLAYER_VISIBLE_ITEM_1_ENCHANTMENT + (slot * 2), 0, pItem->GetEnchantmentId(PERM_ENCHANTMENT_SLOT));
+ SetUInt16Value(PLAYER_VISIBLE_ITEM_1_ENCHANTMENT + (slot * 2), 1, pItem->GetEnchantmentId(TEMP_ENCHANTMENT_SLOT));
}
else
{
@@ -12309,28 +12309,28 @@ void Player::SetVisibleItemSlot(uint8 slot, Item* item)
}
}
-void Player::VisualizeItem(uint8 slot, Item* item)
+void Player::VisualizeItem(uint8 slot, Item* pItem)
{
- if (!item)
+ if (!pItem)
return;
// check also BIND_WHEN_PICKED_UP and BIND_QUEST_ITEM for .additem or .additemset case by GM (not binded at adding to inventory)
- if (item->GetTemplate()->Bonding == BIND_WHEN_EQUIPED || item->GetTemplate()->Bonding == BIND_WHEN_PICKED_UP || item->GetTemplate()->Bonding == BIND_QUEST_ITEM)
- item->SetBinding(true);
+ if (pItem->GetTemplate()->Bonding == BIND_WHEN_EQUIPED || pItem->GetTemplate()->Bonding == BIND_WHEN_PICKED_UP || pItem->GetTemplate()->Bonding == BIND_QUEST_ITEM)
+ pItem->SetBinding(true);
- sLog->outDebug(LOG_FILTER_PLAYER_ITEMS, "STORAGE: EquipItem slot = %u, item = %u", slot, item->GetEntry());
+ sLog->outDebug(LOG_FILTER_PLAYER_ITEMS, "STORAGE: EquipItem slot = %u, item = %u", slot, pItem->GetEntry());
- m_items[slot] = item;
- SetUInt64Value(PLAYER_FIELD_INV_SLOT_HEAD + (slot * 2), item->GetGUID());
- item->SetUInt64Value(ITEM_FIELD_CONTAINED, GetGUID());
- item->SetUInt64Value(ITEM_FIELD_OWNER, GetGUID());
- item->SetSlot(slot);
- item->SetContainer(NULL);
+ m_items[slot] = pItem;
+ SetUInt64Value(PLAYER_FIELD_INV_SLOT_HEAD + (slot * 2), pItem->GetGUID());
+ pItem->SetUInt64Value(ITEM_FIELD_CONTAINED, GetGUID());
+ pItem->SetUInt64Value(ITEM_FIELD_OWNER, GetGUID());
+ pItem->SetSlot(slot);
+ pItem->SetContainer(NULL);
if (slot < EQUIPMENT_SLOT_END)
- SetVisibleItemSlot(slot, item);
+ SetVisibleItemSlot(slot, pItem);
- item->SetState(ITEM_CHANGED, this);
+ pItem->SetState(ITEM_CHANGED, this);
}
void Player::RemoveItem(uint8 bag, uint8 slot, bool update)
@@ -12340,44 +12340,44 @@ void Player::RemoveItem(uint8 bag, uint8 slot, bool update)
// note2: if removeitem is to be used for delinking
// the item must be removed from the player's updatequeue
- Item* item = GetItemByPos(bag, slot);
- if (item)
+ Item* pItem = GetItemByPos(bag, slot);
+ if (pItem)
{
- sLog->outDebug(LOG_FILTER_PLAYER_ITEMS, "STORAGE: RemoveItem bag = %u, slot = %u, item = %u", bag, slot, item->GetEntry());
+ sLog->outDebug(LOG_FILTER_PLAYER_ITEMS, "STORAGE: RemoveItem bag = %u, slot = %u, item = %u", bag, slot, pItem->GetEntry());
- RemoveEnchantmentDurations(item);
- RemoveItemDurations(item);
- RemoveTradeableItem(item);
+ RemoveEnchantmentDurations(pItem);
+ RemoveItemDurations(pItem);
+ RemoveTradeableItem(pItem);
if (bag == INVENTORY_SLOT_BAG_0)
{
if (slot < INVENTORY_SLOT_BAG_END)
{
- ItemTemplate const* pProto = item->GetTemplate();
+ ItemTemplate const* pProto = pItem->GetTemplate();
// item set bonuses applied only at equip and removed at unequip, and still active for broken items
if (pProto && pProto->ItemSet)
RemoveItemsSetItem(this, pProto);
- _ApplyItemMods(item, slot, false);
+ _ApplyItemMods(pItem, slot, false);
// remove item dependent auras and casts (only weapon and armor slots)
if (slot < EQUIPMENT_SLOT_END)
{
- RemoveItemDependentAurasAndCasts(item);
+ RemoveItemDependentAurasAndCasts(pItem);
// remove held enchantments, update expertise
if (slot == EQUIPMENT_SLOT_MAINHAND)
{
- if (item->GetItemSuffixFactor())
+ if (pItem->GetItemSuffixFactor())
{
- item->ClearEnchantment(PROP_ENCHANTMENT_SLOT_3);
- item->ClearEnchantment(PROP_ENCHANTMENT_SLOT_4);
+ pItem->ClearEnchantment(PROP_ENCHANTMENT_SLOT_3);
+ pItem->ClearEnchantment(PROP_ENCHANTMENT_SLOT_4);
}
else
{
- item->ClearEnchantment(PROP_ENCHANTMENT_SLOT_0);
- item->ClearEnchantment(PROP_ENCHANTMENT_SLOT_1);
+ pItem->ClearEnchantment(PROP_ENCHANTMENT_SLOT_0);
+ pItem->ClearEnchantment(PROP_ENCHANTMENT_SLOT_1);
}
UpdateExpertise(BASE_ATTACK);
@@ -12406,11 +12406,11 @@ void Player::RemoveItem(uint8 bag, uint8 slot, bool update)
else if (Bag* pBag = GetBagByPos(bag))
pBag->RemoveItem(slot, update);
- item->SetUInt64Value(ITEM_FIELD_CONTAINED, 0);
- // item->SetUInt64Value(ITEM_FIELD_OWNER, 0); not clear owner at remove (it will be set at store). This used in mail and auction code
- item->SetSlot(NULL_SLOT);
+ pItem->SetUInt64Value(ITEM_FIELD_CONTAINED, 0);
+ // pItem->SetUInt64Value(ITEM_FIELD_OWNER, 0); not clear owner at remove (it will be set at store). This used in mail and auction code
+ pItem->SetSlot(NULL_SLOT);
if (IsInWorld() && update)
- item->SendUpdateToPlayer(this);
+ pItem->SendUpdateToPlayer(this);
}
}
@@ -12432,17 +12432,17 @@ void Player::MoveItemFromInventory(uint8 bag, uint8 slot, bool update)
}
// Common operation need to add item from inventory without delete in trade, guild bank, mail....
-void Player::MoveItemToInventory(ItemPosCountVec const& dest, Item* item, bool update, bool in_characterInventoryDB)
+void Player::MoveItemToInventory(ItemPosCountVec const& dest, Item* pItem, bool update, bool in_characterInventoryDB)
{
// update quest counters
- ItemAddedQuestCheck(item->GetEntry(), item->GetCount());
- GetAchievementMgr().UpdateAchievementCriteria(ACHIEVEMENT_CRITERIA_TYPE_RECEIVE_EPIC_ITEM, item->GetEntry(), item->GetCount());
+ ItemAddedQuestCheck(pItem->GetEntry(), pItem->GetCount());
+ GetAchievementMgr().UpdateAchievementCriteria(ACHIEVEMENT_CRITERIA_TYPE_RECEIVE_EPIC_ITEM, pItem->GetEntry(), pItem->GetCount());
// store item
- Item* pLastItem = StoreItem(dest, item, update);
+ Item* pLastItem = StoreItem(dest, pItem, update);
- // only set if not merged to existed stack (item can be deleted already but we can compare pointers any way)
- if (pLastItem == item)
+ // only set if not merged to existed stack (pItem can be deleted already but we can compare pointers any way)
+ if (pLastItem == pItem)
{
// update owner for last item (this can be original item with wrong owner
if (pLastItem->GetOwnerGUID() != GetGUID())
@@ -12459,38 +12459,38 @@ void Player::MoveItemToInventory(ItemPosCountVec const& dest, Item* item, bool u
void Player::DestroyItem(uint8 bag, uint8 slot, bool update)
{
- Item* item = GetItemByPos(bag, slot);
- if (item)
+ Item* pItem = GetItemByPos(bag, slot);
+ if (pItem)
{
- sLog->outDebug(LOG_FILTER_PLAYER_ITEMS, "STORAGE: DestroyItem bag = %u, slot = %u, item = %u", bag, slot, item->GetEntry());
+ sLog->outDebug(LOG_FILTER_PLAYER_ITEMS, "STORAGE: DestroyItem bag = %u, slot = %u, item = %u", bag, slot, pItem->GetEntry());
// Also remove all contained items if the item is a bag.
// This if () prevents item saving crashes if the condition for a bag to be empty before being destroyed was bypassed somehow.
- if (item->IsNotEmptyBag())
+ if (pItem->IsNotEmptyBag())
for (uint8 i = 0; i < MAX_BAG_SIZE; ++i)
DestroyItem(slot, i, update);
- if (item->HasFlag(ITEM_FIELD_FLAGS, ITEM_FLAG_WRAPPED))
+ if (pItem->HasFlag(ITEM_FIELD_FLAGS, ITEM_FLAG_WRAPPED))
{
PreparedStatement* stmt = CharacterDatabase.GetPreparedStatement(CHAR_DEL_GIFT);
- stmt->setUInt32(0, item->GetGUIDLow());
+ stmt->setUInt32(0, pItem->GetGUIDLow());
CharacterDatabase.Execute(stmt);
}
- RemoveEnchantmentDurations(item);
- RemoveItemDurations(item);
+ RemoveEnchantmentDurations(pItem);
+ RemoveItemDurations(pItem);
- item->SetNotRefundable(this);
- item->ClearSoulboundTradeable(this);
- RemoveTradeableItem(item);
+ pItem->SetNotRefundable(this);
+ pItem->ClearSoulboundTradeable(this);
+ RemoveTradeableItem(pItem);
- const ItemTemplate* proto = item->GetTemplate();
+ const ItemTemplate* proto = pItem->GetTemplate();
for (uint8 i = 0; i < MAX_ITEM_PROTO_SPELLS; ++i)
if (proto->Spells[i].SpellTrigger == ITEM_SPELLTRIGGER_ON_NO_DELAY_USE && proto->Spells[i].SpellId > 0) // On obtain trigger
RemoveAurasDueToSpell(proto->Spells[i].SpellId);
- ItemRemovedQuestCheck(item->GetEntry(), item->GetCount());
+ ItemRemovedQuestCheck(pItem->GetEntry(), pItem->GetCount());
if (bag == INVENTORY_SLOT_BAG_0)
{
@@ -12499,19 +12499,19 @@ void Player::DestroyItem(uint8 bag, uint8 slot, bool update)
// equipment and equipped bags can have applied bonuses
if (slot < INVENTORY_SLOT_BAG_END)
{
- ItemTemplate const* pProto = item->GetTemplate();
+ ItemTemplate const* pProto = pItem->GetTemplate();
// item set bonuses applied only at equip and removed at unequip, and still active for broken items
if (pProto && pProto->ItemSet)
RemoveItemsSetItem(this, pProto);
- _ApplyItemMods(item, slot, false);
+ _ApplyItemMods(pItem, slot, false);
}
if (slot < EQUIPMENT_SLOT_END)
{
// remove item dependent auras and casts (only weapon and armor slots)
- RemoveItemDependentAurasAndCasts(item);
+ RemoveItemDependentAurasAndCasts(pItem);
// update expertise and armor penetration - passive auras may need it
switch (slot)
@@ -12540,14 +12540,14 @@ void Player::DestroyItem(uint8 bag, uint8 slot, bool update)
if (IsInWorld() && update)
{
- item->RemoveFromWorld();
- item->DestroyForPlayer(this);
+ pItem->RemoveFromWorld();
+ pItem->DestroyForPlayer(this);
}
- //item->SetOwnerGUID(0);
- item->SetUInt64Value(ITEM_FIELD_CONTAINED, 0);
- item->SetSlot(NULL_SLOT);
- item->SetState(ITEM_REMOVED, this);
+ //pItem->SetOwnerGUID(0);
+ pItem->SetUInt64Value(ITEM_FIELD_CONTAINED, 0);
+ pItem->SetSlot(NULL_SLOT);
+ pItem->SetState(ITEM_REMOVED, this);
}
}
@@ -12559,14 +12559,14 @@ void Player::DestroyItemCount(uint32 item, uint32 count, bool update, bool unequ
// in inventory
for (uint8 i = INVENTORY_SLOT_ITEM_START; i < INVENTORY_SLOT_ITEM_END; ++i)
{
- if (Item* item = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
+ if (Item* pItem = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
{
- if (item->GetEntry() == item && !item->IsInTrade())
+ if (pItem->GetEntry() == item && !pItem->IsInTrade())
{
- if (item->GetCount() + remcount <= count)
+ if (pItem->GetCount() + remcount <= count)
{
// all items in inventory can unequipped
- remcount += item->GetCount();
+ remcount += pItem->GetCount();
DestroyItem(INVENTORY_SLOT_BAG_0, i, update);
if (remcount >= count)
@@ -12574,11 +12574,11 @@ void Player::DestroyItemCount(uint32 item, uint32 count, bool update, bool unequ
}
else
{
- ItemRemovedQuestCheck(item->GetEntry(), count - remcount);
- item->SetCount(item->GetCount() - count + remcount);
+ ItemRemovedQuestCheck(pItem->GetEntry(), count - remcount);
+ pItem->SetCount(pItem->GetCount() - count + remcount);
if (IsInWorld() & update)
- item->SendUpdateToPlayer(this);
- item->SetState(ITEM_CHANGED, this);
+ pItem->SendUpdateToPlayer(this);
+ pItem->SetState(ITEM_CHANGED, this);
return;
}
}
@@ -12587,14 +12587,14 @@ void Player::DestroyItemCount(uint32 item, uint32 count, bool update, bool unequ
for (uint8 i = KEYRING_SLOT_START; i < CURRENCYTOKEN_SLOT_END; ++i)
{
- if (Item* item = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
+ if (Item* pItem = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
{
- if (item->GetEntry() == item && !item->IsInTrade())
+ if (pItem->GetEntry() == item && !pItem->IsInTrade())
{
- if (item->GetCount() + remcount <= count)
+ if (pItem->GetCount() + remcount <= count)
{
// all keys can be unequipped
- remcount += item->GetCount();
+ remcount += pItem->GetCount();
DestroyItem(INVENTORY_SLOT_BAG_0, i, update);
if (remcount >= count)
@@ -12602,11 +12602,11 @@ void Player::DestroyItemCount(uint32 item, uint32 count, bool update, bool unequ
}
else
{
- ItemRemovedQuestCheck(item->GetEntry(), count - remcount);
- item->SetCount(item->GetCount() - count + remcount);
+ ItemRemovedQuestCheck(pItem->GetEntry(), count - remcount);
+ pItem->SetCount(pItem->GetCount() - count + remcount);
if (IsInWorld() & update)
- item->SendUpdateToPlayer(this);
- item->SetState(ITEM_CHANGED, this);
+ pItem->SendUpdateToPlayer(this);
+ pItem->SetState(ITEM_CHANGED, this);
return;
}
}
@@ -12620,14 +12620,14 @@ void Player::DestroyItemCount(uint32 item, uint32 count, bool update, bool unequ
{
for (uint32 j = 0; j < pBag->GetBagSize(); j++)
{
- if (Item* item = pBag->GetItemByPos(j))
+ if (Item* pItem = pBag->GetItemByPos(j))
{
- if (item->GetEntry() == item && !item->IsInTrade())
+ if (pItem->GetEntry() == item && !pItem->IsInTrade())
{
// all items in bags can be unequipped
- if (item->GetCount() + remcount <= count)
+ if (pItem->GetCount() + remcount <= count)
{
- remcount += item->GetCount();
+ remcount += pItem->GetCount();
DestroyItem(i, j, update);
if (remcount >= count)
@@ -12635,11 +12635,11 @@ void Player::DestroyItemCount(uint32 item, uint32 count, bool update, bool unequ
}
else
{
- ItemRemovedQuestCheck(item->GetEntry(), count - remcount);
- item->SetCount(item->GetCount() - count + remcount);
+ ItemRemovedQuestCheck(pItem->GetEntry(), count - remcount);
+ pItem->SetCount(pItem->GetCount() - count + remcount);
if (IsInWorld() && update)
- item->SendUpdateToPlayer(this);
- item->SetState(ITEM_CHANGED, this);
+ pItem->SendUpdateToPlayer(this);
+ pItem->SetState(ITEM_CHANGED, this);
return;
}
}
@@ -12651,15 +12651,15 @@ void Player::DestroyItemCount(uint32 item, uint32 count, bool update, bool unequ
// in equipment and bag list
for (uint8 i = EQUIPMENT_SLOT_START; i < INVENTORY_SLOT_BAG_END; i++)
{
- if (Item* item = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
+ if (Item* pItem = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
{
- if (item && item->GetEntry() == item && !item->IsInTrade())
+ if (pItem && pItem->GetEntry() == item && !pItem->IsInTrade())
{
- if (item->GetCount() + remcount <= count)
+ if (pItem->GetCount() + remcount <= count)
{
if (!unequip_check || CanUnequipItem(INVENTORY_SLOT_BAG_0 << 8 | i, false) == EQUIP_ERR_OK)
{
- remcount += item->GetCount();
+ remcount += pItem->GetCount();
DestroyItem(INVENTORY_SLOT_BAG_0, i, update);
if (remcount >= count)
@@ -12668,11 +12668,11 @@ void Player::DestroyItemCount(uint32 item, uint32 count, bool update, bool unequ
}
else
{
- ItemRemovedQuestCheck(item->GetEntry(), count - remcount);
- item->SetCount(item->GetCount() - count + remcount);
+ ItemRemovedQuestCheck(pItem->GetEntry(), count - remcount);
+ pItem->SetCount(pItem->GetCount() - count + remcount);
if (IsInWorld() & update)
- item->SendUpdateToPlayer(this);
- item->SetState(ITEM_CHANGED, this);
+ pItem->SendUpdateToPlayer(this);
+ pItem->SetState(ITEM_CHANGED, this);
return;
}
}
@@ -12686,27 +12686,27 @@ void Player::DestroyZoneLimitedItem(bool update, uint32 new_zone)
// in inventory
for (uint8 i = INVENTORY_SLOT_ITEM_START; i < INVENTORY_SLOT_ITEM_END; i++)
- if (Item* item = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
- if (item->IsLimitedToAnotherMapOrZone(GetMapId(), new_zone))
+ if (Item* pItem = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
+ if (pItem->IsLimitedToAnotherMapOrZone(GetMapId(), new_zone))
DestroyItem(INVENTORY_SLOT_BAG_0, i, update);
for (uint8 i = KEYRING_SLOT_START; i < CURRENCYTOKEN_SLOT_END; ++i)
- if (Item* item = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
- if (item->IsLimitedToAnotherMapOrZone(GetMapId(), new_zone))
+ if (Item* pItem = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
+ if (pItem->IsLimitedToAnotherMapOrZone(GetMapId(), new_zone))
DestroyItem(INVENTORY_SLOT_BAG_0, i, update);
// in inventory bags
for (uint8 i = INVENTORY_SLOT_BAG_START; i < INVENTORY_SLOT_BAG_END; i++)
if (Bag* pBag = GetBagByPos(i))
for (uint32 j = 0; j < pBag->GetBagSize(); j++)
- if (Item* item = pBag->GetItemByPos(j))
- if (item->IsLimitedToAnotherMapOrZone(GetMapId(), new_zone))
+ if (Item* pItem = pBag->GetItemByPos(j))
+ if (pItem->IsLimitedToAnotherMapOrZone(GetMapId(), new_zone))
DestroyItem(i, j, update);
// in equipment and bag list
for (uint8 i = EQUIPMENT_SLOT_START; i < INVENTORY_SLOT_BAG_END; i++)
- if (Item* item = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
- if (item->IsLimitedToAnotherMapOrZone(GetMapId(), new_zone))
+ if (Item* pItem = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
+ if (pItem->IsLimitedToAnotherMapOrZone(GetMapId(), new_zone))
DestroyItem(INVENTORY_SLOT_BAG_0, i, update);
}
@@ -12718,22 +12718,22 @@ void Player::DestroyConjuredItems(bool update)
// in inventory
for (uint8 i = INVENTORY_SLOT_ITEM_START; i < INVENTORY_SLOT_ITEM_END; i++)
- if (Item* item = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
- if (item->IsConjuredConsumable())
+ if (Item* pItem = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
+ if (pItem->IsConjuredConsumable())
DestroyItem(INVENTORY_SLOT_BAG_0, i, update);
// in inventory bags
for (uint8 i = INVENTORY_SLOT_BAG_START; i < INVENTORY_SLOT_BAG_END; i++)
if (Bag* pBag = GetBagByPos(i))
for (uint32 j = 0; j < pBag->GetBagSize(); j++)
- if (Item* item = pBag->GetItemByPos(j))
- if (item->IsConjuredConsumable())
+ if (Item* pItem = pBag->GetItemByPos(j))
+ if (pItem->IsConjuredConsumable())
DestroyItem(i, j, update);
// in equipment and bag list
for (uint8 i = EQUIPMENT_SLOT_START; i < INVENTORY_SLOT_BAG_END; i++)
- if (Item* item = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
- if (item->IsConjuredConsumable())
+ if (Item* pItem = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
+ if (pItem->IsConjuredConsumable())
DestroyItem(INVENTORY_SLOT_BAG_0, i, update);
}
@@ -12741,46 +12741,46 @@ Item* Player::GetItemByEntry(uint32 entry) const
{
// in inventory
for (int i = INVENTORY_SLOT_ITEM_START; i < INVENTORY_SLOT_ITEM_END; ++i)
- if (Item* item = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
- if (item->GetEntry() == entry)
- return item;
+ if (Item* pItem = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
+ if (pItem->GetEntry() == entry)
+ return pItem;
for (int i = INVENTORY_SLOT_BAG_START; i < INVENTORY_SLOT_BAG_END; ++i)
if (Bag* pBag = GetBagByPos(i))
for (uint32 j = 0; j < pBag->GetBagSize(); ++j)
- if (Item* item = pBag->GetItemByPos(j))
- if (item->GetEntry() == entry)
- return item;
+ if (Item* pItem = pBag->GetItemByPos(j))
+ if (pItem->GetEntry() == entry)
+ return pItem;
for (int i = EQUIPMENT_SLOT_START; i < INVENTORY_SLOT_BAG_END; ++i)
- if (Item* item = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
- if (item->GetEntry() == entry)
- return item;
+ if (Item* pItem = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
+ if (pItem->GetEntry() == entry)
+ return pItem;
return NULL;
}
-void Player::DestroyItemCount(Item* item, uint32 &count, bool update)
+void Player::DestroyItemCount(Item* pItem, uint32 &count, bool update)
{
- if (!item)
+ if (!pItem)
return;
- sLog->outDebug(LOG_FILTER_PLAYER_ITEMS, "STORAGE: DestroyItemCount item (GUID: %u, Entry: %u) count = %u", item->GetGUIDLow(), item->GetEntry(), count);
+ sLog->outDebug(LOG_FILTER_PLAYER_ITEMS, "STORAGE: DestroyItemCount item (GUID: %u, Entry: %u) count = %u", pItem->GetGUIDLow(), pItem->GetEntry(), count);
- if (item->GetCount() <= count)
+ if (pItem->GetCount() <= count)
{
- count -= item->GetCount();
+ count -= pItem->GetCount();
- DestroyItem(item->GetBagSlot(), item->GetSlot(), update);
+ DestroyItem(pItem->GetBagSlot(), pItem->GetSlot(), update);
}
else
{
- ItemRemovedQuestCheck(item->GetEntry(), count);
- item->SetCount(item->GetCount() - count);
+ ItemRemovedQuestCheck(pItem->GetEntry(), count);
+ pItem->SetCount(pItem->GetCount() - count);
count = 0;
if (IsInWorld() & update)
- item->SendUpdateToPlayer(this);
- item->SetState(ITEM_CHANGED, this);
+ pItem->SendUpdateToPlayer(this);
+ pItem->SetState(ITEM_CHANGED, this);
}
}
@@ -13255,9 +13255,9 @@ void Player::SwapItem(uint16 src, uint16 dst)
AutoUnequipOffhandIfNeed();
}
-void Player::AddItemToBuyBackSlot(Item* item)
+void Player::AddItemToBuyBackSlot(Item* pItem)
{
- if (item)
+ if (pItem)
{
uint32 slot = m_currentBuybackSlot;
// if current back slot non-empty search oldest or free
@@ -13289,16 +13289,16 @@ void Player::AddItemToBuyBackSlot(Item* item)
}
RemoveItemFromBuyBackSlot(slot, true);
- sLog->outDebug(LOG_FILTER_PLAYER_ITEMS, "STORAGE: AddItemToBuyBackSlot item = %u, slot = %u", item->GetEntry(), slot);
+ sLog->outDebug(LOG_FILTER_PLAYER_ITEMS, "STORAGE: AddItemToBuyBackSlot item = %u, slot = %u", pItem->GetEntry(), slot);
- m_items[slot] = item;
+ m_items[slot] = pItem;
time_t base = time(NULL);
uint32 etime = uint32(base - m_logintime + (30 * 3600));
uint32 eslot = slot - BUYBACK_SLOT_START;
- SetUInt64Value(PLAYER_FIELD_VENDORBUYBACK_SLOT_1 + (eslot * 2), item->GetGUID());
- if (ItemTemplate const* proto = item->GetTemplate())
- SetUInt32Value(PLAYER_FIELD_BUYBACK_PRICE_1 + eslot, proto->SellPrice * item->GetCount());
+ SetUInt64Value(PLAYER_FIELD_VENDORBUYBACK_SLOT_1 + (eslot * 2), pItem->GetGUID());
+ if (ItemTemplate const* proto = pItem->GetTemplate())
+ SetUInt32Value(PLAYER_FIELD_BUYBACK_PRICE_1 + eslot, proto->SellPrice * pItem->GetCount());
else
SetUInt32Value(PLAYER_FIELD_BUYBACK_PRICE_1 + eslot, 0);
SetUInt32Value(PLAYER_FIELD_BUYBACK_TIMESTAMP_1 + eslot, (uint32)etime);
@@ -13322,12 +13322,12 @@ void Player::RemoveItemFromBuyBackSlot(uint32 slot, bool del)
sLog->outDebug(LOG_FILTER_PLAYER_ITEMS, "STORAGE: RemoveItemFromBuyBackSlot slot = %u", slot);
if (slot >= BUYBACK_SLOT_START && slot < BUYBACK_SLOT_END)
{
- Item* item = m_items[slot];
- if (item)
+ Item* pItem = m_items[slot];
+ if (pItem)
{
- item->RemoveFromWorld();
+ pItem->RemoveFromWorld();
if (del)
- item->SetState(ITEM_REMOVED, this);
+ pItem->SetState(ITEM_REMOVED, this);
}
m_items[slot] = NULL;
@@ -13343,7 +13343,7 @@ void Player::RemoveItemFromBuyBackSlot(uint32 slot, bool del)
}
}
-void Player::SendEquipError(InventoryResult msg, Item* item, Item* pItem2, uint32 itemid)
+void Player::SendEquipError(InventoryResult msg, Item* pItem, Item* pItem2, uint32 itemid)
{
sLog->outDebug(LOG_FILTER_NETWORKIO, "WORLD: Sent SMSG_INVENTORY_CHANGE_FAILURE (%u)", msg);
WorldPacket data(SMSG_INVENTORY_CHANGE_FAILURE, (msg == EQUIP_ERR_CANT_EQUIP_LEVEL_I ? 22 : 18));
@@ -13351,7 +13351,7 @@ void Player::SendEquipError(InventoryResult msg, Item* item, Item* pItem2, uint3
if (msg != EQUIP_ERR_OK)
{
- data << uint64(item ? item->GetGUID() : 0);
+ data << uint64(pItem ? pItem->GetGUID() : 0);
data << uint64(pItem2 ? pItem2->GetGUID() : 0);
data << uint8(0); // bag type subclass, used with EQUIP_ERR_EVENT_AUTOEQUIP_BIND_CONFIRM and EQUIP_ERR_ITEM_DOESNT_GO_INTO_BAG2
@@ -13360,7 +13360,7 @@ void Player::SendEquipError(InventoryResult msg, Item* item, Item* pItem2, uint3
case EQUIP_ERR_CANT_EQUIP_LEVEL_I:
case EQUIP_ERR_PURCHASE_LEVEL_TOO_LOW:
{
- ItemTemplate const* proto = item ? item->GetTemplate() : sObjectMgr->GetItemTemplate(itemid);
+ ItemTemplate const* proto = pItem ? pItem->GetTemplate() : sObjectMgr->GetItemTemplate(itemid);
data << uint32(proto ? proto->RequiredLevel : 0);
break;
}
@@ -13375,7 +13375,7 @@ void Player::SendEquipError(InventoryResult msg, Item* item, Item* pItem2, uint3
case EQUIP_ERR_ITEM_MAX_LIMIT_CATEGORY_SOCKETED_EXCEEDED:
case EQUIP_ERR_ITEM_MAX_LIMIT_CATEGORY_EQUIPPED_EXCEEDED:
{
- ItemTemplate const* proto = item ? item->GetTemplate() : sObjectMgr->GetItemTemplate(itemid);
+ ItemTemplate const* proto = pItem ? pItem->GetTemplate() : sObjectMgr->GetItemTemplate(itemid);
data << uint32(proto ? proto->ItemLimitCategory : 0);
break;
}
@@ -13565,17 +13565,17 @@ void Player::RemoveArenaEnchantments(EnchantmentSlot slot)
// NOTE: no need to remove these from stats, since these aren't equipped
// in inventory
for (uint8 i = INVENTORY_SLOT_ITEM_START; i < INVENTORY_SLOT_ITEM_END; ++i)
- if (Item* item = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
- if (item->GetEnchantmentId(slot))
- item->ClearEnchantment(slot);
+ if (Item* pItem = GetItemByPos(INVENTORY_SLOT_BAG_0, i))
+ if (pItem->GetEnchantmentId(slot))
+ pItem->ClearEnchantment(slot);
// in inventory bags
for (uint8 i = INVENTORY_SLOT_BAG_START; i < INVENTORY_SLOT_BAG_END; ++i)
if (Bag* pBag = GetBagByPos(i))
for (uint32 j = 0; j < pBag->GetBagSize(); j++)
- if (Item* item = pBag->GetItemByPos(j))
- if (item->GetEnchantmentId(slot))
- item->ClearEnchantment(slot);
+ if (Item* pItem = pBag->GetItemByPos(j))
+ if (pItem->GetEnchantmentId(slot))
+ pItem->ClearEnchantment(slot);
}
// duration == 0 will remove item enchant
@@ -21217,14 +21217,14 @@ void Player::CorrectMetaGemEnchants(uint8 exceptslot, bool apply)
if (slot == exceptslot)
continue;
- Item* item = GetItemByPos(INVENTORY_SLOT_BAG_0, slot);
+ Item* pItem = GetItemByPos(INVENTORY_SLOT_BAG_0, slot);
- if (!item || !item->GetTemplate()->Socket[0].Color)
+ if (!pItem || !pItem->GetTemplate()->Socket[0].Color)
continue;
for (uint32 enchant_slot = SOCK_ENCHANTMENT_SLOT; enchant_slot < SOCK_ENCHANTMENT_SLOT+3; ++enchant_slot)
{
- uint32 enchant_id = item->GetEnchantmentId(EnchantmentSlot(enchant_slot));
+ uint32 enchant_id = pItem->GetEnchantmentId(EnchantmentSlot(enchant_slot));
if (!enchant_id)
continue;
@@ -21242,7 +21242,7 @@ void Player::CorrectMetaGemEnchants(uint8 exceptslot, bool apply)
{
// ignore item gem conditions
//if state changed, (dis)apply enchant
- ApplyEnchantment(item, EnchantmentSlot(enchant_slot), !wasactive, true, true);
+ ApplyEnchantment(pItem, EnchantmentSlot(enchant_slot), !wasactive, true, true);
}
}
}
@@ -21259,15 +21259,15 @@ void Player::ToggleMetaGemsActive(uint8 exceptslot, bool apply)
if (slot == exceptslot)
continue;
- Item* item = GetItemByPos(INVENTORY_SLOT_BAG_0, slot);
+ Item* pItem = GetItemByPos(INVENTORY_SLOT_BAG_0, slot);
- if (!item || !item->GetTemplate()->Socket[0].Color) //if item has no sockets or no item is equipped go to next item
+ if (!pItem || !pItem->GetTemplate()->Socket[0].Color) //if item has no sockets or no item is equipped go to next item
continue;
//cycle all (gem)enchants
for (uint32 enchant_slot = SOCK_ENCHANTMENT_SLOT; enchant_slot < SOCK_ENCHANTMENT_SLOT+3; ++enchant_slot)
{
- uint32 enchant_id = item->GetEnchantmentId(EnchantmentSlot(enchant_slot));
+ uint32 enchant_id = pItem->GetEnchantmentId(EnchantmentSlot(enchant_slot));
if (!enchant_id) //if no enchant go to next enchant(slot)
continue;
@@ -21278,7 +21278,7 @@ void Player::ToggleMetaGemsActive(uint8 exceptslot, bool apply)
//only metagems to be (de)activated, so only enchants with condition
uint32 condition = enchantEntry->EnchantmentCondition;
if (condition)
- ApplyEnchantment(item, EnchantmentSlot(enchant_slot), apply);
+ ApplyEnchantment(pItem, EnchantmentSlot(enchant_slot), apply);
}
}
}
@@ -21940,14 +21940,14 @@ void Player::SendInstanceResetWarning(uint32 mapid, Difficulty difficulty, uint3
GetSession()->SendPacket(&data);
}
-void Player::ApplyEquipCooldown(Item* item)
+void Player::ApplyEquipCooldown(Item* pItem)
{
- if (item->HasFlag(ITEM_FIELD_FLAGS, ITEM_PROTO_FLAG_NO_EQUIP_COOLDOWN))
+ if (pItem->HasFlag(ITEM_FIELD_FLAGS, ITEM_PROTO_FLAG_NO_EQUIP_COOLDOWN))
return;
for (uint8 i = 0; i < MAX_ITEM_PROTO_SPELLS; ++i)
{
- _Spell const& spellData = item->GetTemplate()->Spells[i];
+ _Spell const& spellData = pItem->GetTemplate()->Spells[i];
// no spell
if (!spellData.SpellId)
@@ -21957,10 +21957,10 @@ void Player::ApplyEquipCooldown(Item* item)
if (spellData.SpellTrigger != ITEM_SPELLTRIGGER_ON_USE)
continue;
- AddSpellCooldown(spellData.SpellId, item->GetEntry(), time(NULL) + 30);
+ AddSpellCooldown(spellData.SpellId, pItem->GetEntry(), time(NULL) + 30);
WorldPacket data(SMSG_ITEM_COOLDOWN, 12);
- data << item->GetGUID();
+ data << pItem->GetGUID();
data << uint32(spellData.SpellId);
GetSession()->SendPacket(&data);
}
@@ -22574,7 +22574,7 @@ bool Player::CanNoReagentCast(SpellInfo const* spellInfo) const
return false;
}
-void Player::RemoveItemDependentAurasAndCasts(Item* item)
+void Player::RemoveItemDependentAurasAndCasts(Item* pItem)
{
for (AuraMap::iterator itr = m_ownedAuras.begin(); itr != m_ownedAuras.end();)
{
@@ -22589,7 +22589,7 @@ void Player::RemoveItemDependentAurasAndCasts(Item* item)
}
// skip if not item dependent or have alternative item
- if (HasItemFitToSpellRequirements(spellInfo, item))
+ if (HasItemFitToSpellRequirements(spellInfo, pItem))
{
++itr;
continue;
@@ -22602,7 +22602,7 @@ void Player::RemoveItemDependentAurasAndCasts(Item* item)
// currently casted spells can be dependent from item
for (uint32 i = 0; i < CURRENT_MAX_SPELL; ++i)
if (Spell* spell = GetCurrentSpell(CurrentSpellTypes(i)))
- if (spell->getState() != SPELL_STATE_DELAYED && !HasItemFitToSpellRequirements(spell->m_spellInfo, item))
+ if (spell->getState() != SPELL_STATE_DELAYED && !HasItemFitToSpellRequirements(spell->m_spellInfo, pItem))
InterruptSpell(CurrentSpellTypes(i));
}
@@ -23548,8 +23548,8 @@ void Player::AutoStoreLoot(uint8 bag, uint8 slot, uint32 loot_id, LootStore cons
continue;
}
- Item* item = StoreNewItem(dest, lootItem->itemid, true, lootItem->randomPropertyId);
- SendNewItem(item, lootItem->count, false, false, broadcast);
+ Item* pItem = StoreNewItem(dest, lootItem->itemid, true, lootItem->randomPropertyId);
+ SendNewItem(pItem, lootItem->count, false, false, broadcast);
}
}
@@ -23780,9 +23780,9 @@ uint32 Player::GetPhaseMaskForSpawn() const
return PHASEMASK_NORMAL;
}
-InventoryResult Player::CanEquipUniqueItem(Item* item, uint8 eslot, uint32 limit_count) const
+InventoryResult Player::CanEquipUniqueItem(Item* pItem, uint8 eslot, uint32 limit_count) const
{
- ItemTemplate const* pProto = item->GetTemplate();
+ ItemTemplate const* pProto = pItem->GetTemplate();
// proto based limitations
if (InventoryResult res = CanEquipUniqueItem(pProto, eslot, limit_count))
@@ -23791,7 +23791,7 @@ InventoryResult Player::CanEquipUniqueItem(Item* item, uint8 eslot, uint32 limit
// check unique-equipped on gems
for (uint32 enchant_slot = SOCK_ENCHANTMENT_SLOT; enchant_slot < SOCK_ENCHANTMENT_SLOT+3; ++enchant_slot)
{
- uint32 enchant_id = item->GetEnchantmentId(EnchantmentSlot(enchant_slot));
+ uint32 enchant_id = pItem->GetEnchantmentId(EnchantmentSlot(enchant_slot));
if (!enchant_id)
continue;
SpellItemEnchantmentEntry const* enchantEntry = sSpellItemEnchantmentStore.LookupEntry(enchant_id);
@@ -23803,8 +23803,8 @@ InventoryResult Player::CanEquipUniqueItem(Item* item, uint8 eslot, uint32 limit
continue;
// include for check equip another gems with same limit category for not equipped item (and then not counted)
- uint32 gem_limit_count = !item->IsEquipped() && pGem->ItemLimitCategory
- ? item->GetGemCountWithLimitCategory(pGem->ItemLimitCategory) : 1;
+ uint32 gem_limit_count = !pItem->IsEquipped() && pGem->ItemLimitCategory
+ ? pItem->GetGemCountWithLimitCategory(pGem->ItemLimitCategory) : 1;
if (InventoryResult res = CanEquipUniqueItem(pGem, eslot, gem_limit_count))
return res;
diff --git a/src/server/game/Entities/Player/Player.h b/src/server/game/Entities/Player/Player.h
index 0ee2743e319..7f6b2322e93 100755
--- a/src/server/game/Entities/Player/Player.h
+++ b/src/server/game/Entities/Player/Player.h
@@ -1233,70 +1233,70 @@ class Player : public Unit, public GridObject<Player>
bool CanNoReagentCast(SpellInfo const* spellInfo) const;
bool HasItemOrGemWithIdEquipped(uint32 item, uint32 count, uint8 except_slot = NULL_SLOT) const;
bool HasItemOrGemWithLimitCategoryEquipped(uint32 limitCategory, uint32 count, uint8 except_slot = NULL_SLOT) const;
- InventoryResult CanTakeMoreSimilarItems(Item* item) const { return CanTakeMoreSimilarItems(item->GetEntry(), item->GetCount(), item); }
+ InventoryResult CanTakeMoreSimilarItems(Item* pItem) const { return CanTakeMoreSimilarItems(pItem->GetEntry(), pItem->GetCount(), pItem); }
InventoryResult CanTakeMoreSimilarItems(uint32 entry, uint32 count) const { return CanTakeMoreSimilarItems(entry, count, NULL); }
InventoryResult CanStoreNewItem(uint8 bag, uint8 slot, ItemPosCountVec& dest, uint32 item, uint32 count, uint32* no_space_count = NULL) const
{
return CanStoreItem(bag, slot, dest, item, count, NULL, false, no_space_count);
}
- InventoryResult CanStoreItem(uint8 bag, uint8 slot, ItemPosCountVec& dest, Item* item, bool swap = false) const
+ InventoryResult CanStoreItem(uint8 bag, uint8 slot, ItemPosCountVec& dest, Item* pItem, bool swap = false) const
{
- if (!item)
+ if (!pItem)
return EQUIP_ERR_ITEM_NOT_FOUND;
- uint32 count = item->GetCount();
- return CanStoreItem(bag, slot, dest, item->GetEntry(), count, item, swap, NULL);
+ uint32 count = pItem->GetCount();
+ return CanStoreItem(bag, slot, dest, pItem->GetEntry(), count, pItem, swap, NULL);
}
- InventoryResult CanStoreItems(Item** item, int count) const;
+ InventoryResult CanStoreItems(Item** pItem, int count) const;
InventoryResult CanEquipNewItem(uint8 slot, uint16& dest, uint32 item, bool swap) const;
- InventoryResult CanEquipItem(uint8 slot, uint16& dest, Item* item, bool swap, bool not_loading = true) const;
+ InventoryResult CanEquipItem(uint8 slot, uint16& dest, Item* pItem, bool swap, bool not_loading = true) const;
- InventoryResult CanEquipUniqueItem(Item* item, uint8 except_slot = NULL_SLOT, uint32 limit_count = 1) const;
+ InventoryResult CanEquipUniqueItem(Item* pItem, uint8 except_slot = NULL_SLOT, uint32 limit_count = 1) const;
InventoryResult CanEquipUniqueItem(ItemTemplate const* itemProto, uint8 except_slot = NULL_SLOT, uint32 limit_count = 1) const;
InventoryResult CanUnequipItems(uint32 item, uint32 count) const;
InventoryResult CanUnequipItem(uint16 src, bool swap) const;
- InventoryResult CanBankItem(uint8 bag, uint8 slot, ItemPosCountVec& dest, Item* item, bool swap, bool not_loading = true) const;
- InventoryResult CanUseItem(Item* item, bool not_loading = true) const;
+ InventoryResult CanBankItem(uint8 bag, uint8 slot, ItemPosCountVec& dest, Item* pItem, bool swap, bool not_loading = true) const;
+ InventoryResult CanUseItem(Item* pItem, bool not_loading = true) const;
bool HasItemTotemCategory(uint32 TotemCategory) const;
- InventoryResult CanUseItem(ItemTemplate const* item) const;
+ InventoryResult CanUseItem(ItemTemplate const* pItem) const;
InventoryResult CanUseAmmo(uint32 item) const;
InventoryResult CanRollForItemInLFG(ItemTemplate const* item, WorldObject const* lootedObject) const;
Item* StoreNewItem(ItemPosCountVec const& pos, uint32 item, bool update, int32 randomPropertyId = 0);
Item* StoreNewItem(ItemPosCountVec const& pos, uint32 item, bool update, int32 randomPropertyId, AllowedLooterSet &allowedLooters);
- Item* StoreItem(ItemPosCountVec const& pos, Item* item, bool update);
+ Item* StoreItem(ItemPosCountVec const& pos, Item* pItem, bool update);
Item* EquipNewItem(uint16 pos, uint32 item, bool update);
- Item* EquipItem(uint16 pos, Item* item, bool update);
+ Item* EquipItem(uint16 pos, Item* pItem, bool update);
void AutoUnequipOffhandIfNeed(bool force = false);
bool StoreNewItemInBestSlots(uint32 item_id, uint32 item_count);
void AutoStoreLoot(uint8 bag, uint8 slot, uint32 loot_id, LootStore const& store, bool broadcast = false);
void AutoStoreLoot(uint32 loot_id, LootStore const& store, bool broadcast = false) { AutoStoreLoot(NULL_BAG, NULL_SLOT, loot_id, store, broadcast); }
void StoreLootItem(uint8 lootSlot, Loot* loot);
- InventoryResult CanTakeMoreSimilarItems(uint32 entry, uint32 count, Item* item, uint32* no_space_count = NULL) const;
- InventoryResult CanStoreItem(uint8 bag, uint8 slot, ItemPosCountVec& dest, uint32 entry, uint32 count, Item* item = NULL, bool swap = false, uint32* no_space_count = NULL) const;
+ InventoryResult CanTakeMoreSimilarItems(uint32 entry, uint32 count, Item* pItem, uint32* no_space_count = NULL) const;
+ InventoryResult CanStoreItem(uint8 bag, uint8 slot, ItemPosCountVec& dest, uint32 entry, uint32 count, Item* pItem = NULL, bool swap = false, uint32* no_space_count = NULL) const;
void AddRefundReference(uint32 it);
void DeleteRefundReference(uint32 it);
- void ApplyEquipCooldown(Item* item);
+ void ApplyEquipCooldown(Item* pItem);
void SetAmmo(uint32 item);
void RemoveAmmo();
float GetAmmoDPS() const { return m_ammoDPS; }
bool CheckAmmoCompatibility(const ItemTemplate* ammo_proto) const;
- void QuickEquipItem(uint16 pos, Item* item);
- void VisualizeItem(uint8 slot, Item* item);
- void SetVisibleItemSlot(uint8 slot, Item* item);
- Item* BankItem(ItemPosCountVec const& dest, Item* item, bool update)
+ void QuickEquipItem(uint16 pos, Item* pItem);
+ void VisualizeItem(uint8 slot, Item* pItem);
+ void SetVisibleItemSlot(uint8 slot, Item* pItem);
+ Item* BankItem(ItemPosCountVec const& dest, Item* pItem, bool update)
{
- return StoreItem(dest, item, update);
+ return StoreItem(dest, pItem, update);
}
- Item* BankItem(uint16 pos, Item* item, bool update);
+ Item* BankItem(uint16 pos, Item* pItem, bool update);
void RemoveItem(uint8 bag, uint8 slot, bool update);
void MoveItemFromInventory(uint8 bag, uint8 slot, bool update);
// in trade, auction, guild bank, mail....
- void MoveItemToInventory(ItemPosCountVec const& dest, Item* item, bool update, bool in_characterInventoryDB = false);
+ void MoveItemToInventory(ItemPosCountVec const& dest, Item* pItem, bool update, bool in_characterInventoryDB = false);
// in trade, guild bank, mail....
- void RemoveItemDependentAurasAndCasts(Item* item);
+ void RemoveItemDependentAurasAndCasts(Item* pItem);
void DestroyItem(uint8 bag, uint8 slot, bool update);
void DestroyItemCount(uint32 item, uint32 count, bool update, bool unequip_check = false);
void DestroyItemCount(Item* item, uint32& count, bool update);
@@ -1304,11 +1304,11 @@ class Player : public Unit, public GridObject<Player>
void DestroyZoneLimitedItem(bool update, uint32 new_zone);
void SplitItem(uint16 src, uint16 dst, uint32 count);
void SwapItem(uint16 src, uint16 dst);
- void AddItemToBuyBackSlot(Item* item);
+ void AddItemToBuyBackSlot(Item* pItem);
Item* GetItemFromBuyBackSlot(uint32 slot);
void RemoveItemFromBuyBackSlot(uint32 slot, bool del);
uint32 GetMaxKeyringSize() const { return KEYRING_SLOT_END-KEYRING_SLOT_START; }
- void SendEquipError(InventoryResult msg, Item* item, Item* pItem2 = NULL, uint32 itemid = 0);
+ void SendEquipError(InventoryResult msg, Item* pItem, Item* pItem2 = NULL, uint32 itemid = 0);
void SendBuyError(BuyResult msg, Creature* creature, uint32 item, uint32 param);
void SendSellError(SellResult msg, Creature* creature, uint64 guid, uint32 param);
void AddWeaponProficiency(uint32 newflag) { m_WeaponProficiency |= newflag; }
@@ -2789,7 +2789,7 @@ class Player : public Unit, public GridObject<Player>
InventoryResult CanStoreItem_InSpecificSlot(uint8 bag, uint8 slot, ItemPosCountVec& dest, ItemTemplate const* pProto, uint32& count, bool swap, Item* pSrcItem) const;
InventoryResult CanStoreItem_InBag(uint8 bag, ItemPosCountVec& dest, ItemTemplate const* pProto, uint32& count, bool merge, bool non_specialized, Item* pSrcItem, uint8 skip_bag, uint8 skip_slot) const;
InventoryResult CanStoreItem_InInventorySlots(uint8 slot_begin, uint8 slot_end, ItemPosCountVec& dest, ItemTemplate const* pProto, uint32& count, bool merge, Item* pSrcItem, uint8 skip_bag, uint8 skip_slot) const;
- Item* _StoreItem(uint16 pos, Item* item, uint32 count, bool clone, bool update);
+ Item* _StoreItem(uint16 pos, Item* pItem, uint32 count, bool clone, bool update);
Item* _LoadItem(SQLTransaction& trans, uint32 zoneId, uint32 timeDiff, Field* fields);
std::set<uint32> m_refundableItems;