Core/Items: Fixed item spell charge slot indexing

Closes #30585

(cherry picked from commit c85d12fc3f0576163d4ffa91bb38f66894305349)

# Conflicts:
#	src/server/game/Entities/Item/Item.h
#	src/server/game/Globals/ObjectMgr.cpp

1 files changed, 6 insertions, 1 deletions

diff --git a/src/server/game/Globals/ObjectMgr.cpp b/src/server/game/Globals/ObjectMgr.cpp
index 6de875906ee..05cf9899c35 100644
--- a/src/server/game/Globals/ObjectMgr.cpp
+++ b/src/server/game/Globals/ObjectMgr.cpp
@@ -3109,8 +3109,13 @@ void ObjectMgr::LoadItemTemplates()
 
         // Load item effects (spells)
         if (std::vector<ItemEffectEntry const*> const* itemEffects = sDB2Manager.GetItemEffectsForItemId(sparse->ID))
+        {
             for (ItemEffectEntry const* itemEffect : *itemEffects)
-                itemTemplate.Effects.push_back(itemEffect);
+            {
+                auto itr = std::ranges::lower_bound(itemTemplate.Effects, itemEffect->LegacySlotIndex, {}, &ItemEffectEntry::LegacySlotIndex);
+                itemTemplate.Effects.insert(itr, itemEffect);
+            }
+        }
     }
 
     TC_LOG_INFO("server.loading", ">> Loaded {} item templates in {} ms", _itemTemplateStore.size(), GetMSTimeDiffToNow(oldMSTime));