Core/Guilds: Prevent guild bank packet contents update hack from interfering with buying new bank tabs

Closes #30277

(cherry picked from commit e3d0b803d7c5ed564aabe6d348b4f96a48ef39cc)

1 files changed, 7 insertions, 1 deletions

diff --git a/src/server/game/Guilds/Guild.cpp b/src/server/game/Guilds/Guild.cpp
index df4855208d5..ac91cf6a929 100644
--- a/src/server/game/Guilds/Guild.cpp
+++ b/src/server/game/Guilds/Guild.cpp
@@ -3633,6 +3633,12 @@ void Guild::SendBankList(WorldSession* session, uint8 tabId, bool fullUpdate) co
     if (!member) // Shouldn't happen, just in case
         return;
 
+    // HACK: client doesn't query entire tab content if it had received SMSG_GUILD_BANK_LIST in this session
+    // but we broadcast bank updates to entire guild when *ANYONE* changes anything, incorrectly initializing clients
+    // tab content with only data for that change
+    if (!fullUpdate && tabId < _GetPurchasedTabsSize())
+        fullUpdate = true;
+
     WorldPackets::Guild::GuildBankQueryResults packet;
 
     packet.Money = m_bankMoney;
@@ -3674,7 +3680,7 @@ void Guild::SendBankList(WorldSession* session, uint8 tabId, bool fullUpdate) co
                     WorldPackets::Guild::GuildBankItemInfo& itemInfo = packet.ItemInfo.emplace_back();
 
                     itemInfo.Slot = int32(slotId);
-                    itemInfo.Item.ItemID = tabItem->GetEntry();
+                    itemInfo.Item.Initialize(tabItem);
                     itemInfo.Count = int32(tabItem->GetCount());
                     itemInfo.Charges = int32(abs(tabItem->GetSpellCharges()));
                     itemInfo.EnchantmentID = int32(tabItem->GetEnchantmentId(PERM_ENCHANTMENT_SLOT));