aboutsummaryrefslogtreecommitdiff
path: root/src/server/game/Handlers/GroupHandler.cpp
diff options
context:
space:
mode:
authorariel- <ariel-@users.noreply.github.com>2017-01-28 01:27:39 -0300
committerariel- <ariel-@users.noreply.github.com>2017-01-28 01:27:39 -0300
commit6f9e8b6c9174249025562faf9ad4c56bbb642547 (patch)
tree83eaf8c9bb1fbebb225d9b2dd614dfa9d0da68e7 /src/server/game/Handlers/GroupHandler.cpp
parentb955456008191e60b6bda1f22e3486a3792b08db (diff)
Core: add some missing Player Name normalization on input data
Diffstat (limited to 'src/server/game/Handlers/GroupHandler.cpp')
-rw-r--r--src/server/game/Handlers/GroupHandler.cpp14
1 files changed, 7 insertions, 7 deletions
diff --git a/src/server/game/Handlers/GroupHandler.cpp b/src/server/game/Handlers/GroupHandler.cpp
index 05b39c4788a..c94c4dfce4e 100644
--- a/src/server/game/Handlers/GroupHandler.cpp
+++ b/src/server/game/Handlers/GroupHandler.cpp
@@ -588,6 +588,9 @@ void WorldSession::HandleGroupChangeSubGroupOpcode(WorldPacket& recvData)
recvData >> name;
recvData >> groupNr;
+ if (!normalizePlayerName(name))
+ return;
+
if (groupNr >= MAX_RAID_SUBGROUPS)
return;
@@ -598,17 +601,14 @@ void WorldSession::HandleGroupChangeSubGroupOpcode(WorldPacket& recvData)
if (!group->HasFreeSlotSubGroup(groupNr))
return;
- Player* movedPlayer = ObjectAccessor::FindConnectedPlayerByName(name);
ObjectGuid guid;
- if (movedPlayer)
- {
+ if (Player* movedPlayer = ObjectAccessor::FindConnectedPlayerByName(name))
guid = movedPlayer->GetGUID();
- }
else
- {
- CharacterDatabase.EscapeString(name);
guid = sWorld->GetCharacterGuidByName(name);
- }
+
+ if (guid.IsEmpty())
+ return;
group->ChangeMembersGroup(guid, groupNr);
}