Core/Guild: avoid data integrity problems wrapping delete+insert statements in a transaction

(cherry picked from commit 25281ecb3198a543ddb18aab41b8a206512bdd0c)

1 files changed, 13 insertions, 7 deletions

diff --git a/src/server/game/Handlers/PetitionsHandler.cpp b/src/server/game/Handlers/PetitionsHandler.cpp
index 736d6138cf4..922bc519e13 100644
--- a/src/server/game/Handlers/PetitionsHandler.cpp
+++ b/src/server/game/Handlers/PetitionsHandler.cpp
@@ -536,15 +536,21 @@ void WorldSession::HandleTurnInPetition(WorldPackets::Petition::TurnInPetition&
 
     Guild::SendCommandResult(this, GUILD_COMMAND_CREATE_GUILD, ERR_GUILD_COMMAND_SUCCESS, name);
 
-    // Add members from signatures
-    for (uint8 i = 0; i < signatures; ++i)
     {
-        Field* fields = result->Fetch();
-        guild->AddMember(ObjectGuid::Create<HighGuid::Player>(fields[0].GetUInt64()));
+        SQLTransaction trans = CharacterDatabase.BeginTransaction();
 
-        // Checking the return value just to be double safe
-        if (!result->NextRow())
-            break;
+        // Add members from signatures
+        for (uint8 i = 0; i < signatures; ++i)
+        {
+            Field* fields = result->Fetch();
+            guild->AddMember(trans, ObjectGuid::Create<HighGuid::Player>(fields[0].GetUInt64()));
+
+            // Checking the return value just to be double safe
+            if (!result->NextRow())
+                break;
+        }
+
+        CharacterDatabase.CommitTransaction(trans);
     }
 
     SQLTransaction trans = CharacterDatabase.BeginTransaction();